Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1242614

[PATCH] dmaengine: zxdma: fix memset that is currently doing nothing

From Colin King <colin.king@canonical.com>
Newsgroups linux.kernel
Subject [PATCH] dmaengine: zxdma: fix memset that is currently doing nothing
Date 2015-10-08 19:10 +0200
Message-ID <qhmRA-1ld-1@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


From: Colin Ian King <colin.king@canonical.com>

The size and value arguments are swapped in the call to memset
effectively making it a no-op because of the zero size.  Swap
these arguments around to do the memset correctly.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/dma/zx296702_dma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/zx296702_dma.c b/drivers/dma/zx296702_dma.c
index c017fcd..245d759 100644
--- a/drivers/dma/zx296702_dma.c
+++ b/drivers/dma/zx296702_dma.c
@@ -441,7 +441,7 @@ static struct zx_dma_desc_sw *zx_alloc_desc_resource(int num,
 		kfree(ds);
 		return NULL;
 	}
-	memset(ds->desc_hw, sizeof(struct zx_desc_hw) * num, 0);
+	memset(ds->desc_hw, 0, sizeof(struct zx_desc_hw) * num);
 	ds->desc_num = num;
 	return ds;
 }
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH] dmaengine: zxdma: fix memset that is currently doing nothing Colin King <colin.king@canonical.com> - 2015-10-08 19:10 +0200
  Re: [PATCH] dmaengine: zxdma: fix memset that is currently doing  nothing Vinod Koul <vinod.koul@intel.com> - 2015-10-09 18:00 +0200

csiph-web