Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1243737 > unrolled thread
| Started by | Russell King - ARM Linux <linux@arm.linux.org.uk> |
|---|---|
| First post | 2015-10-10 01:30 +0200 |
| Last post | 2015-10-10 17:40 +0200 |
| Articles | 5 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] sched_clock: add data pointer argument to read callback Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-10-10 01:30 +0200
Re: [PATCH] sched_clock: add data pointer argument to read callback Måns Rullgård <mans@mansr.com> - 2015-10-10 01:50 +0200
Re: [PATCH] sched_clock: add data pointer argument to read callback Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-10-10 02:00 +0200
Re: [PATCH] sched_clock: add data pointer argument to read callback Måns Rullgård <mans@mansr.com> - 2015-10-10 02:50 +0200
Re: [PATCH] sched_clock: add data pointer argument to read callback Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-10-10 17:40 +0200
| From | Russell King - ARM Linux <linux@arm.linux.org.uk> |
|---|---|
| Date | 2015-10-10 01:30 +0200 |
| Subject | Re: [PATCH] sched_clock: add data pointer argument to read callback |
| Message-ID | <qhPgS-8oj-5@gated-at.bofh.it> |
On Fri, Oct 09, 2015 at 10:57:35PM +0100, Mans Rullgard wrote: > This passes a data pointer specified in the sched_clock_register() > call to the read callback allowing simpler implementations thereof. > > In this patch, existing uses of this interface are simply updated > with a null pointer. This is a bad description. It tells us what the patch is doing, (which we can see by reading the patch) but not _why_. Please include information on why the change is necessary - describe what you are trying to achieve. I generally don't accept patches what add new stuff to the kernel with no users of that new stuff - that's called experience, experience of people who submit stuff like that, and then vanish leaving their junk in the kernel without any users. Please ensure that this gets a user very quickly, or better still, submit this patch as part of a series which makes use of it. Also, copying soo many people is guaranteed to be silently dropped by mailing lists. -- FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Måns Rullgård <mans@mansr.com> |
|---|---|
| Date | 2015-10-10 01:50 +0200 |
| Message-ID | <qhPAd-jk-3@gated-at.bofh.it> |
| In reply to | #1243737 |
Russell King - ARM Linux <linux@arm.linux.org.uk> writes: > On Fri, Oct 09, 2015 at 10:57:35PM +0100, Mans Rullgard wrote: >> This passes a data pointer specified in the sched_clock_register() >> call to the read callback allowing simpler implementations thereof. >> >> In this patch, existing uses of this interface are simply updated >> with a null pointer. > > This is a bad description. It tells us what the patch is doing, > (which we can see by reading the patch) but not _why_. Please include > information on why the change is necessary - describe what you are > trying to achieve. Currently most of the callbacks use a global variable to store the address of a counter register. This has several downsides: - Loading the address of a global variable can be more expensive than keeping a pointer next to the function pointer. - It makes it impossible to have multiple instances of a driver call sched_clock_register() since the caller can't know which clock will win in the end. - Many of the existing callbacks are practically identical and could be replaced with a common generic function if it had a pointer argument. If I've missed something that makes this a stupid idea, please tell. -- Måns Rullgård mans@mansr.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Russell King - ARM Linux <linux@arm.linux.org.uk> |
|---|---|
| Date | 2015-10-10 02:00 +0200 |
| Message-ID | <qhPJU-v0-1@gated-at.bofh.it> |
| In reply to | #1243741 |
On Sat, Oct 10, 2015 at 12:48:22AM +0100, Måns Rullgård wrote: > Russell King - ARM Linux <linux@arm.linux.org.uk> writes: > > > On Fri, Oct 09, 2015 at 10:57:35PM +0100, Mans Rullgard wrote: > >> This passes a data pointer specified in the sched_clock_register() > >> call to the read callback allowing simpler implementations thereof. > >> > >> In this patch, existing uses of this interface are simply updated > >> with a null pointer. > > > > This is a bad description. It tells us what the patch is doing, > > (which we can see by reading the patch) but not _why_. Please include > > information on why the change is necessary - describe what you are > > trying to achieve. > > Currently most of the callbacks use a global variable to store the > address of a counter register. This has several downsides: > > - Loading the address of a global variable can be more expensive than > keeping a pointer next to the function pointer. > > - It makes it impossible to have multiple instances of a driver call > sched_clock_register() since the caller can't know which clock will > win in the end. > > - Many of the existing callbacks are practically identical and could be > replaced with a common generic function if it had a pointer argument. > > If I've missed something that makes this a stupid idea, please tell. So my next question is whether you intend to pass an iomem pointer through this, or a some kind of structure, or both. It matters, because iomem pointers have a __iomem attribute to keep sparse happy. Having to force that attribute on and off pointers is frowned upon, as it defeats the purpose of the sparse static checker. -- FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Måns Rullgård <mans@mansr.com> |
|---|---|
| Date | 2015-10-10 02:50 +0200 |
| Message-ID | <qhQwh-1ED-3@gated-at.bofh.it> |
| In reply to | #1243743 |
Russell King - ARM Linux <linux@arm.linux.org.uk> writes: > On Sat, Oct 10, 2015 at 12:48:22AM +0100, Måns Rullgård wrote: >> Russell King - ARM Linux <linux@arm.linux.org.uk> writes: >> >> > On Fri, Oct 09, 2015 at 10:57:35PM +0100, Mans Rullgard wrote: >> >> This passes a data pointer specified in the sched_clock_register() >> >> call to the read callback allowing simpler implementations thereof. >> >> >> >> In this patch, existing uses of this interface are simply updated >> >> with a null pointer. >> > >> > This is a bad description. It tells us what the patch is doing, >> > (which we can see by reading the patch) but not _why_. Please include >> > information on why the change is necessary - describe what you are >> > trying to achieve. >> >> Currently most of the callbacks use a global variable to store the >> address of a counter register. This has several downsides: >> >> - Loading the address of a global variable can be more expensive than >> keeping a pointer next to the function pointer. >> >> - It makes it impossible to have multiple instances of a driver call >> sched_clock_register() since the caller can't know which clock will >> win in the end. >> >> - Many of the existing callbacks are practically identical and could be >> replaced with a common generic function if it had a pointer argument. >> >> If I've missed something that makes this a stupid idea, please tell. > > So my next question is whether you intend to pass an iomem pointer > through this, or a some kind of structure, or both. It matters, > because iomem pointers have a __iomem attribute to keep sparse > happy. Having to force that attribute on and off pointers is frowned > upon, as it defeats the purpose of the sparse static checker. So this is an instance where tools like sparse get in the way of doing the simplest, most efficient, and obviously correct thing. Who wins in such cases? -- Måns Rullgård mans@mansr.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Russell King - ARM Linux <linux@arm.linux.org.uk> |
|---|---|
| Date | 2015-10-10 17:40 +0200 |
| Message-ID | <qi4pA-54b-25@gated-at.bofh.it> |
| In reply to | #1243752 |
On Sat, Oct 10, 2015 at 01:42:47AM +0100, Måns Rullgård wrote: > Russell King - ARM Linux <linux@arm.linux.org.uk> writes: > > > On Sat, Oct 10, 2015 at 12:48:22AM +0100, Måns Rullgård wrote: > >> Russell King - ARM Linux <linux@arm.linux.org.uk> writes: > >> > >> > On Fri, Oct 09, 2015 at 10:57:35PM +0100, Mans Rullgard wrote: > >> >> This passes a data pointer specified in the sched_clock_register() > >> >> call to the read callback allowing simpler implementations thereof. > >> >> > >> >> In this patch, existing uses of this interface are simply updated > >> >> with a null pointer. > >> > > >> > This is a bad description. It tells us what the patch is doing, > >> > (which we can see by reading the patch) but not _why_. Please include > >> > information on why the change is necessary - describe what you are > >> > trying to achieve. > >> > >> Currently most of the callbacks use a global variable to store the > >> address of a counter register. This has several downsides: > >> > >> - Loading the address of a global variable can be more expensive than > >> keeping a pointer next to the function pointer. > >> > >> - It makes it impossible to have multiple instances of a driver call > >> sched_clock_register() since the caller can't know which clock will > >> win in the end. > >> > >> - Many of the existing callbacks are practically identical and could be > >> replaced with a common generic function if it had a pointer argument. > >> > >> If I've missed something that makes this a stupid idea, please tell. > > > > So my next question is whether you intend to pass an iomem pointer > > through this, or a some kind of structure, or both. It matters, > > because iomem pointers have a __iomem attribute to keep sparse > > happy. Having to force that attribute on and off pointers is frowned > > upon, as it defeats the purpose of the sparse static checker. > > So this is an instance where tools like sparse get in the way of doing > the simplest, most efficient, and obviously correct thing. Who wins in > such cases? In that case, NAK on the patch. I don't have time for your stupid games. -- FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web