Re: [PATCH] sched_clock: add data pointer argument to read callback

From	Russell King - ARM Linux <linux@arm.linux.org.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH] sched_clock: add data pointer argument to read callback
Date	2015-10-10 01:30 +0200
Message-ID	<qhPgS-8oj-5@gated-at.bofh.it> (permalink)
References	<qhPgS-8oj-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Oct 09, 2015 at 10:57:35PM +0100, Mans Rullgard wrote:
> This passes a data pointer specified in the sched_clock_register()
> call to the read callback allowing simpler implementations thereof.
> 
> In this patch, existing uses of this interface are simply updated
> with a null pointer.

This is a bad description.  It tells us what the patch is doing,
(which we can see by reading the patch) but not _why_.  Please include
information on why the change is necessary - describe what you are
trying to achieve.

I generally don't accept patches what add new stuff to the kernel with
no users of that new stuff - that's called experience, experience of
people who submit stuff like that, and then vanish leaving their junk
in the kernel without any users.  Please ensure that this gets a user
very quickly, or better still, submit this patch as part of a series
which makes use of it.

Also, copying soo many people is guaranteed to be silently dropped by
mailing lists.

-- 
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] sched_clock: add data pointer argument to read callback Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-10-10 01:30 +0200
  Re: [PATCH] sched_clock: add data pointer argument to read callback Måns Rullgård <mans@mansr.com> - 2015-10-10 01:50 +0200
    Re: [PATCH] sched_clock: add data pointer argument to read callback Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-10-10 02:00 +0200
      Re: [PATCH] sched_clock: add data pointer argument to read callback Måns Rullgård <mans@mansr.com> - 2015-10-10 02:50 +0200
        Re: [PATCH] sched_clock: add data pointer argument to read callback Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-10-10 17:40 +0200

csiph-web