Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1240969 > unrolled thread

[PATCH] genirq: export handle_bad_irq

Started byArnd Bergmann <arnd@arndb.de>
First post2015-10-06 22:30 +0200
Last post2015-10-09 17:30 +0200
Articles 6 — 4 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] genirq: export handle_bad_irq Arnd Bergmann <arnd@arndb.de> - 2015-10-06 22:30 +0200
    Re: [PATCH] genirq: export handle_bad_irq kbuild test robot <lkp@intel.com> - 2015-10-06 23:00 +0200
      [PATCH] genirq: fix handle_bad_irq kerneldoc comment Arnd Bergmann <arnd@arndb.de> - 2015-10-06 23:10 +0200
        [tip:irq/urgent] genirq: Fix handle_bad_irq kerneldoc comment tip-bot for Arnd Bergmann <tipbot@zytor.com> - 2015-10-09 17:30 +0200
    Re: [PATCH] genirq: export handle_bad_irq Grygorii Strashko <grygorii.strashko@ti.com> - 2015-10-07 21:20 +0200
    [tip:irq/urgent] genirq: Export handle_bad_irq tip-bot for Arnd Bergmann <tipbot@zytor.com> - 2015-10-09 17:30 +0200

#1240969 — [PATCH] genirq: export handle_bad_irq

FromArnd Bergmann <arnd@arndb.de>
Date2015-10-06 22:30 +0200
Subject[PATCH] genirq: export handle_bad_irq
Message-ID<qgH22-8u5-19@gated-at.bofh.it>
A cleanup of the omap gpio driver introduced a use of the
handle_bad_irq() function in a device driver that can be
a loadable module.

This broke the ARM allmodconfig build:

ERROR: "handle_bad_irq" [drivers/gpio/gpio-omap.ko] undefined!

This patch exports the handle_bad_irq symbol in order to
allow the use in modules.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 450fa54cfd66 ("gpio: omap: convert to use generic irq handler")

diff --git a/kernel/irq/handle.c b/kernel/irq/handle.c
index ea7b5fd99ba5..142bbf3b607f 100644
--- a/kernel/irq/handle.c
+++ b/kernel/irq/handle.c
@@ -35,6 +35,7 @@ void handle_bad_irq(struct irq_desc *desc)
 	kstat_incr_irqs_this_cpu(desc);
 	ack_bad_irq(irq);
 }
+EXPORT_SYMBOL_GPL(handle_bad_irq);
 
 /*
  * Special, empty irq handler:

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1240988

Fromkbuild test robot <lkp@intel.com>
Date2015-10-06 23:00 +0200
Message-ID<qgHv4-AR-9@gated-at.bofh.it>
In reply to#1240969

[Multipart message — attachments visible in raw view] — view raw

Hi Arnd,

[auto build test WARNING on v4.3-rc4 -- if it's inappropriate base, please ignore]

reproduce: make htmldocs

All warnings (new ones prefixed by >>):

   kernel/irq/handle.c:31: warning: Excess function parameter 'irq' description in 'handle_bad_irq'
>> kernel/irq/handle.c:1: warning: no structured comments found

vim +1 kernel/irq/handle.c

^1da177e Linus Torvalds     2005-04-16  @1  /*
^1da177e Linus Torvalds     2005-04-16   2   * linux/kernel/irq/handle.c
^1da177e Linus Torvalds     2005-04-16   3   *
a34db9b2 Ingo Molnar        2006-06-29   4   * Copyright (C) 1992, 1998-2006 Linus Torvalds, Ingo Molnar
a34db9b2 Ingo Molnar        2006-06-29   5   * Copyright (C) 2005-2006, Thomas Gleixner, Russell King
^1da177e Linus Torvalds     2005-04-16   6   *
^1da177e Linus Torvalds     2005-04-16   7   * This file contains the core interrupt handling code.
a34db9b2 Ingo Molnar        2006-06-29   8   *
a34db9b2 Ingo Molnar        2006-06-29   9   * Detailed information is available in Documentation/DocBook/genericirq
a34db9b2 Ingo Molnar        2006-06-29  10   *
^1da177e Linus Torvalds     2005-04-16  11   */
^1da177e Linus Torvalds     2005-04-16  12  
^1da177e Linus Torvalds     2005-04-16  13  #include <linux/irq.h>
^1da177e Linus Torvalds     2005-04-16  14  #include <linux/random.h>
3795de23 Thomas Gleixner    2010-09-22  15  #include <linux/sched.h>
^1da177e Linus Torvalds     2005-04-16  16  #include <linux/interrupt.h>
^1da177e Linus Torvalds     2005-04-16  17  #include <linux/kernel_stat.h>
3795de23 Thomas Gleixner    2010-09-22  18  
ad8d75ff Steven Rostedt     2009-04-14  19  #include <trace/events/irq.h>
^1da177e Linus Torvalds     2005-04-16  20  
^1da177e Linus Torvalds     2005-04-16  21  #include "internals.h"
^1da177e Linus Torvalds     2005-04-16  22  
6a6de9ef Thomas Gleixner    2006-06-29  23  /**
6a6de9ef Thomas Gleixner    2006-06-29  24   * handle_bad_irq - handle spurious and unhandled irqs
43a1dd50 Henrik Kretzschmar 2006-08-31  25   * @irq:       the interrupt number
43a1dd50 Henrik Kretzschmar 2006-08-31  26   * @desc:      description of the interrupt
43a1dd50 Henrik Kretzschmar 2006-08-31  27   *
43a1dd50 Henrik Kretzschmar 2006-08-31  28   * Handles spurious and unhandled IRQ's. It also prints a debugmessage.
6a6de9ef Thomas Gleixner    2006-06-29  29   */
bd0b9ac4 Thomas Gleixner    2015-09-14  30  void handle_bad_irq(struct irq_desc *desc)
6a6de9ef Thomas Gleixner    2006-06-29 @31  {
bd0b9ac4 Thomas Gleixner    2015-09-14  32  	unsigned int irq = irq_desc_get_irq(desc);
bd0b9ac4 Thomas Gleixner    2015-09-14  33  
43f77759 Ingo Molnar        2006-06-29  34  	print_irq_desc(irq, desc);

:::::: The code at line 1 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2

:::::: TO: Linus Torvalds <torvalds@ppc970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@ppc970.osdl.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[toc] | [prev] | [next] | [standalone]

#1240999 — [PATCH] genirq: fix handle_bad_irq kerneldoc comment

FromArnd Bergmann <arnd@arndb.de>
Date2015-10-06 23:10 +0200
Subject[PATCH] genirq: fix handle_bad_irq kerneldoc comment
Message-ID<qgHEK-11w-7@gated-at.bofh.it>
In reply to#1240988
A recent cleanup removed the 'irq' parameter from many functions, but
left the documentation for this in place for at least one function.

This removes it.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: bd0b9ac405e1 ("genirq: Remove irq argument from irq flow handlers")
---
On Wednesday 07 October 2015 04:51:56 kbuild test robot wrote:
> [auto build test WARNING on v4.3-rc4 -- if it's inappropriate base, please ignore]
> 
> reproduce: make htmldocs
> 
> All warnings (new ones prefixed by >>):
> 
>    kernel/irq/handle.c:31: warning: Excess function parameter 'irq' description in 'handle_bad_irq'
> >> kernel/irq/handle.c:1: warning: no structured comments found

This seems to be an unrelated bug, not sure why it wasn't caught earlier:

diff --git a/kernel/irq/handle.c b/kernel/irq/handle.c
index 142bbf3b607f..a302cf9a2126 100644
--- a/kernel/irq/handle.c
+++ b/kernel/irq/handle.c
@@ -22,7 +22,6 @@
 
 /**
  * handle_bad_irq - handle spurious and unhandled irqs
- * @irq:       the interrupt number
  * @desc:      description of the interrupt
  *
  * Handles spurious and unhandled IRQ's. It also prints a debugmessage.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1243473 — [tip:irq/urgent] genirq: Fix handle_bad_irq kerneldoc comment

Fromtip-bot for Arnd Bergmann <tipbot@zytor.com>
Date2015-10-09 17:30 +0200
Subject[tip:irq/urgent] genirq: Fix handle_bad_irq kerneldoc comment
Message-ID<qhHMm-63K-31@gated-at.bofh.it>
In reply to#1240999
Commit-ID:  e3096c9c7c645279808a6bf7ac2031b1895ddffb
Gitweb:     http://git.kernel.org/tip/e3096c9c7c645279808a6bf7ac2031b1895ddffb
Author:     Arnd Bergmann <arnd@arndb.de>
AuthorDate: Tue, 6 Oct 2015 22:59:40 +0200
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Fri, 9 Oct 2015 17:17:30 +0200

genirq: Fix handle_bad_irq kerneldoc comment

A recent cleanup removed the 'irq' parameter from many functions, but
left the documentation for this in place for at least one function.

This removes it.

Fixes: bd0b9ac405e1 ("genirq: Remove irq argument from irq flow handlers")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: Tony Lindgren <tony@atomide.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: kbuild-all@01.org
Cc: Austin Schuh <austin@peloton-tech.com>
Cc: Santosh Shilimkar <ssantosh@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org
Link: http://lkml.kernel.org/r/5400000.cD19rmgWjV@wuerfel
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 kernel/irq/handle.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/kernel/irq/handle.c b/kernel/irq/handle.c
index 77983fc..e25a83b 100644
--- a/kernel/irq/handle.c
+++ b/kernel/irq/handle.c
@@ -22,7 +22,6 @@
 
 /**
  * handle_bad_irq - handle spurious and unhandled irqs
- * @irq:       the interrupt number
  * @desc:      description of the interrupt
  *
  * Handles spurious and unhandled IRQ's. It also prints a debugmessage.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1241744

FromGrygorii Strashko <grygorii.strashko@ti.com>
Date2015-10-07 21:20 +0200
Message-ID<qh2pQ-5yQ-9@gated-at.bofh.it>
In reply to#1240969
Hi Arnd,

On 10/06/2015 03:24 PM, Arnd Bergmann wrote:
> A cleanup of the omap gpio driver introduced a use of the
> handle_bad_irq() function in a device driver that can be
> a loadable module.
>
> This broke the ARM allmodconfig build:
>
> ERROR: "handle_bad_irq" [drivers/gpio/gpio-omap.ko] undefined!
>
> This patch exports the handle_bad_irq symbol in order to
> allow the use in modules.
>

Thanks for fixing it and sorry for the mess.
Tested-by: Grygorii Strashko <grygorii.strashko@ti.com>


> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 450fa54cfd66 ("gpio: omap: convert to use generic irq handler")
>
> diff --git a/kernel/irq/handle.c b/kernel/irq/handle.c
> index ea7b5fd99ba5..142bbf3b607f 100644
> --- a/kernel/irq/handle.c
> +++ b/kernel/irq/handle.c
> @@ -35,6 +35,7 @@ void handle_bad_irq(struct irq_desc *desc)
>   	kstat_incr_irqs_this_cpu(desc);
>   	ack_bad_irq(irq);
>   }
> +EXPORT_SYMBOL_GPL(handle_bad_irq);
>
>   /*
>    * Special, empty irq handler:
>


-- 
regards,
-grygorii
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1243467 — [tip:irq/urgent] genirq: Export handle_bad_irq

Fromtip-bot for Arnd Bergmann <tipbot@zytor.com>
Date2015-10-09 17:30 +0200
Subject[tip:irq/urgent] genirq: Export handle_bad_irq
Message-ID<qhHMl-63K-9@gated-at.bofh.it>
In reply to#1240969
Commit-ID:  9d67dc5da59d63f746aad8f6ec4fbb86d6486f76
Gitweb:     http://git.kernel.org/tip/9d67dc5da59d63f746aad8f6ec4fbb86d6486f76
Author:     Arnd Bergmann <arnd@arndb.de>
AuthorDate: Tue, 6 Oct 2015 22:24:50 +0200
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Fri, 9 Oct 2015 17:17:30 +0200

genirq: Export handle_bad_irq

A cleanup of the omap gpio driver introduced a use of the
handle_bad_irq() function in a device driver that can be
a loadable module.

This broke the ARM allmodconfig build:

ERROR: "handle_bad_irq" [drivers/gpio/gpio-omap.ko] undefined!

This patch exports the handle_bad_irq symbol in order to
allow the use in modules.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: Santosh Shilimkar <ssantosh@kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Austin Schuh <austin@peloton-tech.com>
Cc: Tony Lindgren <tony@atomide.com>
Cc: linux-arm-kernel@lists.infradead.org
Link: http://lkml.kernel.org/r/5847725.4IBopItaOr@wuerfel
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

---
 kernel/irq/handle.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/irq/handle.c b/kernel/irq/handle.c
index de41a68..77983fc 100644
--- a/kernel/irq/handle.c
+++ b/kernel/irq/handle.c
@@ -35,6 +35,7 @@ void handle_bad_irq(struct irq_desc *desc)
 	kstat_incr_irqs_this_cpu(desc);
 	ack_bad_irq(irq);
 }
+EXPORT_SYMBOL_GPL(handle_bad_irq);
 
 /*
  * Special, empty irq handler:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web