Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1241744

Re: [PATCH] genirq: export handle_bad_irq

Show all headers | View raw

Hi Arnd,

On 10/06/2015 03:24 PM, Arnd Bergmann wrote:
> A cleanup of the omap gpio driver introduced a use of the
> handle_bad_irq() function in a device driver that can be
> a loadable module.
>
> This broke the ARM allmodconfig build:
>
> ERROR: "handle_bad_irq" [drivers/gpio/gpio-omap.ko] undefined!
>
> This patch exports the handle_bad_irq symbol in order to
> allow the use in modules.
>

Thanks for fixing it and sorry for the mess.
Tested-by: Grygorii Strashko <grygorii.strashko@ti.com>


> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 450fa54cfd66 ("gpio: omap: convert to use generic irq handler")
>
> diff --git a/kernel/irq/handle.c b/kernel/irq/handle.c
> index ea7b5fd99ba5..142bbf3b607f 100644
> --- a/kernel/irq/handle.c
> +++ b/kernel/irq/handle.c
> @@ -35,6 +35,7 @@ void handle_bad_irq(struct irq_desc *desc)
>   	kstat_incr_irqs_this_cpu(desc);
>   	ack_bad_irq(irq);
>   }
> +EXPORT_SYMBOL_GPL(handle_bad_irq);
>
>   /*
>    * Special, empty irq handler:
>


-- 
regards,
-grygorii
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] genirq: export handle_bad_irq Arnd Bergmann <arnd@arndb.de> - 2015-10-06 22:30 +0200
  Re: [PATCH] genirq: export handle_bad_irq kbuild test robot <lkp@intel.com> - 2015-10-06 23:00 +0200
    [PATCH] genirq: fix handle_bad_irq kerneldoc comment Arnd Bergmann <arnd@arndb.de> - 2015-10-06 23:10 +0200
      [tip:irq/urgent] genirq: Fix handle_bad_irq kerneldoc comment tip-bot for Arnd Bergmann <tipbot@zytor.com> - 2015-10-09 17:30 +0200
  Re: [PATCH] genirq: export handle_bad_irq Grygorii Strashko <grygorii.strashko@ti.com> - 2015-10-07 21:20 +0200
  [tip:irq/urgent] genirq: Export handle_bad_irq tip-bot for Arnd Bergmann <tipbot@zytor.com> - 2015-10-09 17:30 +0200

csiph-web