Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1241457 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2015-10-07 14:50 +0200 |
| Last post | 2015-10-08 09:30 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] mfd: remove unused variables Arnd Bergmann <arnd@arndb.de> - 2015-10-07 14:50 +0200
Re: [PATCH] mfd: remove unused variables Javier Martinez Canillas <javier@osg.samsung.com> - 2015-10-07 15:10 +0200
Re: [PATCH] mfd: remove unused variables Lee Jones <lee.jones@linaro.org> - 2015-10-08 09:30 +0200
Re: [PATCH] mfd: remove unused variables Lee Jones <lee.jones@linaro.org> - 2015-10-08 09:30 +0200
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2015-10-07 14:50 +0200 |
| Subject | [PATCH] mfd: remove unused variables |
| Message-ID | <qgWkr-54E-19@gated-at.bofh.it> |
A mass-cleanup by Javier Martinez Canillas removed a lot of
unused code, but left at least two variables in mfd drivers
in place that are now causing warnings:
drivers/mfd/rtsx_pcr.c: In function 'rtsx_pci_set_pull_ctl':
drivers/mfd/rtsx_pcr.c:564:6: warning: unused variable 'err' [-Wunused-variable]
drivers/mfd/lm3533-core.c: In function 'lm3533_i2c_probe':
drivers/mfd/lm3533-core.c:595:6: warning: unused variable 'ret' [-Wunused-variable]
This removes them as well.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: c749db571dc ("mfd: lm3533: Simplify function return logic")
Fixes: a3c29b09982 ("mfd: rtsx: Simplify function return logic")
---
diff --git a/drivers/mfd/lm3533-core.c b/drivers/mfd/lm3533-core.c
index 193ecee1fa7e..5abcbb2e8849 100644
--- a/drivers/mfd/lm3533-core.c
+++ b/drivers/mfd/lm3533-core.c
@@ -592,7 +592,6 @@ static int lm3533_i2c_probe(struct i2c_client *i2c,
const struct i2c_device_id *id)
{
struct lm3533 *lm3533;
- int ret;
dev_dbg(&i2c->dev, "%s\n", __func__);
diff --git a/drivers/mfd/rtsx_pcr.c b/drivers/mfd/rtsx_pcr.c
index b98cf1de0a55..d63f3a896adb 100644
--- a/drivers/mfd/rtsx_pcr.c
+++ b/drivers/mfd/rtsx_pcr.c
@@ -561,8 +561,6 @@ EXPORT_SYMBOL_GPL(rtsx_pci_write_ppbuf);
static int rtsx_pci_set_pull_ctl(struct rtsx_pcr *pcr, const u32 *tbl)
{
- int err;
-
rtsx_pci_init_cmd(pcr);
while (*tbl & 0xFFFF0000) {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| Date | 2015-10-07 15:10 +0200 |
| Message-ID | <qgWDL-5In-7@gated-at.bofh.it> |
| In reply to | #1241457 |
Hello Arnd,
On 10/07/2015 02:49 PM, Arnd Bergmann wrote:
> A mass-cleanup by Javier Martinez Canillas removed a lot of
> unused code, but left at least two variables in mfd drivers
> in place that are now causing warnings:
>
> drivers/mfd/rtsx_pcr.c: In function 'rtsx_pci_set_pull_ctl':
> drivers/mfd/rtsx_pcr.c:564:6: warning: unused variable 'err' [-Wunused-variable]
> drivers/mfd/lm3533-core.c: In function 'lm3533_i2c_probe':
> drivers/mfd/lm3533-core.c:595:6: warning: unused variable 'ret' [-Wunused-variable]
>
> This removes them as well.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: c749db571dc ("mfd: lm3533: Simplify function return logic")
> Fixes: a3c29b09982 ("mfd: rtsx: Simplify function return logic")
> ---
I thought that I got rid of all the unused variables but somehow
I missed these. Sorry and thanks a lot for taking care of this.
>
> diff --git a/drivers/mfd/lm3533-core.c b/drivers/mfd/lm3533-core.c
> index 193ecee1fa7e..5abcbb2e8849 100644
> --- a/drivers/mfd/lm3533-core.c
> +++ b/drivers/mfd/lm3533-core.c
> @@ -592,7 +592,6 @@ static int lm3533_i2c_probe(struct i2c_client *i2c,
> const struct i2c_device_id *id)
> {
> struct lm3533 *lm3533;
> - int ret;
>
> dev_dbg(&i2c->dev, "%s\n", __func__);
>
> diff --git a/drivers/mfd/rtsx_pcr.c b/drivers/mfd/rtsx_pcr.c
> index b98cf1de0a55..d63f3a896adb 100644
> --- a/drivers/mfd/rtsx_pcr.c
> +++ b/drivers/mfd/rtsx_pcr.c
> @@ -561,8 +561,6 @@ EXPORT_SYMBOL_GPL(rtsx_pci_write_ppbuf);
>
> static int rtsx_pci_set_pull_ctl(struct rtsx_pcr *pcr, const u32 *tbl)
> {
> - int err;
> -
> rtsx_pci_init_cmd(pcr);
>
> while (*tbl & 0xFFFF0000) {
>
Patch looks good to me.
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2015-10-08 09:30 +0200 |
| Message-ID | <qhdOh-553-5@gated-at.bofh.it> |
| In reply to | #1241457 |
On Thu, 08 Oct 2015, Lee Jones wrote:
> On Wed, 07 Oct 2015, Arnd Bergmann wrote:
>
> > A mass-cleanup by Javier Martinez Canillas removed a lot of
> > unused code, but left at least two variables in mfd drivers
> > in place that are now causing warnings:
> >
> > drivers/mfd/rtsx_pcr.c: In function 'rtsx_pci_set_pull_ctl':
> > drivers/mfd/rtsx_pcr.c:564:6: warning: unused variable 'err' [-Wunused-variable]
> > drivers/mfd/lm3533-core.c: In function 'lm3533_i2c_probe':
> > drivers/mfd/lm3533-core.c:595:6: warning: unused variable 'ret' [-Wunused-variable]
> >
> > This removes them as well.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: c749db571dc ("mfd: lm3533: Simplify function return logic")
> > Fixes: a3c29b09982 ("mfd: rtsx: Simplify function return logic")
>
> Where's your diffstat?
By the way, someone sent a patch to fix these 20 mins before you
did. :)
> > ---
> >
> > diff --git a/drivers/mfd/lm3533-core.c b/drivers/mfd/lm3533-core.c
> > index 193ecee1fa7e..5abcbb2e8849 100644
> > --- a/drivers/mfd/lm3533-core.c
> > +++ b/drivers/mfd/lm3533-core.c
> > @@ -592,7 +592,6 @@ static int lm3533_i2c_probe(struct i2c_client *i2c,
> > const struct i2c_device_id *id)
> > {
> > struct lm3533 *lm3533;
> > - int ret;
> >
> > dev_dbg(&i2c->dev, "%s\n", __func__);
> >
> > diff --git a/drivers/mfd/rtsx_pcr.c b/drivers/mfd/rtsx_pcr.c
> > index b98cf1de0a55..d63f3a896adb 100644
> > --- a/drivers/mfd/rtsx_pcr.c
> > +++ b/drivers/mfd/rtsx_pcr.c
> > @@ -561,8 +561,6 @@ EXPORT_SYMBOL_GPL(rtsx_pci_write_ppbuf);
> >
> > static int rtsx_pci_set_pull_ctl(struct rtsx_pcr *pcr, const u32 *tbl)
> > {
> > - int err;
> > -
> > rtsx_pci_init_cmd(pcr);
> >
> > while (*tbl & 0xFFFF0000) {
> >
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2015-10-08 09:30 +0200 |
| Message-ID | <qhdOh-553-7@gated-at.bofh.it> |
| In reply to | #1241457 |
On Wed, 07 Oct 2015, Arnd Bergmann wrote:
> A mass-cleanup by Javier Martinez Canillas removed a lot of
> unused code, but left at least two variables in mfd drivers
> in place that are now causing warnings:
>
> drivers/mfd/rtsx_pcr.c: In function 'rtsx_pci_set_pull_ctl':
> drivers/mfd/rtsx_pcr.c:564:6: warning: unused variable 'err' [-Wunused-variable]
> drivers/mfd/lm3533-core.c: In function 'lm3533_i2c_probe':
> drivers/mfd/lm3533-core.c:595:6: warning: unused variable 'ret' [-Wunused-variable]
>
> This removes them as well.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: c749db571dc ("mfd: lm3533: Simplify function return logic")
> Fixes: a3c29b09982 ("mfd: rtsx: Simplify function return logic")
Where's your diffstat?
> ---
>
> diff --git a/drivers/mfd/lm3533-core.c b/drivers/mfd/lm3533-core.c
> index 193ecee1fa7e..5abcbb2e8849 100644
> --- a/drivers/mfd/lm3533-core.c
> +++ b/drivers/mfd/lm3533-core.c
> @@ -592,7 +592,6 @@ static int lm3533_i2c_probe(struct i2c_client *i2c,
> const struct i2c_device_id *id)
> {
> struct lm3533 *lm3533;
> - int ret;
>
> dev_dbg(&i2c->dev, "%s\n", __func__);
>
> diff --git a/drivers/mfd/rtsx_pcr.c b/drivers/mfd/rtsx_pcr.c
> index b98cf1de0a55..d63f3a896adb 100644
> --- a/drivers/mfd/rtsx_pcr.c
> +++ b/drivers/mfd/rtsx_pcr.c
> @@ -561,8 +561,6 @@ EXPORT_SYMBOL_GPL(rtsx_pci_write_ppbuf);
>
> static int rtsx_pci_set_pull_ctl(struct rtsx_pcr *pcr, const u32 *tbl)
> {
> - int err;
> -
> rtsx_pci_init_cmd(pcr);
>
> while (*tbl & 0xFFFF0000) {
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web