Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1241457

[PATCH] mfd: remove unused variables

Show all headers | View raw

A mass-cleanup by Javier Martinez Canillas removed a lot of
unused code, but left at least two variables in mfd drivers
in place that are now causing warnings:

drivers/mfd/rtsx_pcr.c: In function 'rtsx_pci_set_pull_ctl':
drivers/mfd/rtsx_pcr.c:564:6: warning: unused variable 'err' [-Wunused-variable]
drivers/mfd/lm3533-core.c: In function 'lm3533_i2c_probe':
drivers/mfd/lm3533-core.c:595:6: warning: unused variable 'ret' [-Wunused-variable]

This removes them as well.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: c749db571dc ("mfd: lm3533: Simplify function return logic")
Fixes: a3c29b09982 ("mfd: rtsx: Simplify function return logic")
---

diff --git a/drivers/mfd/lm3533-core.c b/drivers/mfd/lm3533-core.c
index 193ecee1fa7e..5abcbb2e8849 100644
--- a/drivers/mfd/lm3533-core.c
+++ b/drivers/mfd/lm3533-core.c
@@ -592,7 +592,6 @@ static int lm3533_i2c_probe(struct i2c_client *i2c,
 					const struct i2c_device_id *id)
 {
 	struct lm3533 *lm3533;
-	int ret;
 
 	dev_dbg(&i2c->dev, "%s\n", __func__);
 
diff --git a/drivers/mfd/rtsx_pcr.c b/drivers/mfd/rtsx_pcr.c
index b98cf1de0a55..d63f3a896adb 100644
--- a/drivers/mfd/rtsx_pcr.c
+++ b/drivers/mfd/rtsx_pcr.c
@@ -561,8 +561,6 @@ EXPORT_SYMBOL_GPL(rtsx_pci_write_ppbuf);
 
 static int rtsx_pci_set_pull_ctl(struct rtsx_pcr *pcr, const u32 *tbl)
 {
-	int err;
-
 	rtsx_pci_init_cmd(pcr);
 
 	while (*tbl & 0xFFFF0000) {

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] mfd: remove unused variables Arnd Bergmann <arnd@arndb.de> - 2015-10-07 14:50 +0200
  Re: [PATCH] mfd: remove unused variables Javier Martinez Canillas <javier@osg.samsung.com> - 2015-10-07 15:10 +0200
  Re: [PATCH] mfd: remove unused variables Lee Jones <lee.jones@linaro.org> - 2015-10-08 09:30 +0200
  Re: [PATCH] mfd: remove unused variables Lee Jones <lee.jones@linaro.org> - 2015-10-08 09:30 +0200

csiph-web