Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1239000 > unrolled thread

[PATCH 3/3] Staging: rtl8192u: remove ieee80211_ccmp_null()

Back to article view | Back to linux.kernel

Contents

  [PATCH 3/3] Staging: rtl8192u: remove ieee80211_ccmp_null() mike dupuis <mike.dupuis.0@gmail.com> - 2015-10-03 23:20 +0200
    Re: [PATCH 3/3] Staging: rtl8192u: remove ieee80211_ccmp_null() Greg KH <gregkh@linuxfoundation.org> - 2015-10-04 10:50 +0200
      Re: [PATCH 3/3] Staging: rtl8192u: remove ieee80211_ccmp_null() Greg KH <gregkh@linuxfoundation.org> - 2015-10-04 21:50 +0200

#1239000 — [PATCH 3/3] Staging: rtl8192u: remove ieee80211_ccmp_null()

This is a patch to remove the function ieee80211_ccmp_null().
This function does nothing and can therefore be safely removed.

Signed-off-by: Mike Dupuis <mike.dupuis.0@gmail.com>
---
 drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
index 61edd57..af22ee5 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
@@ -175,9 +175,6 @@ struct net_device *alloc_ieee80211(int sizeof_priv)
 	  ieee->last_packet_time[i] = 0;
 	}
 
-/* These function were added to load crypte module autoly */
-	ieee80211_ccmp_null();
-
 	return dev;
 
  failed:
-- 
2.1.4


---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1239072

On Sat, Oct 03, 2015 at 01:09:56PM -0800, mike dupuis wrote:
> This is a patch to remove the function ieee80211_ccmp_null().
> This function does nothing and can therefore be safely removed.
> 
> Signed-off-by: Mike Dupuis <mike.dupuis.0@gmail.com>
> ---
>  drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
> index 61edd57..af22ee5 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
> @@ -175,9 +175,6 @@ struct net_device *alloc_ieee80211(int sizeof_priv)
>  	  ieee->last_packet_time[i] = 0;
>  	}
>  
> -/* These function were added to load crypte module autoly */
> -	ieee80211_ccmp_null();
> -

You didn't remove the function, only the call to it.

And I think you just broke the "autoload" logic that these "call a null
function" function calls were trying to solve, which isn't good at all.
Have you verified that everything correctly auto-loads when the device
is plugged into the system?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1239199

On Sun, Oct 04, 2015 at 10:46:05AM -0800, Mike Dupuis wrote:
> > And I think you just broke the "autoload" logic that these "call a null
> > function" function calls were trying to solve, which isn't good at all.
> 
> I guess this bit is lost on me-- how does calling a function from a
> previously unused object affect the state of a driver or kernel module?

It forces the module where that function is to be loaded into memory
before this function can be called.

That is if we have multiple modules here, I haven't looked at the code
in a long time to verify it, but note, you are totally ignoring the
comment put there in the code that says this.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web