Re: [PATCH 3/3] Staging: rtl8192u: remove ieee80211_ccmp_null()

From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] Staging: rtl8192u: remove ieee80211_ccmp_null()
Date	2015-10-04 21:50 +0200
Message-ID	<qfXsd-1xd-5@gated-at.bofh.it> (permalink)
References	<qfCnL-5d4-11@gated-at.bofh.it> <qfN9w-3HH-15@gated-at.bofh.it> <qfXsd-1xd-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Oct 04, 2015 at 10:46:05AM -0800, Mike Dupuis wrote:
> > And I think you just broke the "autoload" logic that these "call a null
> > function" function calls were trying to solve, which isn't good at all.
> 
> I guess this bit is lost on me-- how does calling a function from a
> previously unused object affect the state of a driver or kernel module?

It forces the module where that function is to be loaded into memory
before this function can be called.

That is if we have multiple modules here, I haven't looked at the code
in a long time to verify it, but note, you are totally ignoring the
comment put there in the code that says this.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] Staging: rtl8192u: remove ieee80211_ccmp_null() mike dupuis <mike.dupuis.0@gmail.com> - 2015-10-03 23:20 +0200
  Re: [PATCH 3/3] Staging: rtl8192u: remove ieee80211_ccmp_null() Greg KH <gregkh@linuxfoundation.org> - 2015-10-04 10:50 +0200
    Re: [PATCH 3/3] Staging: rtl8192u: remove ieee80211_ccmp_null() Greg KH <gregkh@linuxfoundation.org> - 2015-10-04 21:50 +0200

csiph-web