Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1237905 > unrolled thread
| Started by | Jassi Brar <jassisinghbrar@gmail.com> |
|---|---|
| First post | 2015-10-02 07:20 +0200 |
| Last post | 2015-10-02 11:50 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v3 2/5] mailbox: Add support for ST's Mailbox IP Jassi Brar <jassisinghbrar@gmail.com> - 2015-10-02 07:20 +0200
Re: [PATCH v3 2/5] mailbox: Add support for ST's Mailbox IP Lee Jones <lee.jones@linaro.org> - 2015-10-02 11:40 +0200
Re: [PATCH v3 2/5] mailbox: Add support for ST's Mailbox IP Jassi Brar <jaswinder.singh@linaro.org> - 2015-10-02 11:50 +0200
| From | Jassi Brar <jassisinghbrar@gmail.com> |
|---|---|
| Date | 2015-10-02 07:20 +0200 |
| Subject | Re: [PATCH v3 2/5] mailbox: Add support for ST's Mailbox IP |
| Message-ID | <qf0Vb-26P-1@gated-at.bofh.it> |
On Wed, Aug 19, 2015 at 7:52 PM, Lee Jones <lee.jones@linaro.org> wrote:
....
> +
> +#define MBOX_BASE(mdev, inst) ((mdev)->base + (inst * 4))
>
It should be (inst) * 4
> +/**
> + * STi Mailbox device data
> + *
> + * An IP Mailbox is currently composed of 4 instances
> + * Each instance is currently composed of 32 channels
> + * This means that we have 128 channels per Mailbox
> + * A channel an be used for TX or RX
> + *
> + * @dev: Device to which it is attached
> + * @mbox: Representation of a communication channel controller
> + * @base: Base address of the register mapping region
> + * @name: Name of the mailbox
> + * @enabled: Local copy of enabled channels
> + * @lock: Mutex protecting enabled status
> + */
> +struct sti_mbox_device {
> + struct device *dev;
> + struct mbox_controller *mbox;
> + void __iomem *base;
> + const char *name;
> + u32 enabled[STI_MBOX_INST_MAX];
> + spinlock_t lock;
> + bool txonly;
>
txonly is never used after being initialized from DT :) which is a
good sign. So maybe just drop it and the optional property 'tx-only'.
Cheers!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2015-10-02 11:40 +0200 |
| Message-ID | <qf4YN-7RN-11@gated-at.bofh.it> |
| In reply to | #1237905 |
On Fri, 02 Oct 2015, Jassi Brar wrote:
> On Wed, Aug 19, 2015 at 7:52 PM, Lee Jones <lee.jones@linaro.org> wrote:
>
> ....
>
> > +
> > +#define MBOX_BASE(mdev, inst) ((mdev)->base + (inst * 4))
> >
> It should be (inst) * 4
I'm guessing you mean:
((mdev)->base + ((inst) * 4))
?
> > +/**
> > + * STi Mailbox device data
> > + *
> > + * An IP Mailbox is currently composed of 4 instances
> > + * Each instance is currently composed of 32 channels
> > + * This means that we have 128 channels per Mailbox
> > + * A channel an be used for TX or RX
> > + *
> > + * @dev: Device to which it is attached
> > + * @mbox: Representation of a communication channel controller
> > + * @base: Base address of the register mapping region
> > + * @name: Name of the mailbox
> > + * @enabled: Local copy of enabled channels
> > + * @lock: Mutex protecting enabled status
> > + */
> > +struct sti_mbox_device {
> > + struct device *dev;
> > + struct mbox_controller *mbox;
> > + void __iomem *base;
> > + const char *name;
> > + u32 enabled[STI_MBOX_INST_MAX];
> > + spinlock_t lock;
> > + bool txonly;
> >
> txonly is never used after being initialized from DT :) which is a
> good sign. So maybe just drop it and the optional property 'tx-only'.
Okay.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Jassi Brar <jaswinder.singh@linaro.org> |
|---|---|
| Date | 2015-10-02 11:50 +0200 |
| Message-ID | <qf58u-83i-21@gated-at.bofh.it> |
| In reply to | #1238067 |
On 2 October 2015 at 15:02, Lee Jones <lee.jones@linaro.org> wrote: > On Fri, 02 Oct 2015, Jassi Brar wrote: > >> On Wed, Aug 19, 2015 at 7:52 PM, Lee Jones <lee.jones@linaro.org> wrote: >> >> .... >> >> > + >> > +#define MBOX_BASE(mdev, inst) ((mdev)->base + (inst * 4)) >> > >> It should be (inst) * 4 > > I'm guessing you mean: > > ((mdev)->base + ((inst) * 4)) > > ? yes. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web