Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1237905
| From | Jassi Brar <jassisinghbrar@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 2/5] mailbox: Add support for ST's Mailbox IP |
| Date | 2015-10-02 07:20 +0200 |
| Message-ID | <qf0Vb-26P-1@gated-at.bofh.it> (permalink) |
| References | <pZcxj-8va-3@gated-at.bofh.it> <pZcxk-8va-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, Aug 19, 2015 at 7:52 PM, Lee Jones <lee.jones@linaro.org> wrote:
....
> +
> +#define MBOX_BASE(mdev, inst) ((mdev)->base + (inst * 4))
>
It should be (inst) * 4
> +/**
> + * STi Mailbox device data
> + *
> + * An IP Mailbox is currently composed of 4 instances
> + * Each instance is currently composed of 32 channels
> + * This means that we have 128 channels per Mailbox
> + * A channel an be used for TX or RX
> + *
> + * @dev: Device to which it is attached
> + * @mbox: Representation of a communication channel controller
> + * @base: Base address of the register mapping region
> + * @name: Name of the mailbox
> + * @enabled: Local copy of enabled channels
> + * @lock: Mutex protecting enabled status
> + */
> +struct sti_mbox_device {
> + struct device *dev;
> + struct mbox_controller *mbox;
> + void __iomem *base;
> + const char *name;
> + u32 enabled[STI_MBOX_INST_MAX];
> + spinlock_t lock;
> + bool txonly;
>
txonly is never used after being initialized from DT :) which is a
good sign. So maybe just drop it and the optional property 'tx-only'.
Cheers!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
Re: [PATCH v3 2/5] mailbox: Add support for ST's Mailbox IP Jassi Brar <jassisinghbrar@gmail.com> - 2015-10-02 07:20 +0200
Re: [PATCH v3 2/5] mailbox: Add support for ST's Mailbox IP Lee Jones <lee.jones@linaro.org> - 2015-10-02 11:40 +0200
Re: [PATCH v3 2/5] mailbox: Add support for ST's Mailbox IP Jassi Brar <jaswinder.singh@linaro.org> - 2015-10-02 11:50 +0200
csiph-web