Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1233685 > unrolled thread
| Started by | Geliang Tang <geliangtang@163.com> |
|---|---|
| First post | 2015-09-27 17:20 +0200 |
| Last post | 2015-09-30 19:20 +0200 |
| Articles | 4 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH 1/2] selinux: ioctl_has_perm should be static Geliang Tang <geliangtang@163.com> - 2015-09-27 17:20 +0200
Re: [PATCH 1/2] selinux: ioctl_has_perm should be static Jeffrey Vander Stoep <jeffv@google.com> - 2015-09-28 17:30 +0200
Re: [PATCH 1/2] selinux: ioctl_has_perm should be static Stephen Smalley <sds@tycho.nsa.gov> - 2015-09-29 22:30 +0200
Re: [PATCH 1/2] selinux: ioctl_has_perm should be static Paul Moore <paul@paul-moore.com> - 2015-09-30 19:20 +0200
| From | Geliang Tang <geliangtang@163.com> |
|---|---|
| Date | 2015-09-27 17:20 +0200 |
| Subject | [PATCH 1/2] selinux: ioctl_has_perm should be static |
| Message-ID | <qdlU5-2tx-3@gated-at.bofh.it> |
Fixes the following sparse warning:
security/selinux/hooks.c:3242:5: warning: symbol 'ioctl_has_perm' was
not declared. Should it be static?
Signed-off-by: Geliang Tang <geliangtang@163.com>
---
security/selinux/hooks.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
index 84d21f9..5265c74 100644
--- a/security/selinux/hooks.c
+++ b/security/selinux/hooks.c
@@ -3239,7 +3239,7 @@ static void selinux_file_free_security(struct file *file)
* Check whether a task has the ioctl permission and cmd
* operation to an inode.
*/
-int ioctl_has_perm(const struct cred *cred, struct file *file,
+static int ioctl_has_perm(const struct cred *cred, struct file *file,
u32 requested, u16 cmd)
{
struct common_audit_data ad;
--
2.5.0
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Jeffrey Vander Stoep <jeffv@google.com> |
|---|---|
| Date | 2015-09-28 17:30 +0200 |
| Message-ID | <qdIxk-3mH-9@gated-at.bofh.it> |
| In reply to | #1233685 |
Acked-by: Jeff Vander Stoep <jeffv@google.com>
On Sun, Sep 27, 2015 at 8:10 AM, Geliang Tang <geliangtang@163.com> wrote:
> Fixes the following sparse warning:
>
> security/selinux/hooks.c:3242:5: warning: symbol 'ioctl_has_perm' was
> not declared. Should it be static?
>
> Signed-off-by: Geliang Tang <geliangtang@163.com>
> ---
> security/selinux/hooks.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
> index 84d21f9..5265c74 100644
> --- a/security/selinux/hooks.c
> +++ b/security/selinux/hooks.c
> @@ -3239,7 +3239,7 @@ static void selinux_file_free_security(struct file *file)
> * Check whether a task has the ioctl permission and cmd
> * operation to an inode.
> */
> -int ioctl_has_perm(const struct cred *cred, struct file *file,
> +static int ioctl_has_perm(const struct cred *cred, struct file *file,
> u32 requested, u16 cmd)
> {
> struct common_audit_data ad;
> --
> 2.5.0
>
>
> _______________________________________________
> Selinux mailing list
> Selinux@tycho.nsa.gov
> To unsubscribe, send email to Selinux-leave@tycho.nsa.gov.
> To get help, send an email containing "help" to Selinux-request@tycho.nsa.gov.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Stephen Smalley <sds@tycho.nsa.gov> |
|---|---|
| Date | 2015-09-29 22:30 +0200 |
| Message-ID | <qe9Hc-dy-19@gated-at.bofh.it> |
| In reply to | #1233685 |
On 09/27/2015 11:10 AM, Geliang Tang wrote:
> Fixes the following sparse warning:
>
> security/selinux/hooks.c:3242:5: warning: symbol 'ioctl_has_perm' was
> not declared. Should it be static?
>
> Signed-off-by: Geliang Tang <geliangtang@163.com>
Acked-by: Stephen Smalley <sds@tycho.nsa.gov>
> ---
> security/selinux/hooks.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
> index 84d21f9..5265c74 100644
> --- a/security/selinux/hooks.c
> +++ b/security/selinux/hooks.c
> @@ -3239,7 +3239,7 @@ static void selinux_file_free_security(struct file *file)
> * Check whether a task has the ioctl permission and cmd
> * operation to an inode.
> */
> -int ioctl_has_perm(const struct cred *cred, struct file *file,
> +static int ioctl_has_perm(const struct cred *cred, struct file *file,
> u32 requested, u16 cmd)
> {
> struct common_audit_data ad;
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Paul Moore <paul@paul-moore.com> |
|---|---|
| Date | 2015-09-30 19:20 +0200 |
| Message-ID | <qetcS-327-15@gated-at.bofh.it> |
| In reply to | #1233685 |
On Sunday, September 27, 2015 11:10:24 PM Geliang Tang wrote:
> Fixes the following sparse warning:
>
> security/selinux/hooks.c:3242:5: warning: symbol 'ioctl_has_perm' was
> not declared. Should it be static?
>
> Signed-off-by: Geliang Tang <geliangtang@163.com>
> ---
> security/selinux/hooks.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
> diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
> index 84d21f9..5265c74 100644
> --- a/security/selinux/hooks.c
> +++ b/security/selinux/hooks.c
> @@ -3239,7 +3239,7 @@ static void selinux_file_free_security(struct file
> *file) * Check whether a task has the ioctl permission and cmd
> * operation to an inode.
> */
> -int ioctl_has_perm(const struct cred *cred, struct file *file,
> +static int ioctl_has_perm(const struct cred *cred, struct file *file,
> u32 requested, u16 cmd)
> {
> struct common_audit_data ad;
--
paul moore
www.paul-moore.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web