[PATCH 1/2] selinux: ioctl_has_perm should be static

From	Geliang Tang <geliangtang@163.com>
Newsgroups	linux.kernel
Subject	[PATCH 1/2] selinux: ioctl_has_perm should be static
Date	2015-09-27 17:20 +0200
Message-ID	<qdlU5-2tx-3@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Fixes the following sparse warning:

 security/selinux/hooks.c:3242:5: warning: symbol 'ioctl_has_perm' was
 not declared. Should it be static?

Signed-off-by: Geliang Tang <geliangtang@163.com>
---
 security/selinux/hooks.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
index 84d21f9..5265c74 100644
--- a/security/selinux/hooks.c
+++ b/security/selinux/hooks.c
@@ -3239,7 +3239,7 @@ static void selinux_file_free_security(struct file *file)
  * Check whether a task has the ioctl permission and cmd
  * operation to an inode.
  */
-int ioctl_has_perm(const struct cred *cred, struct file *file,
+static int ioctl_has_perm(const struct cred *cred, struct file *file,
 		u32 requested, u16 cmd)
 {
 	struct common_audit_data ad;
-- 
2.5.0


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] selinux: ioctl_has_perm should be static Geliang Tang <geliangtang@163.com> - 2015-09-27 17:20 +0200
  Re: [PATCH 1/2] selinux: ioctl_has_perm should be static Jeffrey Vander Stoep <jeffv@google.com> - 2015-09-28 17:30 +0200
  Re: [PATCH 1/2] selinux: ioctl_has_perm should be static Stephen Smalley <sds@tycho.nsa.gov> - 2015-09-29 22:30 +0200
  Re: [PATCH 1/2] selinux: ioctl_has_perm should be static Paul Moore <paul@paul-moore.com> - 2015-09-30 19:20 +0200

csiph-web