Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1235013 > unrolled thread
| Started by | Vladimir Murzin <vladimir.murzin@arm.com> |
|---|---|
| First post | 2015-09-29 14:20 +0200 |
| Last post | 2015-09-30 18:20 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 16/22] arm64/debug: Make use of the system wide safe value Vladimir Murzin <vladimir.murzin@arm.com> - 2015-09-29 14:20 +0200
Re: [PATCH 16/22] arm64/debug: Make use of the system wide safe value "Suzuki K. Poulose" <Suzuki.Poulose@arm.com> - 2015-09-29 14:50 +0200
Re: [PATCH 16/22] arm64/debug: Make use of the system wide safe value "Suzuki K. Poulose" <Suzuki.Poulose@arm.com> - 2015-09-30 18:20 +0200
| From | Vladimir Murzin <vladimir.murzin@arm.com> |
|---|---|
| Date | 2015-09-29 14:20 +0200 |
| Subject | Re: [PATCH 16/22] arm64/debug: Make use of the system wide safe value |
| Message-ID | <qe230-6dx-21@gated-at.bofh.it> |
On 16/09/15 15:21, Suzuki K. Poulose wrote: > From: "Suzuki K. Poulose" <suzuki.poulose@arm.com> > > Use the system wide value of ID_AA64DFR0 to make safer decisions > > Signed-off-by: Suzuki K. Poulose <suzuki.poulose@arm.com> > --- > arch/arm64/include/asm/hw_breakpoint.h | 14 ++------------ > arch/arm64/kernel/debug-monitors.c | 6 ++++-- > arch/arm64/kernel/hw_breakpoint.c | 19 ++++++++++++++++++- > 3 files changed, 24 insertions(+), 15 deletions(-) > Looks like this patch introduces build-time regression if CONFIG_PERF_EVENTS is not set: > arch/arm64/kvm/built-in.o: In function `kvm_arm_setup_debug': > /work/tools/linux/arch/arm64/kvm/debug.c:173: undefined reference to `get_num_brps' > /work/tools/linux/arch/arm64/kvm/debug.c:177: undefined reference to `get_num_wrps' > arch/arm64/kvm/built-in.o: In function `kvm_arm_clear_debug': > /work/tools/linux/arch/arm64/kvm/debug.c:208: undefined reference to `get_num_brps' > /work/tools/linux/arch/arm64/kvm/debug.c:212: undefined reference to `get_num_wrps' > arch/arm64/kvm/built-in.o: In function `kvm_arch_dev_ioctl_check_extension': > /work/tools/linux/arch/arm64/kvm/reset.c:78: undefined reference to `get_num_wrps' > /work/tools/linux/arch/arm64/kvm/reset.c:75: undefined reference to `get_num_brps' > make: *** [vmlinux] Error 1 Vladimir -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | "Suzuki K. Poulose" <Suzuki.Poulose@arm.com> |
|---|---|
| Date | 2015-09-29 14:50 +0200 |
| Message-ID | <qe2w1-6Ln-13@gated-at.bofh.it> |
| In reply to | #1235013 |
On 29/09/15 13:17, Vladimir Murzin wrote: > On 16/09/15 15:21, Suzuki K. Poulose wrote: >> From: "Suzuki K. Poulose" <suzuki.poulose@arm.com> >> >> Use the system wide value of ID_AA64DFR0 to make safer decisions >> >> Signed-off-by: Suzuki K. Poulose <suzuki.poulose@arm.com> >> --- >> arch/arm64/include/asm/hw_breakpoint.h | 14 ++------------ >> arch/arm64/kernel/debug-monitors.c | 6 ++++-- >> arch/arm64/kernel/hw_breakpoint.c | 19 ++++++++++++++++++- >> 3 files changed, 24 insertions(+), 15 deletions(-) >> > > Looks like this patch introduces build-time regression if > CONFIG_PERF_EVENTS is not set: > >> arch/arm64/kvm/built-in.o: In function `kvm_arm_setup_debug': >> /work/tools/linux/arch/arm64/kvm/debug.c:173: undefined reference to `get_num_brps' >> /work/tools/linux/arch/arm64/kvm/debug.c:177: undefined reference to `get_num_wrps' >> arch/arm64/kvm/built-in.o: In function `kvm_arm_clear_debug': >> /work/tools/linux/arch/arm64/kvm/debug.c:208: undefined reference to `get_num_brps' >> /work/tools/linux/arch/arm64/kvm/debug.c:212: undefined reference to `get_num_wrps' >> arch/arm64/kvm/built-in.o: In function `kvm_arch_dev_ioctl_check_extension': >> /work/tools/linux/arch/arm64/kvm/reset.c:78: undefined reference to `get_num_wrps' >> /work/tools/linux/arch/arm64/kvm/reset.c:75: undefined reference to `get_num_brps' >> make: *** [vmlinux] Error 1 > > Vladimir > Thanks for pointing this out. I will fix it by moving the get_num_xrps() definition back to hw_breakpoint.h. Suzuki -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | "Suzuki K. Poulose" <Suzuki.Poulose@arm.com> |
|---|---|
| Date | 2015-09-30 18:20 +0200 |
| Message-ID | <qesgP-1GU-43@gated-at.bofh.it> |
| In reply to | #1235013 |
On 29/09/15 13:17, Vladimir Murzin wrote: > On 16/09/15 15:21, Suzuki K. Poulose wrote: >> From: "Suzuki K. Poulose" <suzuki.poulose@arm.com> >> >> Use the system wide value of ID_AA64DFR0 to make safer decisions >> >> Signed-off-by: Suzuki K. Poulose <suzuki.poulose@arm.com> >> --- >> arch/arm64/include/asm/hw_breakpoint.h | 14 ++------------ >> arch/arm64/kernel/debug-monitors.c | 6 ++++-- >> arch/arm64/kernel/hw_breakpoint.c | 19 ++++++++++++++++++- >> 3 files changed, 24 insertions(+), 15 deletions(-) >> > > Looks like this patch introduces build-time regression if > CONFIG_PERF_EVENTS is not set: > >> arch/arm64/kvm/built-in.o: In function `kvm_arm_setup_debug': >> /work/tools/linux/arch/arm64/kvm/debug.c:173: undefined reference to `get_num_brps' >> /work/tools/linux/arch/arm64/kvm/debug.c:177: undefined reference to `get_num_wrps' >> arch/arm64/kvm/built-in.o: In function `kvm_arm_clear_debug': >> /work/tools/linux/arch/arm64/kvm/debug.c:208: undefined reference to `get_num_brps' >> /work/tools/linux/arch/arm64/kvm/debug.c:212: undefined reference to `get_num_wrps' >> arch/arm64/kvm/built-in.o: In function `kvm_arch_dev_ioctl_check_extension': >> /work/tools/linux/arch/arm64/kvm/reset.c:78: undefined reference to `get_num_wrps' >> /work/tools/linux/arch/arm64/kvm/reset.c:75: undefined reference to `get_num_brps' >> make: *** [vmlinux] Error 1 The fixed series is available here : git://linux-arm.org/linux-skp.git cpu-ftr/v1.1-4.3-rc3 I will wait for some more comments/review before I sent the updated version to the list. Thanks Suzuki -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web