Re: [PATCH 16/22] arm64/debug: Make use of the system wide safe value

From	Vladimir Murzin <vladimir.murzin@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 16/22] arm64/debug: Make use of the system wide safe value
Date	2015-09-29 14:20 +0200
Message-ID	<qe230-6dx-21@gated-at.bofh.it> (permalink)
References	<q9lSG-734-3@gated-at.bofh.it> <q9lSH-734-43@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 16/09/15 15:21, Suzuki K. Poulose wrote:
> From: "Suzuki K. Poulose" <suzuki.poulose@arm.com>
> 
> Use the system wide value of ID_AA64DFR0 to make safer decisions
> 
> Signed-off-by: Suzuki K. Poulose <suzuki.poulose@arm.com>
> ---
>  arch/arm64/include/asm/hw_breakpoint.h |   14 ++------------
>  arch/arm64/kernel/debug-monitors.c     |    6 ++++--
>  arch/arm64/kernel/hw_breakpoint.c      |   19 ++++++++++++++++++-
>  3 files changed, 24 insertions(+), 15 deletions(-)
> 

Looks like this patch introduces build-time regression if
CONFIG_PERF_EVENTS is not set:

> arch/arm64/kvm/built-in.o: In function `kvm_arm_setup_debug':
> /work/tools/linux/arch/arm64/kvm/debug.c:173: undefined reference to `get_num_brps'
> /work/tools/linux/arch/arm64/kvm/debug.c:177: undefined reference to `get_num_wrps'
> arch/arm64/kvm/built-in.o: In function `kvm_arm_clear_debug':
> /work/tools/linux/arch/arm64/kvm/debug.c:208: undefined reference to `get_num_brps'
> /work/tools/linux/arch/arm64/kvm/debug.c:212: undefined reference to `get_num_wrps'
> arch/arm64/kvm/built-in.o: In function `kvm_arch_dev_ioctl_check_extension':
> /work/tools/linux/arch/arm64/kvm/reset.c:78: undefined reference to `get_num_wrps'
> /work/tools/linux/arch/arm64/kvm/reset.c:75: undefined reference to `get_num_brps'
> make: *** [vmlinux] Error 1

Vladimir

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 16/22] arm64/debug: Make use of the system wide safe value Vladimir Murzin <vladimir.murzin@arm.com> - 2015-09-29 14:20 +0200
  Re: [PATCH 16/22] arm64/debug: Make use of the system wide safe value "Suzuki K. Poulose" <Suzuki.Poulose@arm.com> - 2015-09-29 14:50 +0200
  Re: [PATCH 16/22] arm64/debug: Make use of the system wide safe value "Suzuki K. Poulose" <Suzuki.Poulose@arm.com> - 2015-09-30 18:20 +0200

csiph-web