Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1232511 > unrolled thread

Re: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq setting before suspend-to-idle

Started by"Rafael J. Wysocki" <rjw@rjwysocki.net>
First post2015-09-25 03:00 +0200
Last post2015-09-28 22:10 +0200
Articles 10 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq setting before suspend-to-idle "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-09-25 03:00 +0200
    RE: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq setting before  suspend-to-idle "Chen, Yu C" <yu.c.chen@intel.com> - 2015-09-25 08:50 +0200
      Re: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq setting before suspend-to-idle "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-09-25 15:30 +0200
        RE: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq setting before  suspend-to-idle "Chen, Yu C" <yu.c.chen@intel.com> - 2015-09-26 16:40 +0200
          Re: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq setting before suspend-to-idle "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-09-27 15:10 +0200
            RE: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq setting before  suspend-to-idle "Chen, Yu C" <yu.c.chen@intel.com> - 2015-09-28 04:00 +0200
              Re: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq setting before suspend-to-idle "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-09-28 14:30 +0200
                RE: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq setting before  suspend-to-idle "Chen, Yu C" <yu.c.chen@intel.com> - 2015-09-28 20:00 +0200
                  Re: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq setting before suspend-to-idle "Rafael J. Wysocki" <rafael@kernel.org> - 2015-09-28 22:10 +0200
                    Re: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq setting before suspend-to-idle "Rafael J. Wysocki" <rafael@kernel.org> - 2015-09-28 22:10 +0200

#1232511 — Re: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq setting before suspend-to-idle

From"Rafael J. Wysocki" <rjw@rjwysocki.net>
Date2015-09-25 03:00 +0200
SubjectRe: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq setting before suspend-to-idle
Message-ID<qcpwK-2Lu-13@gated-at.bofh.it>
On Monday, August 10, 2015 10:11:26 AM Chen Yu wrote:
> For ACPI compatible system, SCI(ACPI System Control
> Interrupt) is used to wake system up from suspend-to-idle.
> Once CPU is woken up by SCI, interrupt handler will
> firstly checks if current interrupt is legal to wake up
> the whole system, thus irq_pm_check_wakeup is invoked
> to validate the irq number. However, before suspend-to-idle,
> acpi_gbl_FADT.sci_interrupt is marked rather than actual
> irq number in acpi_freeze_prepare, this might lead to unable
> to wake up the system.
> 
> This patch fixes this problem by marking the irq number
> return by acpi_gsi_to_irq as IRQD_WAKEUP_STATE, rather than
> marking the acpi_gbl_FADT.sci_interrupt.
> 
> Signed-off-by: Chen Yu <yu.c.chen@intel.com>

That would only really matter if GPE devices were used, but I've never seen
a system using them in practice, so this is more of a theoretical issue.

> ---
>  drivers/acpi/osl.c   |  5 ++++-
>  drivers/acpi/sleep.c | 20 ++++++++++++++++++--
>  drivers/acpi/sleep.h |  5 +++++
>  3 files changed, 27 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
> index 3b8963f..8e1420a 100644
> --- a/drivers/acpi/osl.c
> +++ b/drivers/acpi/osl.c
> @@ -49,6 +49,7 @@
>  #include <asm/uaccess.h>
>  
>  #include "internal.h"
> +#include "sleep.h"
>  
>  #define _COMPONENT		ACPI_OS_SERVICES
>  ACPI_MODULE_NAME("osl");
> @@ -850,7 +851,9 @@ acpi_os_install_interrupt_handler(u32 gsi, acpi_osd_handler handler,
>  		       gsi);
>  		return AE_OK;
>  	}
> -
> +#ifdef CONFIG_SUSPEND
> +	set_wake_irq_freeze(irq);
> +#endif

Please don't use #ifdefs in function bodies.  You can use IS_ENABLED() for that.

>  	acpi_irq_handler = handler;
>  	acpi_irq_context = context;
>  	if (request_irq(irq, acpi_irq, IRQF_SHARED, "acpi", acpi_irq)) {
> diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c
> index 2f0d4db..9e7b54e 100644
> --- a/drivers/acpi/sleep.c
> +++ b/drivers/acpi/sleep.c
> @@ -620,6 +620,22 @@ static const struct platform_suspend_ops acpi_suspend_ops_old = {
>  	.end = acpi_pm_end,
>  	.recover = acpi_pm_finish,
>  };
> +static int wake_irq_freeze = -EINVAL;

There may be more than one of these in theory.

> +
> +int get_wake_irq_freeze(void)
> +{
> +	if (IS_ERR_VALUE(wake_irq_freeze))
> +		return acpi_gbl_FADT.sci_interrupt;
> +	else
> +		return wake_irq_freeze;

That would look better this way IMO:

	return IS_ERR_VALUE(wake_irq_freeze) ?
		acpi_gbl_FADT.sci_interrupt : wake_irq_freeze;

> +}
> +EXPORT_SYMBOL_GPL(get_wake_irq_freeze);
> +
> +void set_wake_irq_freeze(unsigned int irq)
> +{
> +	wake_irq_freeze = (int)irq;
> +}
> +EXPORT_SYMBOL_GPL(set_wake_irq_freeze);
>  
>  static int acpi_freeze_begin(void)
>  {
> @@ -632,14 +648,14 @@ static int acpi_freeze_prepare(void)
>  	acpi_enable_wakeup_devices(ACPI_STATE_S0);
>  	acpi_enable_all_wakeup_gpes();
>  	acpi_os_wait_events_complete();
> -	enable_irq_wake(acpi_gbl_FADT.sci_interrupt);
> +	enable_irq_wake(get_wake_irq_freeze());
>  	return 0;
>  }
>  
>  static void acpi_freeze_restore(void)
>  {
>  	acpi_disable_wakeup_devices(ACPI_STATE_S0);
> -	disable_irq_wake(acpi_gbl_FADT.sci_interrupt);
> +	disable_irq_wake(get_wake_irq_freeze());
>  	acpi_enable_all_runtime_gpes();
>  }
>  
> diff --git a/drivers/acpi/sleep.h b/drivers/acpi/sleep.h
> index c797ffa..eca4fda 100644
> --- a/drivers/acpi/sleep.h
> +++ b/drivers/acpi/sleep.h
> @@ -6,3 +6,8 @@ extern struct list_head acpi_wakeup_device_list;
>  extern struct mutex acpi_device_lock;
>  
>  extern void acpi_resume_power_resources(void);
> +
> +#ifdef CONFIG_SUSPEND
> +extern int get_wake_irq_freeze(void);
> +extern void set_wake_irq_freeze(unsigned int irq);
> +#endif

Is the #ifdef needed here at all?

Thanks,
Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1232606 — RE: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq setting before suspend-to-idle

From"Chen, Yu C" <yu.c.chen@intel.com>
Date2015-09-25 08:50 +0200
SubjectRE: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq setting before suspend-to-idle
Message-ID<qcuZs-23t-23@gated-at.bofh.it>
In reply to#1232511
SGksUmFmYWVsLCB0aGFua3MgYSBsb3QgZm9yIHlvdXIgcmV2aWV3LCB3aWxsIHJlc2VuZCB2MiB2
ZXJzaW9uLg0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IFJhZmFlbCBK
LiBXeXNvY2tpIFttYWlsdG86cmp3QHJqd3lzb2NraS5uZXRdDQo+IFNlbnQ6IEZyaWRheSwgU2Vw
dGVtYmVyIDI1LCAyMDE1IDk6MjQgQU0NCj4gVG86IENoZW4sIFl1IEMNCj4gQ2M6IFd5c29ja2ks
IFJhZmFlbCBKOyBqaWFuZy5saXVAbGludXguaW50ZWwuY29tOyBaaGFuZywgUnVpOyBCcm93biwg
TGVuOyBsaW51eC0NCj4ga2VybmVsQHZnZXIua2VybmVsLm9yZzsgbGludXgtcG1Admdlci5rZXJu
ZWwub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0hdW1JGQ10gQUNQSSAvIFBNOiBGaXggaW5jb3Jy
ZWN0IHdha2V1cCBpcnEgc2V0dGluZyBiZWZvcmUNCj4gc3VzcGVuZC10by1pZGxlDQo+IA0KPiBP
biBNb25kYXksIEF1Z3VzdCAxMCwgMjAxNSAxMDoxMToyNiBBTSBDaGVuIFl1IHdyb3RlOg0KPiA+
IFNpZ25lZC1vZmYtYnk6IENoZW4gWXUgPHl1LmMuY2hlbkBpbnRlbC5jb20+DQo+IA0KPiBUaGF0
IHdvdWxkIG9ubHkgcmVhbGx5IG1hdHRlciBpZiBHUEUgZGV2aWNlcyB3ZXJlIHVzZWQsIGJ1dCBJ
J3ZlIG5ldmVyIHNlZW4gYQ0KPiBzeXN0ZW0gdXNpbmcgdGhlbSBpbiBwcmFjdGljZSwgc28gdGhp
cyBpcyBtb3JlIG9mIGEgdGhlb3JldGljYWwgaXNzdWUuDQo+IA0KSSBoYXZlbid0IGVuY291bnRl
cmVkIHRoaXMgcHJvYmxlbSwgIGp1c3QgZmluZCB0aGlzIHN1c3BpY2lvdXMgDQp3aGVuIEkgd2Fz
IGRvaW5nIHNvbWUgb3RoZXIgZGVidWdnaW5nLg0KPiA+IC0tLQ0KPiA+ICBkcml2ZXJzL2FjcGkv
b3NsLmMgICB8ICA1ICsrKystDQo+ID4gIGRyaXZlcnMvYWNwaS9zbGVlcC5jIHwgMjAgKysrKysr
KysrKysrKysrKysrLS0gIGRyaXZlcnMvYWNwaS9zbGVlcC5oDQo+ID4gfCAgNSArKysrKw0KPiA+
ICAzIGZpbGVzIGNoYW5nZWQsIDI3IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pDQo+ID4N
Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9hY3BpL29zbC5jIGIvZHJpdmVycy9hY3BpL29zbC5j
IGluZGV4DQo+ID4gM2I4OTYzZi4uOGUxNDIwYSAxMDA2NDQNCj4gPiAtLS0gYS9kcml2ZXJzL2Fj
cGkvb3NsLmMNCj4gPiArKysgYi9kcml2ZXJzL2FjcGkvb3NsLmMNCj4gPiBAQCAtODUwLDcgKzg1
MSw5IEBAIGFjcGlfb3NfaW5zdGFsbF9pbnRlcnJ1cHRfaGFuZGxlcih1MzIgZ3NpLA0KPiBhY3Bp
X29zZF9oYW5kbGVyIGhhbmRsZXIsDQo+ID4gIAkJICAgICAgIGdzaSk7DQo+ID4gIAkJcmV0dXJu
IEFFX09LOw0KPiA+ICAJfQ0KPiA+IC0NCj4gPiArI2lmZGVmIENPTkZJR19TVVNQRU5EDQo+ID4g
KwlzZXRfd2FrZV9pcnFfZnJlZXplKGlycSk7DQo+ID4gKyNlbmRpZg0KPiANCj4gUGxlYXNlIGRv
bid0IHVzZSAjaWZkZWZzIGluIGZ1bmN0aW9uIGJvZGllcy4gIFlvdSBjYW4gdXNlIElTX0VOQUJM
RUQoKSBmb3INCj4gdGhhdC4NCj4gDQpPSywgd2lsbCBkby4NCj4gPiAgCWFjcGlfaXJxX2hhbmRs
ZXIgPSBoYW5kbGVyOw0KPiA+ICAJYWNwaV9pcnFfY29udGV4dCA9IGNvbnRleHQ7DQo+ID4gIAlp
ZiAocmVxdWVzdF9pcnEoaXJxLCBhY3BpX2lycSwgSVJRRl9TSEFSRUQsICJhY3BpIiwgYWNwaV9p
cnEpKSB7DQo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvYWNwaS9zbGVlcC5jIGIvZHJpdmVycy9h
Y3BpL3NsZWVwLmMgaW5kZXgNCj4gPiAyZjBkNGRiLi45ZTdiNTRlIDEwMDY0NA0KPiA+IC0tLSBh
L2RyaXZlcnMvYWNwaS9zbGVlcC5jDQo+ID4gKysrIGIvZHJpdmVycy9hY3BpL3NsZWVwLmMNCj4g
PiBAQCAtNjIwLDYgKzYyMCwyMiBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IHBsYXRmb3JtX3N1c3Bl
bmRfb3BzDQo+IGFjcGlfc3VzcGVuZF9vcHNfb2xkID0gew0KPiA+ICAJLmVuZCA9IGFjcGlfcG1f
ZW5kLA0KPiA+ICAJLnJlY292ZXIgPSBhY3BpX3BtX2ZpbmlzaCwNCj4gPiAgfTsNCj4gPiArc3Rh
dGljIGludCB3YWtlX2lycV9mcmVlemUgPSAtRUlOVkFMOw0KPiANCj4gVGhlcmUgbWF5IGJlIG1v
cmUgdGhhbiBvbmUgb2YgdGhlc2UgaW4gdGhlb3J5Lg0KPiANCk9oLCBkbyB5b3UgbWVhbiB0aGUg
bmFtaW5nIGZvciB0aGlzIHZhcmlhYmxlIGlzIHVuLXN1aXRhYmxlPyBPSywgSSdsbCBjaGFuZ2Ug
aXQgdG8NCmFjcGlfZnJlZXplX3dha2VfaXJxIA0KPiA+ICsNCj4gPiAraW50IGdldF93YWtlX2ly
cV9mcmVlemUodm9pZCkNCj4gPiArew0KPiA+ICsJaWYgKElTX0VSUl9WQUxVRSh3YWtlX2lycV9m
cmVlemUpKQ0KPiA+ICsJCXJldHVybiBhY3BpX2dibF9GQURULnNjaV9pbnRlcnJ1cHQ7DQo+ID4g
KwllbHNlDQo+ID4gKwkJcmV0dXJuIHdha2VfaXJxX2ZyZWV6ZTsNCj4gDQo+IFRoYXQgd291bGQg
bG9vayBiZXR0ZXIgdGhpcyB3YXkgSU1POg0KPiANCj4gCXJldHVybiBJU19FUlJfVkFMVUUod2Fr
ZV9pcnFfZnJlZXplKSA/DQo+IAkJYWNwaV9nYmxfRkFEVC5zY2lfaW50ZXJydXB0IDogd2FrZV9p
cnFfZnJlZXplOw0KPiANCk9LLCB3aWxsIGRvLg0KDQo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv
YWNwaS9zbGVlcC5oIGIvZHJpdmVycy9hY3BpL3NsZWVwLmggaW5kZXgNCj4gPiBjNzk3ZmZhLi5l
Y2E0ZmRhIDEwMDY0NA0KPiA+IC0tLSBhL2RyaXZlcnMvYWNwaS9zbGVlcC5oDQo+ID4gKysrIGIv
ZHJpdmVycy9hY3BpL3NsZWVwLmgNCj4gPiBAQCAtNiwzICs2LDggQEAgZXh0ZXJuIHN0cnVjdCBs
aXN0X2hlYWQgYWNwaV93YWtldXBfZGV2aWNlX2xpc3Q7DQo+ID4gZXh0ZXJuIHN0cnVjdCBtdXRl
eCBhY3BpX2RldmljZV9sb2NrOw0KPiA+DQo+ID4gIGV4dGVybiB2b2lkIGFjcGlfcmVzdW1lX3Bv
d2VyX3Jlc291cmNlcyh2b2lkKTsNCj4gPiArDQo+ID4gKyNpZmRlZiBDT05GSUdfU1VTUEVORA0K
PiA+ICtleHRlcm4gaW50IGdldF93YWtlX2lycV9mcmVlemUodm9pZCk7IGV4dGVybiB2b2lkDQo+
ID4gK3NldF93YWtlX2lycV9mcmVlemUodW5zaWduZWQgaW50IGlycSk7ICNlbmRpZg0KPiANCj4g
SXMgdGhlICNpZmRlZiBuZWVkZWQgaGVyZSBhdCBhbGw/DQo+IA0KV2lsbCBkZWxldGUgdGhlICNp
ZmRlZg0KDQoNCkJlc3QgUmVnYXJkcywNCll1DQo=
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1232804

From"Rafael J. Wysocki" <rjw@rjwysocki.net>
Date2015-09-25 15:30 +0200
Message-ID<qcBex-2Eq-5@gated-at.bofh.it>
In reply to#1232606
On Friday, September 25, 2015 06:42:41 AM Chen, Yu C wrote:
> Hi,Rafael, thanks a lot for your review, will resend v2 version.
> 
> > -----Original Message-----
> > From: Rafael J. Wysocki [mailto:rjw@rjwysocki.net]
> > Sent: Friday, September 25, 2015 9:24 AM
> > To: Chen, Yu C
> > Cc: Wysocki, Rafael J; jiang.liu@linux.intel.com; Zhang, Rui; Brown, Len; linux-
> > kernel@vger.kernel.org; linux-pm@vger.kernel.org
> > Subject: Re: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq setting before
> > suspend-to-idle
> > 
> > On Monday, August 10, 2015 10:11:26 AM Chen Yu wrote:
> > > Signed-off-by: Chen Yu <yu.c.chen@intel.com>
> > 
> > That would only really matter if GPE devices were used, but I've never seen a
> > system using them in practice, so this is more of a theoretical issue.
> > 
> I haven't encountered this problem,  just find this suspicious 
> when I was doing some other debugging.

In fact what I said was incorrect.  You might encounter this problem if the
ACPI interrupt has been remapped and not when GPE devices are used.

> > > ---
> > >  drivers/acpi/osl.c   |  5 ++++-
> > >  drivers/acpi/sleep.c | 20 ++++++++++++++++++--  drivers/acpi/sleep.h
> > > |  5 +++++
> > >  3 files changed, 27 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c index
> > > 3b8963f..8e1420a 100644
> > > --- a/drivers/acpi/osl.c
> > > +++ b/drivers/acpi/osl.c
> > > @@ -850,7 +851,9 @@ acpi_os_install_interrupt_handler(u32 gsi,
> > acpi_osd_handler handler,
> > >  		       gsi);
> > >  		return AE_OK;
> > >  	}
> > > -
> > > +#ifdef CONFIG_SUSPEND
> > > +	set_wake_irq_freeze(irq);
> > > +#endif
> > 
> > Please don't use #ifdefs in function bodies.  You can use IS_ENABLED() for
> > that.
> > 
> OK, will do.

Alternatively, you can define an empty static inline stub of set_wake_irq_freeze()
for CONFIG_SUSPEND and avoid using IS_ENABLED() even.

But I'd rather define a global acpi_irq variable, store irq in it and access it
directly from acpi_freeze_prepare().  And it doesn't have to depend on CONFIG_SUSPEND
as it is just the IRQ number actually used by ACPI.

BTW, I wonder if there are other places using acpi_gbl_FADT.sci_interrupt directly
which they shouldn't do?

> > >  	acpi_irq_handler = handler;
> > >  	acpi_irq_context = context;
> > >  	if (request_irq(irq, acpi_irq, IRQF_SHARED, "acpi", acpi_irq)) {
> > > diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c index
> > > 2f0d4db..9e7b54e 100644
> > > --- a/drivers/acpi/sleep.c
> > > +++ b/drivers/acpi/sleep.c
> > > @@ -620,6 +620,22 @@ static const struct platform_suspend_ops
> > acpi_suspend_ops_old = {
> > >  	.end = acpi_pm_end,
> > >  	.recover = acpi_pm_finish,
> > >  };
> > > +static int wake_irq_freeze = -EINVAL;
> > 
> > There may be more than one of these in theory.
> > 
> Oh, do you mean the naming for this variable is un-suitable? OK, I'll change it to
> acpi_freeze_wake_irq 

No.  What I mean is that in theory there may be multiple ACPI interrupts.

But you need not care about this case because of the

	if (gsi != acpi_gbl_FADT.sci_interrupt)
		return AE_BAD_PARAMETER;

check in acpi_os_install_interrupt_handler().

Thanks,
Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1233208 — RE: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq setting before suspend-to-idle

From"Chen, Yu C" <yu.c.chen@intel.com>
Date2015-09-26 16:40 +0200
SubjectRE: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq setting before suspend-to-idle
Message-ID<qcYNP-2IN-13@gated-at.bofh.it>
In reply to#1232804
SGksIFJhZmFlbCwNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBsaW51
eC1wbS1vd25lckB2Z2VyLmtlcm5lbC5vcmcgW21haWx0bzpsaW51eC1wbS0NCj4gb3duZXJAdmdl
ci5rZXJuZWwub3JnXSBPbiBCZWhhbGYgT2YgUmFmYWVsIEouIFd5c29ja2kNCj4gU2VudDogRnJp
ZGF5LCBTZXB0ZW1iZXIgMjUsIDIwMTUgOTo1NyBQTQ0KPiBUbzogQ2hlbiwgWXUgQw0KPiBDYzog
V3lzb2NraSwgUmFmYWVsIEo7IGppYW5nLmxpdUBsaW51eC5pbnRlbC5jb207IFpoYW5nLCBSdWk7
IEJyb3duLCBMZW47IGxpbnV4LQ0KPiBrZXJuZWxAdmdlci5rZXJuZWwub3JnOyBsaW51eC1wbUB2
Z2VyLmtlcm5lbC5vcmcNCj4gU3ViamVjdDogUmU6IFtQQVRDSF1bUkZDXSBBQ1BJIC8gUE06IEZp
eCBpbmNvcnJlY3Qgd2FrZXVwIGlycSBzZXR0aW5nIGJlZm9yZQ0KPiBzdXNwZW5kLXRvLWlkbGUN
Cj4gDQo+IE9uIEZyaWRheSwgU2VwdGVtYmVyIDI1LCAyMDE1IDA2OjQyOjQxIEFNIENoZW4sIFl1
IEMgd3JvdGU6DQo+ID4gSGksUmFmYWVsLCB0aGFua3MgYSBsb3QgZm9yIHlvdXIgcmV2aWV3LCB3
aWxsIHJlc2VuZCB2MiB2ZXJzaW9uLg0KPiA+DQo+ID4gPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2Ut
LS0tLQ0KPiA+ID4gRnJvbTogUmFmYWVsIEouIFd5c29ja2kgW21haWx0bzpyandAcmp3eXNvY2tp
Lm5ldF0NCj4gPiA+IFNlbnQ6IEZyaWRheSwgU2VwdGVtYmVyIDI1LCAyMDE1IDk6MjQgQU0NCj4g
PiA+IFRvOiBDaGVuLCBZdSBDDQo+ID4gPiBDYzogV3lzb2NraSwgUmFmYWVsIEo7IGppYW5nLmxp
dUBsaW51eC5pbnRlbC5jb207IFpoYW5nLCBSdWk7IEJyb3duLA0KPiA+ID4gTGVuOyBsaW51eC0g
a2VybmVsQHZnZXIua2VybmVsLm9yZzsgbGludXgtcG1Admdlci5rZXJuZWwub3JnDQo+ID4gPiBT
dWJqZWN0OiBSZTogW1BBVENIXVtSRkNdIEFDUEkgLyBQTTogRml4IGluY29ycmVjdCB3YWtldXAg
aXJxDQo+ID4gPiBzZXR0aW5nIGJlZm9yZSBzdXNwZW5kLXRvLWlkbGUNCj4gPiA+DQo+ID4gPiBP
biBNb25kYXksIEF1Z3VzdCAxMCwgMjAxNSAxMDoxMToyNiBBTSBDaGVuIFl1IHdyb3RlOg0KPiA+
ID4gPiArI2lmZGVmIENPTkZJR19TVVNQRU5EDQo+ID4gPiA+ICsJc2V0X3dha2VfaXJxX2ZyZWV6
ZShpcnEpOw0KPiA+ID4gPiArI2VuZGlmDQo+IA0KPiBBbHRlcm5hdGl2ZWx5LCB5b3UgY2FuIGRl
ZmluZSBhbiBlbXB0eSBzdGF0aWMgaW5saW5lIHN0dWIgb2YNCj4gc2V0X3dha2VfaXJxX2ZyZWV6
ZSgpIGZvciBDT05GSUdfU1VTUEVORCBhbmQgYXZvaWQgdXNpbmcgSVNfRU5BQkxFRCgpDQo+IGV2
ZW4uDQo+IA0KPiBCdXQgSSdkIHJhdGhlciBkZWZpbmUgYSBnbG9iYWwgYWNwaV9pcnEgdmFyaWFi
bGUsIHN0b3JlIGlycSBpbiBpdCBhbmQgYWNjZXNzIGl0DQo+IGRpcmVjdGx5IGZyb20gYWNwaV9m
cmVlemVfcHJlcGFyZSgpLiAgQW5kIGl0IGRvZXNuJ3QgaGF2ZSB0byBkZXBlbmQgb24NCj4gQ09O
RklHX1NVU1BFTkQgYXMgaXQgaXMganVzdCB0aGUgSVJRIG51bWJlciBhY3R1YWxseSB1c2VkIGJ5
IEFDUEkuDQo+IA0KT0ssIEkndmUgY29udmVydCBpdCB0byBhIGdsb2JhbCB2YXJpYWJsZSBhY3Bp
X2ludXNlX2lycS4NCg0KPiBCVFcsIEkgd29uZGVyIGlmIHRoZXJlIGFyZSBvdGhlciBwbGFjZXMg
dXNpbmcgYWNwaV9nYmxfRkFEVC5zY2lfaW50ZXJydXB0DQo+IGRpcmVjdGx5IHdoaWNoIHRoZXkg
c2hvdWxkbid0IGRvPw0KPiANCkkgc2VhcmNoZWQgdGhlIGNvZGUgYW5kIGZvdW5kIHRoZXJlIGFy
ZSB0d28gb3RoZXIgcG90ZW50aWFsIG1pc3VzZSBvZiANCmFjcGlfZ2JsX0ZBRFQuc2NpX2ludGVy
cnVwdCwgdGhleSBhcmUgaW4gYWNwaV9vc19yZW1vdmVfaW50ZXJydXB0X2hhbmRsZXINCmFuZCBh
Y3BpX29zX3dhaXRfZXZlbnRzX2NvbXBsZXRlLCBzbyBJIHNlbnQgb3V0IGEgdmVyc2lvbiAyIHBh
dGNoDQpmb3IgdGhlbS4NCg0KPiA+IE9oLCBkbyB5b3UgbWVhbiB0aGUgbmFtaW5nIGZvciB0aGlz
IHZhcmlhYmxlIGlzIHVuLXN1aXRhYmxlPyBPSywgSSdsbA0KPiA+IGNoYW5nZSBpdCB0byBhY3Bp
X2ZyZWV6ZV93YWtlX2lycQ0KPiANCj4gTm8uICBXaGF0IEkgbWVhbiBpcyB0aGF0IGluIHRoZW9y
eSB0aGVyZSBtYXkgYmUgbXVsdGlwbGUgQUNQSSBpbnRlcnJ1cHRzLg0KPiANCj4gQnV0IHlvdSBu
ZWVkIG5vdCBjYXJlIGFib3V0IHRoaXMgY2FzZSBiZWNhdXNlIG9mIHRoZQ0KPiANCj4gCWlmIChn
c2kgIT0gYWNwaV9nYmxfRkFEVC5zY2lfaW50ZXJydXB0KQ0KPiAJCXJldHVybiBBRV9CQURfUEFS
QU1FVEVSOw0KPiBjaGVjayBpbiBhY3BpX29zX2luc3RhbGxfaW50ZXJydXB0X2hhbmRsZXIoKS4N
Cj4gDQpPSywgdGhhbmtzIQ0KDQpCZXN0IFJlZ2FyZHMsDQpZdQ0K
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1233657

From"Rafael J. Wysocki" <rjw@rjwysocki.net>
Date2015-09-27 15:10 +0200
Message-ID<qdjSi-82P-15@gated-at.bofh.it>
In reply to#1233208
On Saturday, September 26, 2015 02:37:19 PM Chen, Yu C wrote:
> Hi, Rafael,
> 
> > -----Original Message-----
> > From: linux-pm-owner@vger.kernel.org [mailto:linux-pm-
> > owner@vger.kernel.org] On Behalf Of Rafael J. Wysocki
> > Sent: Friday, September 25, 2015 9:57 PM
> > To: Chen, Yu C
> > Cc: Wysocki, Rafael J; jiang.liu@linux.intel.com; Zhang, Rui; Brown, Len; linux-
> > kernel@vger.kernel.org; linux-pm@vger.kernel.org
> > Subject: Re: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq setting before
> > suspend-to-idle
> > 
> > On Friday, September 25, 2015 06:42:41 AM Chen, Yu C wrote:
> > > Hi,Rafael, thanks a lot for your review, will resend v2 version.
> > >
> > > > -----Original Message-----
> > > > From: Rafael J. Wysocki [mailto:rjw@rjwysocki.net]
> > > > Sent: Friday, September 25, 2015 9:24 AM
> > > > To: Chen, Yu C
> > > > Cc: Wysocki, Rafael J; jiang.liu@linux.intel.com; Zhang, Rui; Brown,
> > > > Len; linux- kernel@vger.kernel.org; linux-pm@vger.kernel.org
> > > > Subject: Re: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq
> > > > setting before suspend-to-idle
> > > >
> > > > On Monday, August 10, 2015 10:11:26 AM Chen Yu wrote:
> > > > > +#ifdef CONFIG_SUSPEND
> > > > > +	set_wake_irq_freeze(irq);
> > > > > +#endif
> > 
> > Alternatively, you can define an empty static inline stub of
> > set_wake_irq_freeze() for CONFIG_SUSPEND and avoid using IS_ENABLED()
> > even.
> > 
> > But I'd rather define a global acpi_irq variable, store irq in it and access it
> > directly from acpi_freeze_prepare().  And it doesn't have to depend on
> > CONFIG_SUSPEND as it is just the IRQ number actually used by ACPI.
> > 
> OK, I've convert it to a global variable acpi_inuse_irq.

Why do you need the "inuse" part?  Why is acpi_irq not sufficient?

> > BTW, I wonder if there are other places using acpi_gbl_FADT.sci_interrupt
> > directly which they shouldn't do?
> > 
> I searched the code and found there are two other potential misuse of 
> acpi_gbl_FADT.sci_interrupt, they are in acpi_os_remove_interrupt_handler
> and acpi_os_wait_events_complete, so I sent out a version 2 patch
> for them.

OK, thanks!

Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1233812 — RE: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq setting before suspend-to-idle

From"Chen, Yu C" <yu.c.chen@intel.com>
Date2015-09-28 04:00 +0200
SubjectRE: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq setting before suspend-to-idle
Message-ID<qdvTr-8b5-1@gated-at.bofh.it>
In reply to#1233657
SGksIFJhZmFlbCwNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBsaW51
eC1wbS1vd25lckB2Z2VyLmtlcm5lbC5vcmcgW21haWx0bzpsaW51eC1wbS0NCj4gb3duZXJAdmdl
ci5rZXJuZWwub3JnXSBPbiBCZWhhbGYgT2YgUmFmYWVsIEouIFd5c29ja2kNCj4gU2VudDogU3Vu
ZGF5LCBTZXB0ZW1iZXIgMjcsIDIwMTUgOTozMCBQTQ0KPiBUbzogQ2hlbiwgWXUgQw0KPiBDYzog
V3lzb2NraSwgUmFmYWVsIEo7IGppYW5nLmxpdUBsaW51eC5pbnRlbC5jb207IFpoYW5nLCBSdWk7
IEJyb3duLCBMZW47IGxpbnV4LQ0KPiBrZXJuZWxAdmdlci5rZXJuZWwub3JnOyBsaW51eC1wbUB2
Z2VyLmtlcm5lbC5vcmcNCj4gU3ViamVjdDogUmU6IFtQQVRDSF1bUkZDXSBBQ1BJIC8gUE06IEZp
eCBpbmNvcnJlY3Qgd2FrZXVwIGlycSBzZXR0aW5nIGJlZm9yZQ0KPiBzdXNwZW5kLXRvLWlkbGUN
Cj4gDQo+IE9uIFNhdHVyZGF5LCBTZXB0ZW1iZXIgMjYsIDIwMTUgMDI6Mzc6MTkgUE0gQ2hlbiwg
WXUgQyB3cm90ZToNCj4gPiBIaSwgUmFmYWVsLA0KPiA+DQo+ID4gPiAtLS0tLU9yaWdpbmFsIE1l
c3NhZ2UtLS0tLQ0KPiA+ID4gRnJvbTogbGludXgtcG0tb3duZXJAdmdlci5rZXJuZWwub3JnIFtt
YWlsdG86bGludXgtcG0tDQo+ID4gPiBvd25lckB2Z2VyLmtlcm5lbC5vcmddIE9uIEJlaGFsZiBP
ZiBSYWZhZWwgSi4gV3lzb2NraQ0KPiA+ID4gU2VudDogRnJpZGF5LCBTZXB0ZW1iZXIgMjUsIDIw
MTUgOTo1NyBQTQ0KPiA+ID4gVG86IENoZW4sIFl1IEMNCj4gPiA+IENjOiBXeXNvY2tpLCBSYWZh
ZWwgSjsgamlhbmcubGl1QGxpbnV4LmludGVsLmNvbTsgWmhhbmcsIFJ1aTsgQnJvd24sDQo+ID4g
PiBMZW47IGxpbnV4LSBrZXJuZWxAdmdlci5rZXJuZWwub3JnOyBsaW51eC1wbUB2Z2VyLmtlcm5l
bC5vcmcNCj4gPiA+IFN1YmplY3Q6IFJlOiBbUEFUQ0hdW1JGQ10gQUNQSSAvIFBNOiBGaXggaW5j
b3JyZWN0IHdha2V1cCBpcnENCj4gPiA+IHNldHRpbmcgYmVmb3JlIHN1c3BlbmQtdG8taWRsZQ0K
PiA+ID4NCj4gPiA+IE9uIEZyaWRheSwgU2VwdGVtYmVyIDI1LCAyMDE1IDA2OjQyOjQxIEFNIENo
ZW4sIFl1IEMgd3JvdGU6DQo+ID4gPiA+IEhpLFJhZmFlbCwgdGhhbmtzIGEgbG90IGZvciB5b3Vy
IHJldmlldywgd2lsbCByZXNlbmQgdjIgdmVyc2lvbi4NCj4gPiA+ID4NCj4gPiA+ID4gPiAtLS0t
LU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+ID4gPiA+IEZyb206IFJhZmFlbCBKLiBXeXNvY2tp
IFttYWlsdG86cmp3QHJqd3lzb2NraS5uZXRdDQo+ID4gPiA+ID4gU2VudDogRnJpZGF5LCBTZXB0
ZW1iZXIgMjUsIDIwMTUgOToyNCBBTQ0KPiA+ID4gPiA+IFRvOiBDaGVuLCBZdSBDDQo+ID4gPiA+
ID4gQ2M6IFd5c29ja2ksIFJhZmFlbCBKOyBqaWFuZy5saXVAbGludXguaW50ZWwuY29tOyBaaGFu
ZywgUnVpOw0KPiA+ID4gPiA+IEJyb3duLCBMZW47IGxpbnV4LSBrZXJuZWxAdmdlci5rZXJuZWwu
b3JnOw0KPiA+ID4gPiA+IGxpbnV4LXBtQHZnZXIua2VybmVsLm9yZw0KPiA+ID4gPiA+IFN1Ympl
Y3Q6IFJlOiBbUEFUQ0hdW1JGQ10gQUNQSSAvIFBNOiBGaXggaW5jb3JyZWN0IHdha2V1cCBpcnEN
Cj4gPiA+ID4gPiBzZXR0aW5nIGJlZm9yZSBzdXNwZW5kLXRvLWlkbGUNCj4gPiA+ID4gPg0KPiA+
ID4gPiA+IE9uIE1vbmRheSwgQXVndXN0IDEwLCAyMDE1IDEwOjExOjI2IEFNIENoZW4gWXUgd3Jv
dGU6DQo+ID4gPg0KPiA+ID4gQnV0IEknZCByYXRoZXIgZGVmaW5lIGEgZ2xvYmFsIGFjcGlfaXJx
IHZhcmlhYmxlLCBzdG9yZSBpcnEgaW4gaXQNCj4gPiA+IGFuZCBhY2Nlc3MgaXQgZGlyZWN0bHkg
ZnJvbSBhY3BpX2ZyZWV6ZV9wcmVwYXJlKCkuICBBbmQgaXQgZG9lc24ndA0KPiA+ID4gaGF2ZSB0
byBkZXBlbmQgb24gQ09ORklHX1NVU1BFTkQgYXMgaXQgaXMganVzdCB0aGUgSVJRIG51bWJlcg0K
PiBhY3R1YWxseSB1c2VkIGJ5IEFDUEkuDQo+ID4gPg0KPiA+IE9LLCBJJ3ZlIGNvbnZlcnQgaXQg
dG8gYSBnbG9iYWwgdmFyaWFibGUgYWNwaV9pbnVzZV9pcnEuDQo+IA0KPiBXaHkgZG8geW91IG5l
ZWQgdGhlICJpbnVzZSIgcGFydD8gIFdoeSBpcyBhY3BpX2lycSBub3Qgc3VmZmljaWVudD8NCkJl
Y2F1c2UgdGhlIG5hbWUgb2YgYWNwaV9pcnEgaXMgYWxyZWFkeSB1c2VkIGJ5IGFjcGkgaXJxIGhh
bmRsZXIgYXQNCmRyaXZlcnMvYWNwaS9vc2wuYzoNCnJlcXVlc3RfaXJxKGlycSwgYWNwaV9pcnEs
IElSUUZfU0hBUkVELCAiYWNwaSIsIGFjcGlfaXJxKQ0KDQpUaGFua3MNCll1DQoNCg==
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1234082

From"Rafael J. Wysocki" <rjw@rjwysocki.net>
Date2015-09-28 14:30 +0200
Message-ID<qdFJ9-5CT-23@gated-at.bofh.it>
In reply to#1233812
On Monday, September 28, 2015 01:51:09 AM Chen, Yu C wrote:
> Hi, Rafael,
> 
> > -----Original Message-----
> > From: linux-pm-owner@vger.kernel.org [mailto:linux-pm-
> > owner@vger.kernel.org] On Behalf Of Rafael J. Wysocki
> > Sent: Sunday, September 27, 2015 9:30 PM
> > To: Chen, Yu C
> > Cc: Wysocki, Rafael J; jiang.liu@linux.intel.com; Zhang, Rui; Brown, Len; linux-
> > kernel@vger.kernel.org; linux-pm@vger.kernel.org
> > Subject: Re: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq setting before
> > suspend-to-idle
> > 
> > On Saturday, September 26, 2015 02:37:19 PM Chen, Yu C wrote:
> > > Hi, Rafael,
> > >
> > > > -----Original Message-----
> > > > From: linux-pm-owner@vger.kernel.org [mailto:linux-pm-
> > > > owner@vger.kernel.org] On Behalf Of Rafael J. Wysocki
> > > > Sent: Friday, September 25, 2015 9:57 PM
> > > > To: Chen, Yu C
> > > > Cc: Wysocki, Rafael J; jiang.liu@linux.intel.com; Zhang, Rui; Brown,
> > > > Len; linux- kernel@vger.kernel.org; linux-pm@vger.kernel.org
> > > > Subject: Re: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq
> > > > setting before suspend-to-idle
> > > >
> > > > On Friday, September 25, 2015 06:42:41 AM Chen, Yu C wrote:
> > > > > Hi,Rafael, thanks a lot for your review, will resend v2 version.
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: Rafael J. Wysocki [mailto:rjw@rjwysocki.net]
> > > > > > Sent: Friday, September 25, 2015 9:24 AM
> > > > > > To: Chen, Yu C
> > > > > > Cc: Wysocki, Rafael J; jiang.liu@linux.intel.com; Zhang, Rui;
> > > > > > Brown, Len; linux- kernel@vger.kernel.org;
> > > > > > linux-pm@vger.kernel.org
> > > > > > Subject: Re: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq
> > > > > > setting before suspend-to-idle
> > > > > >
> > > > > > On Monday, August 10, 2015 10:11:26 AM Chen Yu wrote:
> > > >
> > > > But I'd rather define a global acpi_irq variable, store irq in it
> > > > and access it directly from acpi_freeze_prepare().  And it doesn't
> > > > have to depend on CONFIG_SUSPEND as it is just the IRQ number
> > actually used by ACPI.
> > > >
> > > OK, I've convert it to a global variable acpi_inuse_irq.
> > 
> > Why do you need the "inuse" part?  Why is acpi_irq not sufficient?
> Because the name of acpi_irq is already used by acpi irq handler at
> drivers/acpi/osl.c:
> request_irq(irq, acpi_irq, IRQF_SHARED, "acpi", acpi_irq)

Ah, this is the name of the handler.  I forgot about that, sorry.

Well, it might be worth renaming the handler to something like acpi_interrupt(), then.

Thanks,
Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1234329 — RE: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq setting before suspend-to-idle

From"Chen, Yu C" <yu.c.chen@intel.com>
Date2015-09-28 20:00 +0200
SubjectRE: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq setting before suspend-to-idle
Message-ID<qdKSu-6Ap-1@gated-at.bofh.it>
In reply to#1234082
SGksDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogUmFmYWVsIEouIFd5
c29ja2kgW21haWx0bzpyandAcmp3eXNvY2tpLm5ldF0NCj4gU2VudDogTW9uZGF5LCBTZXB0ZW1i
ZXIgMjgsIDIwMTUgODo1NiBQTQ0KPiBUbzogQ2hlbiwgWXUgQw0KPiBDYzogV3lzb2NraSwgUmFm
YWVsIEo7IGppYW5nLmxpdUBsaW51eC5pbnRlbC5jb207IFpoYW5nLCBSdWk7IEJyb3duLCBMZW47
IGxpbnV4LQ0KPiBrZXJuZWxAdmdlci5rZXJuZWwub3JnOyBsaW51eC1wbUB2Z2VyLmtlcm5lbC5v
cmcNCj4gU3ViamVjdDogUmU6IFtQQVRDSF1bUkZDXSBBQ1BJIC8gUE06IEZpeCBpbmNvcnJlY3Qg
d2FrZXVwIGlycSBzZXR0aW5nIGJlZm9yZQ0KPiBzdXNwZW5kLXRvLWlkbGUNCj4gDQo+IE9uIE1v
bmRheSwgU2VwdGVtYmVyIDI4LCAyMDE1IDAxOjUxOjA5IEFNIENoZW4sIFl1IEMgd3JvdGU6DQo+
ID4gSGksIFJhZmFlbCwNCj4gPg0KPiA+ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4g
PiA+IEZyb206IGxpbnV4LXBtLW93bmVyQHZnZXIua2VybmVsLm9yZyBbbWFpbHRvOmxpbnV4LXBt
LQ0KPiA+ID4gb3duZXJAdmdlci5rZXJuZWwub3JnXSBPbiBCZWhhbGYgT2YgUmFmYWVsIEouIFd5
c29ja2kNCj4gPiA+IFNlbnQ6IFN1bmRheSwgU2VwdGVtYmVyIDI3LCAyMDE1IDk6MzAgUE0NCj4g
PiA+IFRvOiBDaGVuLCBZdSBDDQo+ID4gPiBDYzogV3lzb2NraSwgUmFmYWVsIEo7IGppYW5nLmxp
dUBsaW51eC5pbnRlbC5jb207IFpoYW5nLCBSdWk7IEJyb3duLA0KPiA+ID4gTGVuOyBsaW51eC0g
a2VybmVsQHZnZXIua2VybmVsLm9yZzsgbGludXgtcG1Admdlci5rZXJuZWwub3JnDQo+ID4gPiBT
dWJqZWN0OiBSZTogW1BBVENIXVtSRkNdIEFDUEkgLyBQTTogRml4IGluY29ycmVjdCB3YWtldXAg
aXJxDQo+ID4gPiBzZXR0aW5nIGJlZm9yZSBzdXNwZW5kLXRvLWlkbGUNCj4gPiA+DQo+ID4gPiBP
biBTYXR1cmRheSwgU2VwdGVtYmVyIDI2LCAyMDE1IDAyOjM3OjE5IFBNIENoZW4sIFl1IEMgd3Jv
dGU6DQo+ID4gPiA+IEhpLCBSYWZhZWwsDQo+ID4gPiA+DQo+ID4gPiA+ID4gLS0tLS1PcmlnaW5h
bCBNZXNzYWdlLS0tLS0NCj4gPiA+ID4gPiBGcm9tOiBsaW51eC1wbS1vd25lckB2Z2VyLmtlcm5l
bC5vcmcgW21haWx0bzpsaW51eC1wbS0NCj4gPiA+ID4gPiBvd25lckB2Z2VyLmtlcm5lbC5vcmdd
IE9uIEJlaGFsZiBPZiBSYWZhZWwgSi4gV3lzb2NraQ0KPiA+ID4gPiA+IFNlbnQ6IEZyaWRheSwg
U2VwdGVtYmVyIDI1LCAyMDE1IDk6NTcgUE0NCj4gPiA+ID4gPiBUbzogQ2hlbiwgWXUgQw0KPiA+
ID4gPiA+IENjOiBXeXNvY2tpLCBSYWZhZWwgSjsgamlhbmcubGl1QGxpbnV4LmludGVsLmNvbTsg
WmhhbmcsIFJ1aTsNCj4gPiA+ID4gPiBCcm93biwgTGVuOyBsaW51eC0ga2VybmVsQHZnZXIua2Vy
bmVsLm9yZzsNCj4gPiA+ID4gPiBsaW51eC1wbUB2Z2VyLmtlcm5lbC5vcmcNCj4gPiA+ID4gPiBT
dWJqZWN0OiBSZTogW1BBVENIXVtSRkNdIEFDUEkgLyBQTTogRml4IGluY29ycmVjdCB3YWtldXAg
aXJxDQo+ID4gPiA+ID4gc2V0dGluZyBiZWZvcmUgc3VzcGVuZC10by1pZGxlDQo+ID4gPiA+ID4N
Cj4gPiA+ID4gPiBPbiBGcmlkYXksIFNlcHRlbWJlciAyNSwgMjAxNSAwNjo0Mjo0MSBBTSBDaGVu
LCBZdSBDIHdyb3RlOg0KPiA+ID4gPiA+ID4gSGksUmFmYWVsLCB0aGFua3MgYSBsb3QgZm9yIHlv
dXIgcmV2aWV3LCB3aWxsIHJlc2VuZCB2MiB2ZXJzaW9uLg0KPiA+ID4gPiA+ID4NCj4gPiA+ID4g
PiA+ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gPiA+ID4gPiA+ID4gRnJvbTogUmFm
YWVsIEouIFd5c29ja2kgW21haWx0bzpyandAcmp3eXNvY2tpLm5ldF0NCj4gPiA+ID4gPiA+ID4g
U2VudDogRnJpZGF5LCBTZXB0ZW1iZXIgMjUsIDIwMTUgOToyNCBBTQ0KPiA+ID4gPiA+ID4gPiBU
bzogQ2hlbiwgWXUgQw0KPiA+ID4gPiA+ID4gPiBDYzogV3lzb2NraSwgUmFmYWVsIEo7IGppYW5n
LmxpdUBsaW51eC5pbnRlbC5jb207IFpoYW5nLA0KPiA+ID4gPiA+ID4gPiBSdWk7IEJyb3duLCBM
ZW47IGxpbnV4LSBrZXJuZWxAdmdlci5rZXJuZWwub3JnOw0KPiA+ID4gPiA+ID4gPiBsaW51eC1w
bUB2Z2VyLmtlcm5lbC5vcmcNCj4gPiA+ID4gPiA+ID4gU3ViamVjdDogUmU6IFtQQVRDSF1bUkZD
XSBBQ1BJIC8gUE06IEZpeCBpbmNvcnJlY3Qgd2FrZXVwDQo+ID4gPiA+ID4gPiA+IGlycSBzZXR0
aW5nIGJlZm9yZSBzdXNwZW5kLXRvLWlkbGUNCj4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4g
T24gTW9uZGF5LCBBdWd1c3QgMTAsIDIwMTUgMTA6MTE6MjYgQU0gQ2hlbiBZdSB3cm90ZToNCj4g
PiA+ID4gPg0KPiA+IEJlY2F1c2UgdGhlIG5hbWUgb2YgYWNwaV9pcnEgaXMgYWxyZWFkeSB1c2Vk
IGJ5IGFjcGkgaXJxIGhhbmRsZXIgYXQNCj4gPiBkcml2ZXJzL2FjcGkvb3NsLmM6DQo+ID4gcmVx
dWVzdF9pcnEoaXJxLCBhY3BpX2lycSwgSVJRRl9TSEFSRUQsICJhY3BpIiwgYWNwaV9pcnEpDQo+
IA0KPiBBaCwgdGhpcyBpcyB0aGUgbmFtZSBvZiB0aGUgaGFuZGxlci4gIEkgZm9yZ290IGFib3V0
IHRoYXQsIHNvcnJ5Lg0KPiANCj4gV2VsbCwgaXQgbWlnaHQgYmUgd29ydGggcmVuYW1pbmcgdGhl
IGhhbmRsZXIgdG8gc29tZXRoaW5nIGxpa2UNCj4gYWNwaV9pbnRlcnJ1cHQoKSwgdGhlbi4NCk9L
LCB3aWxsIHJld3JpdGUgdGhlIHBhdGNoLCBUaGFua3MhDQoNCkJlc3QgUmVnYXJkcywNCll1DQo=
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1234407

From"Rafael J. Wysocki" <rafael@kernel.org>
Date2015-09-28 22:10 +0200
Message-ID<qdMUj-1fb-21@gated-at.bofh.it>
In reply to#1234329
Hi,

On Mon, Sep 28, 2015 at 7:56 PM, Chen, Yu C <yu.c.chen@intel.com> wrote:
> Hi,
>
>> -----Original Message-----
>> From: Rafael J. Wysocki [mailto:rjw@rjwysocki.net]
>> Sent: Monday, September 28, 2015 8:56 PM
>> To: Chen, Yu C
>> Cc: Wysocki, Rafael J; jiang.liu@linux.intel.com; Zhang, Rui; Brown, Len; linux-
>> kernel@vger.kernel.org; linux-pm@vger.kernel.org
>> Subject: Re: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq setting before
>> suspend-to-idle
>>
>> On Monday, September 28, 2015 01:51:09 AM Chen, Yu C wrote:
>> > Hi, Rafael,
>> >
>> > > -----Original Message-----
>> > > From: linux-pm-owner@vger.kernel.org [mailto:linux-pm-
>> > > owner@vger.kernel.org] On Behalf Of Rafael J. Wysocki
>> > > Sent: Sunday, September 27, 2015 9:30 PM
>> > > To: Chen, Yu C
>> > > Cc: Wysocki, Rafael J; jiang.liu@linux.intel.com; Zhang, Rui; Brown,
>> > > Len; linux- kernel@vger.kernel.org; linux-pm@vger.kernel.org
>> > > Subject: Re: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq
>> > > setting before suspend-to-idle
>> > >
>> > > On Saturday, September 26, 2015 02:37:19 PM Chen, Yu C wrote:
>> > > > Hi, Rafael,
>> > > >
>> > > > > -----Original Message-----
>> > > > > From: linux-pm-owner@vger.kernel.org [mailto:linux-pm-
>> > > > > owner@vger.kernel.org] On Behalf Of Rafael J. Wysocki
>> > > > > Sent: Friday, September 25, 2015 9:57 PM
>> > > > > To: Chen, Yu C
>> > > > > Cc: Wysocki, Rafael J; jiang.liu@linux.intel.com; Zhang, Rui;
>> > > > > Brown, Len; linux- kernel@vger.kernel.org;
>> > > > > linux-pm@vger.kernel.org
>> > > > > Subject: Re: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq
>> > > > > setting before suspend-to-idle
>> > > > >
>> > > > > On Friday, September 25, 2015 06:42:41 AM Chen, Yu C wrote:
>> > > > > > Hi,Rafael, thanks a lot for your review, will resend v2 version.
>> > > > > >
>> > > > > > > -----Original Message-----
>> > > > > > > From: Rafael J. Wysocki [mailto:rjw@rjwysocki.net]
>> > > > > > > Sent: Friday, September 25, 2015 9:24 AM
>> > > > > > > To: Chen, Yu C
>> > > > > > > Cc: Wysocki, Rafael J; jiang.liu@linux.intel.com; Zhang,
>> > > > > > > Rui; Brown, Len; linux- kernel@vger.kernel.org;
>> > > > > > > linux-pm@vger.kernel.org
>> > > > > > > Subject: Re: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup
>> > > > > > > irq setting before suspend-to-idle
>> > > > > > >
>> > > > > > > On Monday, August 10, 2015 10:11:26 AM Chen Yu wrote:
>> > > > >
>> > Because the name of acpi_irq is already used by acpi irq handler at
>> > drivers/acpi/osl.c:
>> > request_irq(irq, acpi_irq, IRQF_SHARED, "acpi", acpi_irq)
>>
>> Ah, this is the name of the handler.  I forgot about that, sorry.
>>
>> Well, it might be worth renaming the handler to something like
>> acpi_interrupt(), then.
> OK, will rewrite the patch, Thanks!

Alternatively, you can call the new variable acpi_sci_irq.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1234411

From"Rafael J. Wysocki" <rafael@kernel.org>
Date2015-09-28 22:10 +0200
Message-ID<qdMUj-1fb-33@gated-at.bofh.it>
In reply to#1234407
On Mon, Sep 28, 2015 at 10:05 PM, Rafael J. Wysocki <rafael@kernel.org> wrote:
> Hi,
>
> On Mon, Sep 28, 2015 at 7:56 PM, Chen, Yu C <yu.c.chen@intel.com> wrote:

[cut]

>>> > Because the name of acpi_irq is already used by acpi irq handler at
>>> > drivers/acpi/osl.c:
>>> > request_irq(irq, acpi_irq, IRQF_SHARED, "acpi", acpi_irq)
>>>
>>> Ah, this is the name of the handler.  I forgot about that, sorry.
>>>
>>> Well, it might be worth renaming the handler to something like
>>> acpi_interrupt(), then.
>> OK, will rewrite the patch, Thanks!
>
> Alternatively, you can call the new variable acpi_sci_irq.

BTW, please CC ACPI-related patches to linux-acpi too.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web