Re: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq setting before suspend-to-idle

From	"Rafael J. Wysocki" <rafael@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq setting before suspend-to-idle
Date	2015-09-28 22:10 +0200
Message-ID	<qdMUj-1fb-33@gated-at.bofh.it> (permalink)
References	(1 earlier) <qdjSi-82P-15@gated-at.bofh.it> <qdvTr-8b5-1@gated-at.bofh.it> <qdFJ9-5CT-23@gated-at.bofh.it> <qdKSu-6Ap-1@gated-at.bofh.it> <qdMUj-1fb-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Sep 28, 2015 at 10:05 PM, Rafael J. Wysocki <rafael@kernel.org> wrote:
> Hi,
>
> On Mon, Sep 28, 2015 at 7:56 PM, Chen, Yu C <yu.c.chen@intel.com> wrote:

[cut]

>>> > Because the name of acpi_irq is already used by acpi irq handler at
>>> > drivers/acpi/osl.c:
>>> > request_irq(irq, acpi_irq, IRQF_SHARED, "acpi", acpi_irq)
>>>
>>> Ah, this is the name of the handler.  I forgot about that, sorry.
>>>
>>> Well, it might be worth renaming the handler to something like
>>> acpi_interrupt(), then.
>> OK, will rewrite the patch, Thanks!
>
> Alternatively, you can call the new variable acpi_sci_irq.

BTW, please CC ACPI-related patches to linux-acpi too.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq setting before suspend-to-idle "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-09-25 03:00 +0200
  RE: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq setting before  suspend-to-idle "Chen, Yu C" <yu.c.chen@intel.com> - 2015-09-25 08:50 +0200
    Re: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq setting before suspend-to-idle "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-09-25 15:30 +0200
      RE: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq setting before  suspend-to-idle "Chen, Yu C" <yu.c.chen@intel.com> - 2015-09-26 16:40 +0200
        Re: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq setting before suspend-to-idle "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-09-27 15:10 +0200
          RE: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq setting before  suspend-to-idle "Chen, Yu C" <yu.c.chen@intel.com> - 2015-09-28 04:00 +0200
            Re: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq setting before suspend-to-idle "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-09-28 14:30 +0200
              RE: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq setting before  suspend-to-idle "Chen, Yu C" <yu.c.chen@intel.com> - 2015-09-28 20:00 +0200
                Re: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq setting before suspend-to-idle "Rafael J. Wysocki" <rafael@kernel.org> - 2015-09-28 22:10 +0200
                Re: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq setting before suspend-to-idle "Rafael J. Wysocki" <rafael@kernel.org> - 2015-09-28 22:10 +0200

csiph-web