Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1229376 > unrolled thread
| Started by | Andrzej Hajda <a.hajda@samsung.com> |
|---|---|
| First post | 2015-09-21 16:00 +0200 |
| Last post | 2015-09-22 11:40 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 03/38] drm/i915: fix handling gen8_emit_flush_coherentl3_wa result Andrzej Hajda <a.hajda@samsung.com> - 2015-09-21 16:00 +0200
Re: [PATCH 03/38] drm/i915: fix handling gen8_emit_flush_coherentl3_wa result Jani Nikula <jani.nikula@linux.intel.com> - 2015-09-21 16:10 +0200
Re: [PATCH 03/38] drm/i915: fix handling gen8_emit_flush_coherentl3_wa result Daniel Vetter <daniel@ffwll.ch> - 2015-09-22 11:40 +0200
| From | Andrzej Hajda <a.hajda@samsung.com> |
|---|---|
| Date | 2015-09-21 16:00 +0200 |
| Subject | [PATCH 03/38] drm/i915: fix handling gen8_emit_flush_coherentl3_wa result |
| Message-ID | <qb9Np-8s4-49@gated-at.bofh.it> |
The function can return negative value.
The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].
[1]: http://permalink.gmane.org/gmane.linux.kernel/2038576
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
---
drivers/gpu/drm/i915/intel_lrc.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
index fe06accb0..ff9a481 100644
--- a/drivers/gpu/drm/i915/intel_lrc.c
+++ b/drivers/gpu/drm/i915/intel_lrc.c
@@ -1254,9 +1254,10 @@ static int gen8_init_indirectctx_bb(struct intel_engine_cs *ring,
/* WaFlushCoherentL3CacheLinesAtContextSwitch:bdw */
if (IS_BROADWELL(ring->dev)) {
- index = gen8_emit_flush_coherentl3_wa(ring, batch, index);
- if (index < 0)
- return index;
+ int rc = gen8_emit_flush_coherentl3_wa(ring, batch, index);
+ if (rc < 0)
+ return rc;
+ index = rc;
}
/* WaClearSlmSpaceAtContextSwitch:bdw,chv */
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Jani Nikula <jani.nikula@linux.intel.com> |
|---|---|
| Date | 2015-09-21 16:10 +0200 |
| Subject | Re: [PATCH 03/38] drm/i915: fix handling gen8_emit_flush_coherentl3_wa result |
| Message-ID | <qb9X6-rF-67@gated-at.bofh.it> |
| In reply to | #1229376 |
On Mon, 21 Sep 2015, Andrzej Hajda <a.hajda@samsung.com> wrote:
> The function can return negative value.
>
> The problem has been detected using proposed semantic patch
> scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576
>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/intel_lrc.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
> index fe06accb0..ff9a481 100644
> --- a/drivers/gpu/drm/i915/intel_lrc.c
> +++ b/drivers/gpu/drm/i915/intel_lrc.c
> @@ -1254,9 +1254,10 @@ static int gen8_init_indirectctx_bb(struct intel_engine_cs *ring,
>
> /* WaFlushCoherentL3CacheLinesAtContextSwitch:bdw */
> if (IS_BROADWELL(ring->dev)) {
> - index = gen8_emit_flush_coherentl3_wa(ring, batch, index);
> - if (index < 0)
> - return index;
> + int rc = gen8_emit_flush_coherentl3_wa(ring, batch, index);
> + if (rc < 0)
> + return rc;
> + index = rc;
> }
>
> /* WaClearSlmSpaceAtContextSwitch:bdw,chv */
> --
> 1.9.1
>
--
Jani Nikula, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Daniel Vetter <daniel@ffwll.ch> |
|---|---|
| Date | 2015-09-22 11:40 +0200 |
| Subject | Re: [PATCH 03/38] drm/i915: fix handling gen8_emit_flush_coherentl3_wa result |
| Message-ID | <qbsdl-1pF-35@gated-at.bofh.it> |
| In reply to | #1229409 |
On Mon, Sep 21, 2015 at 04:59:58PM +0300, Jani Nikula wrote: > On Mon, 21 Sep 2015, Andrzej Hajda <a.hajda@samsung.com> wrote: > > The function can return negative value. > > > > The problem has been detected using proposed semantic patch > > scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. > > > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 > > > > Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> > > Reviewed-by: Jani Nikula <jani.nikula@intel.com> Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web