Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1229669 > unrolled thread

Re: [PATCH] ata:Check if D2H Register FIS command fails in the function ahci_do_softreset

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] ata:Check if D2H Register FIS command fails in the  function ahci_do_softreset Tejun Heo <tj@kernel.org> - 2015-09-21 21:10 +0200

#1229669 — Re: [PATCH] ata:Check if D2H Register FIS command fails in the function ahci_do_softreset

On Fri, Sep 18, 2015 at 10:36:22PM -0400, Nicholas Krause wrote:
> This fixes the missing error check and handling if the second D2H
> register command fails in the function fails.
> 
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>

This isn't exactly a command execution and the success condition
checks are performed manually afterwards.  The ignoring of command
execution result is intentional there and the proposed change is
likely to cause more harm than good.  Unless there are specific cases
where the new code would behave better, I'd much rather leave it as it
is.

Thansk.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web