Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1229669
| From | Tejun Heo <tj@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] ata:Check if D2H Register FIS command fails in the function ahci_do_softreset |
| Date | 2015-09-21 21:10 +0200 |
| Message-ID | <qbeDo-7aE-21@gated-at.bofh.it> (permalink) |
| References | <qbeDo-7aE-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Sep 18, 2015 at 10:36:22PM -0400, Nicholas Krause wrote: > This fixes the missing error check and handling if the second D2H > register command fails in the function fails. > > Signed-off-by: Nicholas Krause <xerofoify@gmail.com> This isn't exactly a command execution and the success condition checks are performed manually afterwards. The ignoring of command execution result is intentional there and the proposed change is likely to cause more harm than good. Unless there are specific cases where the new code would behave better, I'd much rather leave it as it is. Thansk. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH] ata:Check if D2H Register FIS command fails in the function ahci_do_softreset Tejun Heo <tj@kernel.org> - 2015-09-21 21:10 +0200
csiph-web