Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1231390 > unrolled thread
| Started by | "Felipe F. Tonello" <eu@felipetonello.com> |
|---|---|
| First post | 2015-09-23 14:00 +0200 |
| Last post | 2015-09-25 10:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v2 1/3] usb: chipidea: core: fix when building without CONFIG_PM support "Felipe F. Tonello" <eu@felipetonello.com> - 2015-09-23 14:00 +0200
Re: [PATCH v2 1/3] usb: chipidea: core: fix when building without CONFIG_PM support Felipe Tonello <eu@felipetonello.com> - 2015-09-25 10:30 +0200
| From | "Felipe F. Tonello" <eu@felipetonello.com> |
|---|---|
| Date | 2015-09-23 14:00 +0200 |
| Subject | [PATCH v2 1/3] usb: chipidea: core: fix when building without CONFIG_PM support |
| Message-ID | <qbQSm-3fk-17@gated-at.bofh.it> |
If CONFIG_PM or CONFIG_PM_SLEEP is not set, driver will not compile
properly.
Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
---
Changes for v2:
* removed unnecessary #ifdef CONFIG_PM_SLEEP.
drivers/usb/chipidea/core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
index 3ad48e1..382b4af 100644
--- a/drivers/usb/chipidea/core.c
+++ b/drivers/usb/chipidea/core.c
@@ -1009,18 +1009,20 @@ static int ci_runtime_resume(struct device *dev)
return ci_controller_resume(dev);
}
-#endif /* CONFIG_PM */
static const struct dev_pm_ops ci_pm_ops = {
SET_SYSTEM_SLEEP_PM_OPS(ci_suspend, ci_resume)
SET_RUNTIME_PM_OPS(ci_runtime_suspend, ci_runtime_resume, NULL)
};
+#endif /* CONFIG_PM */
static struct platform_driver ci_hdrc_driver = {
.probe = ci_hdrc_probe,
.remove = ci_hdrc_remove,
.driver = {
.name = "ci_hdrc",
+#ifdef CONFIG_PM
.pm = &ci_pm_ops,
+#endif
},
};
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Felipe Tonello <eu@felipetonello.com> |
|---|---|
| Date | 2015-09-25 10:30 +0200 |
| Subject | Re: [PATCH v2 1/3] usb: chipidea: core: fix when building without CONFIG_PM support |
| Message-ID | <qcwye-4jx-15@gated-at.bofh.it> |
| In reply to | #1231390 |
Hi Peter, On Thu, Sep 24, 2015 at 2:17 AM, Peter Chen <peter.chen@freescale.com> wrote: > On Wed, Sep 23, 2015 at 12:56:58PM +0100, Felipe F. Tonello wrote: >> If CONFIG_PM or CONFIG_PM_SLEEP is not set, driver will not compile >> properly. >> > > Would you post the warning or error messages? > > I just tried at v4.3-rc1 (v4.2 should be same), without any problems. Actually I tested again with the latest and it doesn't break. But still I believe it is the right thing to do, even though it builds. Just good practice to make sure the ifdefs are correct on driver code. Felipe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web