Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1232656

Re: [PATCH v2 1/3] usb: chipidea: core: fix when building without CONFIG_PM support

Show all headers | View raw

Hi Peter,

On Thu, Sep 24, 2015 at 2:17 AM, Peter Chen <peter.chen@freescale.com> wrote:
> On Wed, Sep 23, 2015 at 12:56:58PM +0100, Felipe F. Tonello wrote:
>> If CONFIG_PM or CONFIG_PM_SLEEP is not set, driver will not compile
>> properly.
>>
>
> Would you post the warning or error messages?
>
> I just tried at v4.3-rc1 (v4.2 should be same), without any problems.

Actually I tested again with the latest and it doesn't break. But
still I believe it is the right thing to do, even though it builds.
Just good practice to make sure the ifdefs are correct on driver code.

Felipe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/3] usb: chipidea: core: fix when building without CONFIG_PM support "Felipe F. Tonello" <eu@felipetonello.com> - 2015-09-23 14:00 +0200
  Re: [PATCH v2 1/3] usb: chipidea: core: fix when building without  CONFIG_PM support Felipe Tonello <eu@felipetonello.com> - 2015-09-25 10:30 +0200

csiph-web