Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1223406 > unrolled thread

[PATCH 3/7] tty: serial: msm: Fix command Stale Event Enable definition

Started by"Ivan T. Ivanov" <ivan.ivanov@linaro.org>
First post2015-09-12 15:10 +0200
Last post2015-09-19 07:00 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 3/7] tty: serial: msm: Fix command Stale Event Enable definition "Ivan T. Ivanov" <ivan.ivanov@linaro.org> - 2015-09-12 15:10 +0200
    Re: [PATCH 3/7] tty: serial: msm: Fix command Stale Event Enable  definition Stephen Boyd <sboyd@codeaurora.org> - 2015-09-19 01:40 +0200
      Re: [PATCH 3/7] tty: serial: msm: Fix command Stale Event Enable definition "Ivan T. Ivanov" <ivan.ivanov@linaro.org> - 2015-09-19 07:00 +0200

#1223406 — [PATCH 3/7] tty: serial: msm: Fix command Stale Event Enable definition

From"Ivan T. Ivanov" <ivan.ivanov@linaro.org>
Date2015-09-12 15:10 +0200
Subject[PATCH 3/7] tty: serial: msm: Fix command Stale Event Enable definition
Message-ID<q7SJ4-1mV-23@gated-at.bofh.it>
Stale Event Enable command should be 5 not 8, fix this.

Signed-off-by: Ivan T. Ivanov <ivan.ivanov@linaro.org>
---
 drivers/tty/serial/msm_serial.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/msm_serial.h b/drivers/tty/serial/msm_serial.h
index 60917d30c6b5..223f961f992a 100644
--- a/drivers/tty/serial/msm_serial.h
+++ b/drivers/tty/serial/msm_serial.h
@@ -59,7 +59,7 @@
 #define UART_CR_CMD_SET_RFR		(13 << 4)
 #define UART_CR_CMD_RESET_RFR		(14 << 4)
 #define UART_CR_CMD_PROTECTION_EN	(16 << 4)
-#define UART_CR_CMD_STALE_EVENT_ENABLE	(80 << 4)
+#define UART_CR_CMD_STALE_EVENT_ENABLE	(5 << 8)
 #define UART_CR_CMD_FORCE_STALE		(4 << 8)
 #define UART_CR_CMD_RESET_TX_READY	(3 << 8)
 #define UART_CR_TX_DISABLE		BIT(3)
--
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1228342 — Re: [PATCH 3/7] tty: serial: msm: Fix command Stale Event Enable definition

FromStephen Boyd <sboyd@codeaurora.org>
Date2015-09-19 01:40 +0200
SubjectRe: [PATCH 3/7] tty: serial: msm: Fix command Stale Event Enable definition
Message-ID<qadq1-Ql-5@gated-at.bofh.it>
In reply to#1223406
On 09/12, Ivan T. Ivanov wrote:
> Stale Event Enable command should be 5 not 8, fix this.
> 
> Signed-off-by: Ivan T. Ivanov <ivan.ivanov@linaro.org>
> ---
>  drivers/tty/serial/msm_serial.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/msm_serial.h b/drivers/tty/serial/msm_serial.h
> index 60917d30c6b5..223f961f992a 100644
> --- a/drivers/tty/serial/msm_serial.h
> +++ b/drivers/tty/serial/msm_serial.h
> @@ -59,7 +59,7 @@
>  #define UART_CR_CMD_SET_RFR		(13 << 4)
>  #define UART_CR_CMD_RESET_RFR		(14 << 4)
>  #define UART_CR_CMD_PROTECTION_EN	(16 << 4)
> -#define UART_CR_CMD_STALE_EVENT_ENABLE	(80 << 4)
> +#define UART_CR_CMD_STALE_EVENT_ENABLE	(5 << 8)

I don't get this one

 5 << 8 == 80 << 4

so this makes no difference.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1228391

From"Ivan T. Ivanov" <ivan.ivanov@linaro.org>
Date2015-09-19 07:00 +0200
Message-ID<qaipH-7VZ-5@gated-at.bofh.it>
In reply to#1228342
> On Sep 19, 2015, at 2:33 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> 
> On 09/12, Ivan T. Ivanov wrote:
>> Stale Event Enable command should be 5 not 8, fix this.
>> 
>> Signed-off-by: Ivan T. Ivanov <ivan.ivanov@linaro.org>
>> ---
>> drivers/tty/serial/msm_serial.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/tty/serial/msm_serial.h b/drivers/tty/serial/msm_serial.h
>> index 60917d30c6b5..223f961f992a 100644
>> --- a/drivers/tty/serial/msm_serial.h
>> +++ b/drivers/tty/serial/msm_serial.h
>> @@ -59,7 +59,7 @@
>> #define UART_CR_CMD_SET_RFR		(13 << 4)
>> #define UART_CR_CMD_RESET_RFR		(14 << 4)
>> #define UART_CR_CMD_PROTECTION_EN	(16 << 4)
>> -#define UART_CR_CMD_STALE_EVENT_ENABLE	(80 << 4)
>> +#define UART_CR_CMD_STALE_EVENT_ENABLE	(5 << 8)
> 
> I don't get this one
> 
> 5 << 8 == 80 << 4
> 
> so this makes no difference.


Uh, of course. It is not 0x80. 

Regards,
Ivan--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web