Re: [PATCH 3/7] tty: serial: msm: Fix command Stale Event Enable definition

From	"Ivan T. Ivanov" <ivan.ivanov@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/7] tty: serial: msm: Fix command Stale Event Enable definition
Date	2015-09-19 07:00 +0200
Message-ID	<qaipH-7VZ-5@gated-at.bofh.it> (permalink)
References	<q7SJ3-1mV-3@gated-at.bofh.it> <q7SJ4-1mV-23@gated-at.bofh.it> <qadq1-Ql-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> On Sep 19, 2015, at 2:33 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> 
> On 09/12, Ivan T. Ivanov wrote:
>> Stale Event Enable command should be 5 not 8, fix this.
>> 
>> Signed-off-by: Ivan T. Ivanov <ivan.ivanov@linaro.org>
>> ---
>> drivers/tty/serial/msm_serial.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/tty/serial/msm_serial.h b/drivers/tty/serial/msm_serial.h
>> index 60917d30c6b5..223f961f992a 100644
>> --- a/drivers/tty/serial/msm_serial.h
>> +++ b/drivers/tty/serial/msm_serial.h
>> @@ -59,7 +59,7 @@
>> #define UART_CR_CMD_SET_RFR		(13 << 4)
>> #define UART_CR_CMD_RESET_RFR		(14 << 4)
>> #define UART_CR_CMD_PROTECTION_EN	(16 << 4)
>> -#define UART_CR_CMD_STALE_EVENT_ENABLE	(80 << 4)
>> +#define UART_CR_CMD_STALE_EVENT_ENABLE	(5 << 8)
> 
> I don't get this one
> 
> 5 << 8 == 80 << 4
> 
> so this makes no difference.


Uh, of course. It is not 0x80. 

Regards,
Ivan--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/7] tty: serial: msm: Fix command Stale Event Enable definition "Ivan T. Ivanov" <ivan.ivanov@linaro.org> - 2015-09-12 15:10 +0200
  Re: [PATCH 3/7] tty: serial: msm: Fix command Stale Event Enable  definition Stephen Boyd <sboyd@codeaurora.org> - 2015-09-19 01:40 +0200
    Re: [PATCH 3/7] tty: serial: msm: Fix command Stale Event Enable definition "Ivan T. Ivanov" <ivan.ivanov@linaro.org> - 2015-09-19 07:00 +0200

csiph-web