Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1228191 > unrolled thread

[PATCH 2/2] usb: gadget: f_midi: check for error on usb_ep_queue

Started byeu@felipetonello.com
First post2015-09-18 19:20 +0200
Last post2015-09-21 11:20 +0200
Articles 5 — 4 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 2/2] usb: gadget: f_midi: check for error on usb_ep_queue eu@felipetonello.com - 2015-09-18 19:20 +0200
    Re: [PATCH 2/2] usb: gadget: f_midi: check for error on usb_ep_queue Felipe Balbi <balbi@ti.com> - 2015-09-18 19:20 +0200
    Re: [PATCH 2/2] usb: gadget: f_midi: check for error on usb_ep_queue Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-09-19 18:20 +0200
    Re: [PATCH 2/2] usb: gadget: f_midi: check for error on usb_ep_queue Felipe Tonello <eu@felipetonello.com> - 2015-09-21 10:20 +0200
      Re: [PATCH 2/2] usb: gadget: f_midi: check for error on usb_ep_queue Felipe Tonello <eu@felipetonello.com> - 2015-09-21 11:20 +0200

#1228191 — [PATCH 2/2] usb: gadget: f_midi: check for error on usb_ep_queue

Fromeu@felipetonello.com
Date2015-09-18 19:20 +0200
Subject[PATCH 2/2] usb: gadget: f_midi: check for error on usb_ep_queue
Message-ID<qa7uh-Bk-13@gated-at.bofh.it>
From: "Felipe F. Tonello" <eu@felipetonello.com>

f_midi is not checking weather the is an error on usb_ep_queue
request, ignoring potential problems, such as memory leaks.

Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
---
 drivers/usb/gadget/function/f_midi.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/gadget/function/f_midi.c b/drivers/usb/gadget/function/f_midi.c
index ad50a67..a5e446d 100644
--- a/drivers/usb/gadget/function/f_midi.c
+++ b/drivers/usb/gadget/function/f_midi.c
@@ -543,8 +543,14 @@ static void f_midi_transmit(struct f_midi *midi, struct usb_request *req)
 		}
 	}
 
-	if (req->length > 0)
-		usb_ep_queue(ep, req, GFP_ATOMIC);
+	if (req->length > 0) {
+		int err;
+
+		err = usb_ep_queue(ep, req, GFP_ATOMIC);
+		if (err < 0)
+			ERROR(midi, "%s queue req: %d\n",
+			      midi->out_ep->name, err);
+	}
 	else
 		free_ep_req(ep, req);
 }
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1228196

FromFelipe Balbi <balbi@ti.com>
Date2015-09-18 19:20 +0200
Message-ID<qa7ui-Bk-23@gated-at.bofh.it>
In reply to#1228191

[Multipart message — attachments visible in raw view] — view raw

On Fri, Sep 18, 2015 at 06:12:41PM +0100, eu@felipetonello.com wrote:
> From: "Felipe F. Tonello" <eu@felipetonello.com>
> 
> f_midi is not checking weather the is an error on usb_ep_queue
> request, ignoring potential problems, such as memory leaks.
> 
> Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
> ---
>  drivers/usb/gadget/function/f_midi.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/gadget/function/f_midi.c b/drivers/usb/gadget/function/f_midi.c
> index ad50a67..a5e446d 100644
> --- a/drivers/usb/gadget/function/f_midi.c
> +++ b/drivers/usb/gadget/function/f_midi.c
> @@ -543,8 +543,14 @@ static void f_midi_transmit(struct f_midi *midi, struct usb_request *req)
>  		}
>  	}
>  
> -	if (req->length > 0)
> -		usb_ep_queue(ep, req, GFP_ATOMIC);
> +	if (req->length > 0) {
> +		int err;
> +
> +		err = usb_ep_queue(ep, req, GFP_ATOMIC);
> +		if (err < 0)
> +			ERROR(midi, "%s queue req: %d\n",
> +			      midi->out_ep->name, err);
> +	}
>  	else

yeah, cool, but you need to fix the style here. This else needs
to be after the curly brace and you need to curly brace to the
else branch too.

>  		free_ep_req(ep, req);
>  }
> -- 
> 2.1.4
> 

-- 
balbi

[toc] | [prev] | [next] | [standalone]

#1228469

FromSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date2015-09-19 18:20 +0200
Message-ID<qat1L-6sy-13@gated-at.bofh.it>
In reply to#1228191
Hello.

On 9/18/2015 8:12 PM, eu@felipetonello.com wrote:

> From: "Felipe F. Tonello" <eu@felipetonello.com>
>
> f_midi is not checking weather the is an error on usb_ep_queue
> request, ignoring potential problems, such as memory leaks.
>
> Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
> ---
>   drivers/usb/gadget/function/f_midi.c | 10 ++++++++--
>   1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/gadget/function/f_midi.c b/drivers/usb/gadget/function/f_midi.c
> index ad50a67..a5e446d 100644
> --- a/drivers/usb/gadget/function/f_midi.c
> +++ b/drivers/usb/gadget/function/f_midi.c
> @@ -543,8 +543,14 @@ static void f_midi_transmit(struct f_midi *midi, struct usb_request *req)
>   		}
>   	}
>
> -	if (req->length > 0)
> -		usb_ep_queue(ep, req, GFP_ATOMIC);
> +	if (req->length > 0) {
> +		int err;
> +
> +		err = usb_ep_queue(ep, req, GFP_ATOMIC);
> +		if (err < 0)
> +			ERROR(midi, "%s queue req: %d\n",
> +			      midi->out_ep->name, err);
> +	}
>   	else

	} else {

>   		free_ep_req(ep, req);

	}

>   }

    The lines added above show the proper kernel CodingStyle. } should be on 
the same line as *else* and {} should be used in all branches of the *if* 
statement if at least one branch has them.

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1229108

FromFelipe Tonello <eu@felipetonello.com>
Date2015-09-21 10:20 +0200
Message-ID<qb4um-Zv-15@gated-at.bofh.it>
In reply to#1228191
Hi Chen,

On Mon, Sep 21, 2015 at 7:30 AM, Peter Chen <peter.chen@freescale.com> wrote:
> On Fri, Sep 18, 2015 at 06:12:41PM +0100, eu@felipetonello.com wrote:
>> From: "Felipe F. Tonello" <eu@felipetonello.com>
>>
>> f_midi is not checking weather the is an error on usb_ep_queue
>
> %s/weather/whether
> %s/the/there

I fixed it on v3. Did you receive it?

Felipe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1229135

FromFelipe Tonello <eu@felipetonello.com>
Date2015-09-21 11:20 +0200
Message-ID<qb5qp-2kt-11@gated-at.bofh.it>
In reply to#1229108
Hi Peter,

On Mon, Sep 21, 2015 at 8:49 AM, Peter Chen <peter.chen@freescale.com> wrote:
> On Mon, Sep 21, 2015 at 09:16:05AM +0100, Felipe Tonello wrote:
>> Hi Chen,
>>
>> On Mon, Sep 21, 2015 at 7:30 AM, Peter Chen <peter.chen@freescale.com> wrote:
>> > On Fri, Sep 18, 2015 at 06:12:41PM +0100, eu@felipetonello.com wrote:
>> >> From: "Felipe F. Tonello" <eu@felipetonello.com>
>> >>
>> >> f_midi is not checking weather the is an error on usb_ep_queue
>> >
>> > %s/weather/whether
>> > %s/the/there
>>
>> I fixed it on v3. Did you receive it?
>>
>
> oh, get it, You may add "--subject-prefix="PATCH v3" when you format
> patch, in that case, the reader can see "PATCH v3 2/2" at the subject,
> and know it is the third version.
>
> Your two changes for chipidea are ok, I will queue them.

Thanks. Sorry about that, I thought I did it.

Felipe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web