Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1228196

Re: [PATCH 2/2] usb: gadget: f_midi: check for error on usb_ep_queue

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Fri, Sep 18, 2015 at 06:12:41PM +0100, eu@felipetonello.com wrote:
> From: "Felipe F. Tonello" <eu@felipetonello.com>
> 
> f_midi is not checking weather the is an error on usb_ep_queue
> request, ignoring potential problems, such as memory leaks.
> 
> Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
> ---
>  drivers/usb/gadget/function/f_midi.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/gadget/function/f_midi.c b/drivers/usb/gadget/function/f_midi.c
> index ad50a67..a5e446d 100644
> --- a/drivers/usb/gadget/function/f_midi.c
> +++ b/drivers/usb/gadget/function/f_midi.c
> @@ -543,8 +543,14 @@ static void f_midi_transmit(struct f_midi *midi, struct usb_request *req)
>  		}
>  	}
>  
> -	if (req->length > 0)
> -		usb_ep_queue(ep, req, GFP_ATOMIC);
> +	if (req->length > 0) {
> +		int err;
> +
> +		err = usb_ep_queue(ep, req, GFP_ATOMIC);
> +		if (err < 0)
> +			ERROR(midi, "%s queue req: %d\n",
> +			      midi->out_ep->name, err);
> +	}
>  	else

yeah, cool, but you need to fix the style here. This else needs
to be after the curly brace and you need to curly brace to the
else branch too.

>  		free_ep_req(ep, req);
>  }
> -- 
> 2.1.4
> 

-- 
balbi

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] usb: gadget: f_midi: check for error on usb_ep_queue eu@felipetonello.com - 2015-09-18 19:20 +0200
  Re: [PATCH 2/2] usb: gadget: f_midi: check for error on usb_ep_queue Felipe Balbi <balbi@ti.com> - 2015-09-18 19:20 +0200
  Re: [PATCH 2/2] usb: gadget: f_midi: check for error on usb_ep_queue Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-09-19 18:20 +0200
  Re: [PATCH 2/2] usb: gadget: f_midi: check for error on usb_ep_queue Felipe Tonello <eu@felipetonello.com> - 2015-09-21 10:20 +0200
    Re: [PATCH 2/2] usb: gadget: f_midi: check for error on usb_ep_queue Felipe Tonello <eu@felipetonello.com> - 2015-09-21 11:20 +0200

csiph-web