Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1328437 > unrolled thread

Re: [PATCH] tty: vt: use memdup_user to reuse the code

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] tty: vt: use memdup_user to reuse the code Greg KH <gregkh@linuxfoundation.org> - 2016-02-07 08:40 +0100
    Re: [PATCH] tty: vt: use memdup_user to reuse the code rahul pathak <rahulpathaklinux@gmail.com> - 2016-02-07 11:20 +0100

#1328437 — Re: [PATCH] tty: vt: use memdup_user to reuse the code

On Sun, Dec 20, 2015 at 12:15:33AM +0530, Rahul Pathak wrote:
> Fixing coccicheck warning which recommends to use memdup_user instead
> to reimplement its code, using memdup_user simplifies the code
> 
> ./drivers/tty/vt/keyboard.c:1709:9-16: WARNING opportunity for memdup_user
> ./drivers/tty/vt/keyboard.c:1752:9-16: WARNING opportunity for memdup_user
> 
> Signed-off-by: Rahul Pathak <rahulpathaklinux@gmail.com>
> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
>  drivers/tty/vt/keyboard.c | 28 ++++++++--------------------
>  1 file changed, 8 insertions(+), 20 deletions(-)

Someone else sent half of this patch already, can you redo it against my
tty-testing branch of the tty.git tree and resend it?

thanks,

greg k-h

[toc] | [next] | [standalone]

#1328461

Hello Greg,

Yes I will do this.

Thanks
Rahul

On Sun, Feb 7, 2016 at 1:01 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Sun, Dec 20, 2015 at 12:15:33AM +0530, Rahul Pathak wrote:
>> Fixing coccicheck warning which recommends to use memdup_user instead
>> to reimplement its code, using memdup_user simplifies the code
>>
>> ./drivers/tty/vt/keyboard.c:1709:9-16: WARNING opportunity for memdup_user
>> ./drivers/tty/vt/keyboard.c:1752:9-16: WARNING opportunity for memdup_user
>>
>> Signed-off-by: Rahul Pathak <rahulpathaklinux@gmail.com>
>> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>> ---
>>  drivers/tty/vt/keyboard.c | 28 ++++++++--------------------
>>  1 file changed, 8 insertions(+), 20 deletions(-)
>
> Someone else sent half of this patch already, can you redo it against my
> tty-testing branch of the tty.git tree and resend it?
>
> thanks,
>
> greg k-h

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web