Re: [PATCH] tty: vt: use memdup_user to reuse the code

From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] tty: vt: use memdup_user to reuse the code
Date	2016-02-07 08:40 +0100
Message-ID	<qZs6R-2RU-1@gated-at.bofh.it> (permalink)
References	<qHuJP-6Om-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Dec 20, 2015 at 12:15:33AM +0530, Rahul Pathak wrote:
> Fixing coccicheck warning which recommends to use memdup_user instead
> to reimplement its code, using memdup_user simplifies the code
> 
> ./drivers/tty/vt/keyboard.c:1709:9-16: WARNING opportunity for memdup_user
> ./drivers/tty/vt/keyboard.c:1752:9-16: WARNING opportunity for memdup_user
> 
> Signed-off-by: Rahul Pathak <rahulpathaklinux@gmail.com>
> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
>  drivers/tty/vt/keyboard.c | 28 ++++++++--------------------
>  1 file changed, 8 insertions(+), 20 deletions(-)

Someone else sent half of this patch already, can you redo it against my
tty-testing branch of the tty.git tree and resend it?

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] tty: vt: use memdup_user to reuse the code Greg KH <gregkh@linuxfoundation.org> - 2016-02-07 08:40 +0100
  Re: [PATCH] tty: vt: use memdup_user to reuse the code rahul pathak <rahulpathaklinux@gmail.com> - 2016-02-07 11:20 +0100

csiph-web