Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1328701 > unrolled thread

[PATCH v2 00/10] ARM64: rockchip: Initial GeekBox enablement

Started byAndreas Färber <afaerber@suse.de>
First post2016-02-08 03:20 +0100
Last post2016-02-08 03:30 +0100
Articles 14 — 3 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH v2 00/10] ARM64: rockchip: Initial GeekBox enablement Andreas Färber <afaerber@suse.de> - 2016-02-08 03:20 +0100
    [PATCH v2 08/10] ARM64: dts: rockchip: Add tsadc for GeekBox Andreas Färber <afaerber@suse.de> - 2016-02-08 03:20 +0100
    [PATCH v2 04/10] ARM64: dts: rockchip: Add GMAC to GeekBox Andreas Färber <afaerber@suse.de> - 2016-02-08 03:20 +0100
      Re: [PATCH v2 04/10] ARM64: dts: rockchip: Add GMAC to GeekBox Heiko Stuebner <heiko@sntech.de> - 2016-02-08 11:30 +0100
        Re: [PATCH v2 04/10] ARM64: dts: rockchip: Add GMAC to GeekBox Andreas Färber <afaerber@suse.de> - 2016-02-08 11:50 +0100
    [PATCH v2 09/10] Documentation: devicetree: rockchip: Document Landingship Andreas Färber <afaerber@suse.de> - 2016-02-08 03:20 +0100
      Re: [PATCH v2 09/10] Documentation: devicetree: rockchip: Document Landingship Heiko Stuebner <heiko@sntech.de> - 2016-02-08 11:30 +0100
        Re: [PATCH v2 09/10] Documentation: devicetree: rockchip: Document  Landingship Andreas Färber <afaerber@suse.de> - 2016-02-08 12:00 +0100
    [PATCH v2 10/10] ARM64: dts: rockchip: Add Landingship config Andreas Färber <afaerber@suse.de> - 2016-02-08 03:30 +0100
    [PATCH v2 07/10] ARM64: dts: rockchip: Add power key to GeekBox Andreas Färber <afaerber@suse.de> - 2016-02-08 03:30 +0100
      Re: [PATCH v2 07/10] ARM64: dts: rockchip: Add power key to GeekBox Julien Chauveau <chauveau.julien@gmail.com> - 2016-02-08 17:30 +0100
    [PATCH v2 06/10] ARM64: dts: rockchip: Add IR receiver to GeekBox Andreas Färber <afaerber@suse.de> - 2016-02-08 03:30 +0100
      Re: [PATCH v2 06/10] ARM64: dts: rockchip: Add IR receiver to GeekBox Andreas Färber <afaerber@suse.de> - 2016-02-09 04:10 +0100
    [PATCH v2 05/10] ARM64: dts: rockchip: Add eMMC to GeekBox Andreas Färber <afaerber@suse.de> - 2016-02-08 03:30 +0100

#1328701 — [PATCH v2 00/10] ARM64: rockchip: Initial GeekBox enablement

FromAndreas Färber <afaerber@suse.de>
Date2016-02-08 03:20 +0100
Subject[PATCH v2 00/10] ARM64: rockchip: Initial GeekBox enablement
Message-ID<qZJAK-6SN-3@gated-at.bofh.it>
Hello,

This series adds initial support for the RK3368 based GeekBox.

v2 drops the .dtsi for the module, adds some nodes and a Landingship config.

This is pretty much the state demo'ed at FOSDEM 2016.

Regards,
Andreas

Cc: devicetree@vger.kernel.org

Andreas Färber (10):
  Documentation: devicetree: Add vendor prefix for GeekBuying.com
  Documentation: devicetree: rockchip: Document GeekBox
  ARM64: dts: rockchip: Add GeekBox config
  ARM64: dts: rockchip: Add GMAC to GeekBox
  ARM64: dts: rockchip: Add eMMC to GeekBox
  ARM64: dts: rockchip: Add IR receiver to GeekBox
  ARM64: dts: rockchip: Add power key to GeekBox
  ARM64: dts: rockchip: Add tsadc for GeekBox
  Documentation: devicetree: rockchip: Document Landingship
  ARM64: dts: rockchip: Add Landingship config

 Documentation/devicetree/bindings/arm/rockchip.txt |   9 +
 .../devicetree/bindings/vendor-prefixes.txt        |   1 +
 arch/arm64/boot/dts/rockchip/Makefile              |   2 +
 .../dts/rockchip/rk3368-geekbox-landingship.dts    |  56 ++++
 arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts    | 321 +++++++++++++++++++++
 5 files changed, 389 insertions(+)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3368-geekbox-landingship.dts
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts

-- 
2.6.2

[toc] | [next] | [standalone]


#1328703 — [PATCH v2 08/10] ARM64: dts: rockchip: Add tsadc for GeekBox

FromAndreas Färber <afaerber@suse.de>
Date2016-02-08 03:20 +0100
Subject[PATCH v2 08/10] ARM64: dts: rockchip: Add tsadc for GeekBox
Message-ID<qZJAK-6SN-13@gated-at.bofh.it>
In reply to#1328701
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 v2: New
 
 arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts b/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts
index fe5aa785cfda..7e518768f8b0 100644
--- a/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts
@@ -298,6 +298,12 @@
 	};
 };
 
+&tsadc {
+	status = "okay";
+	rockchip,hw-tshut-mode = <0>; /* CRU */
+	rockchip,hw-tshut-polarity = <0>; /* low */
+};
+
 &uart2 {
 	status = "okay";
 };
-- 
2.6.2

[toc] | [prev] | [next] | [standalone]


#1328705 — [PATCH v2 04/10] ARM64: dts: rockchip: Add GMAC to GeekBox

FromAndreas Färber <afaerber@suse.de>
Date2016-02-08 03:20 +0100
Subject[PATCH v2 04/10] ARM64: dts: rockchip: Add GMAC to GeekBox
Message-ID<qZJAL-6SN-23@gated-at.bofh.it>
In reply to#1328701
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 v2: New
 
 arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts b/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts
index bc91d39758ab..a8dcf3c2b0c1 100644
--- a/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts
@@ -56,6 +56,13 @@
 		reg = <0x0 0x0 0x0 0x80000000>;
 	};
 
+	ext_gmac: gmac-clk {
+		compatible = "fixed-clock";
+		clock-frequency = <125000000>;
+		clock-output-names = "ext_gmac";
+		#clock-cells = <0>;
+	};
+
 	leds: gpio-leds {
 		compatible = "gpio-leds";
 
@@ -82,6 +89,19 @@
 	};
 };
 
+&gmac {
+	status = "okay";
+	phy-supply = <&vcc_lan>;
+	phy-mode = "rgmii";
+	clock_in_out = "input";
+	assigned-clocks = <&cru SCLK_MAC>;
+	assigned-clock-parents = <&ext_gmac>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&rgmii_pins>;
+	tx_delay = <0x30>;
+	rx_delay = <0x10>;
+};
+
 &i2c0 {
 	status = "okay";
 
-- 
2.6.2

[toc] | [prev] | [next] | [standalone]


#1328895 — Re: [PATCH v2 04/10] ARM64: dts: rockchip: Add GMAC to GeekBox

FromHeiko Stuebner <heiko@sntech.de>
Date2016-02-08 11:30 +0100
SubjectRe: [PATCH v2 04/10] ARM64: dts: rockchip: Add GMAC to GeekBox
Message-ID<qZReX-3Ut-25@gated-at.bofh.it>
In reply to#1328705
Hi Andreas,

Am Montag, 8. Februar 2016, 03:17:33 schrieb Andreas Färber:
> Signed-off-by: Andreas Färber <afaerber@suse.de>

is there some special reason that gmac, emmc, ir, etc are in separate 
patches? I guess I'll just fold them into the core patch otherwise.


Heiko

> ---
>  v2: New
> 
>  arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts
> b/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts index
> bc91d39758ab..a8dcf3c2b0c1 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts
> @@ -56,6 +56,13 @@
>  		reg = <0x0 0x0 0x0 0x80000000>;
>  	};
> 
> +	ext_gmac: gmac-clk {
> +		compatible = "fixed-clock";
> +		clock-frequency = <125000000>;
> +		clock-output-names = "ext_gmac";
> +		#clock-cells = <0>;
> +	};
> +
>  	leds: gpio-leds {
>  		compatible = "gpio-leds";
> 
> @@ -82,6 +89,19 @@
>  	};
>  };
> 
> +&gmac {
> +	status = "okay";
> +	phy-supply = <&vcc_lan>;
> +	phy-mode = "rgmii";
> +	clock_in_out = "input";
> +	assigned-clocks = <&cru SCLK_MAC>;
> +	assigned-clock-parents = <&ext_gmac>;
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&rgmii_pins>;
> +	tx_delay = <0x30>;
> +	rx_delay = <0x10>;
> +};
> +
>  &i2c0 {
>  	status = "okay";

[toc] | [prev] | [next] | [standalone]


#1328909 — Re: [PATCH v2 04/10] ARM64: dts: rockchip: Add GMAC to GeekBox

FromAndreas Färber <afaerber@suse.de>
Date2016-02-08 11:50 +0100
SubjectRe: [PATCH v2 04/10] ARM64: dts: rockchip: Add GMAC to GeekBox
Message-ID<qZRyh-41d-13@gated-at.bofh.it>
In reply to#1328895
Hi Heiko,

Am 08.02.2016 um 11:28 schrieb Heiko Stuebner:
> Am Montag, 8. Februar 2016, 03:17:33 schrieb Andreas Färber:
>> Signed-off-by: Andreas Färber <afaerber@suse.de>
> 
> is there some special reason that gmac, emmc, ir, etc are in separate 
> patches? I guess I'll just fold them into the core patch otherwise.

Yes, feel free to squash. They are separate because they were not in v1,
it makes them easier to review and I didn't want errors in them to hold
up the base .dts. :) For example, SDIO I am still fighting with.

Cheers,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)

[toc] | [prev] | [next] | [standalone]


#1328706 — [PATCH v2 09/10] Documentation: devicetree: rockchip: Document Landingship

FromAndreas Färber <afaerber@suse.de>
Date2016-02-08 03:20 +0100
Subject[PATCH v2 09/10] Documentation: devicetree: rockchip: Document Landingship
Message-ID<qZJAL-6SN-25@gated-at.bofh.it>
In reply to#1328701
Use "geekbuying,landingship" compatible string, plus those of GeekBox.

Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 v2: New
 
 Documentation/devicetree/bindings/arm/rockchip.txt | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/rockchip.txt b/Documentation/devicetree/bindings/arm/rockchip.txt
index f633595b196c..c6d95f202591 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.txt
+++ b/Documentation/devicetree/bindings/arm/rockchip.txt
@@ -91,6 +91,11 @@ Rockchip platforms device tree bindings
     Required root node properties:
       - compatible = "geekbuying,geekbox", "rockchip,rk3368";
 
+- GeekBuying Landingship:
+    Required root node properties:
+      - compatible = "geekbuying,landingship",
+		     "geekbuying,geekbox", "rockchip,rk3368";
+
 - Rockchip RK3368 evb:
     Required root node properties:
       - compatible = "rockchip,rk3368-evb-act8846", "rockchip,rk3368";
-- 
2.6.2

[toc] | [prev] | [next] | [standalone]


#1328891 — Re: [PATCH v2 09/10] Documentation: devicetree: rockchip: Document Landingship

FromHeiko Stuebner <heiko@sntech.de>
Date2016-02-08 11:30 +0100
SubjectRe: [PATCH v2 09/10] Documentation: devicetree: rockchip: Document Landingship
Message-ID<qZReW-3Ut-17@gated-at.bofh.it>
In reply to#1328706
Am Montag, 8. Februar 2016, 03:17:38 schrieb Andreas Färber:
> Use "geekbuying,landingship" compatible string, plus those of GeekBox.

I do believe this would be better as geekbuying,geekbox-landingship . They 
might reuse the landingship naming for future baseboards as well ;-)

> 
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
>  v2: New
> 
>  Documentation/devicetree/bindings/arm/rockchip.txt | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.txt
> b/Documentation/devicetree/bindings/arm/rockchip.txt index
> f633595b196c..c6d95f202591 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.txt
> +++ b/Documentation/devicetree/bindings/arm/rockchip.txt
> @@ -91,6 +91,11 @@ Rockchip platforms device tree bindings
>      Required root node properties:
>        - compatible = "geekbuying,geekbox", "rockchip,rk3368";
> 
> +- GeekBuying Landingship:
> +    Required root node properties:
> +      - compatible = "geekbuying,landingship",
> +		     "geekbuying,geekbox", "rockchip,rk3368";
> +
>  - Rockchip RK3368 evb:
>      Required root node properties:
>        - compatible = "rockchip,rk3368-evb-act8846", "rockchip,rk3368";

[toc] | [prev] | [next] | [standalone]


#1328920 — Re: [PATCH v2 09/10] Documentation: devicetree: rockchip: Document Landingship

FromAndreas Färber <afaerber@suse.de>
Date2016-02-08 12:00 +0100
SubjectRe: [PATCH v2 09/10] Documentation: devicetree: rockchip: Document Landingship
Message-ID<qZRHY-44z-21@gated-at.bofh.it>
In reply to#1328891
Am 08.02.2016 um 11:29 schrieb Heiko Stuebner:
> Am Montag, 8. Februar 2016, 03:17:38 schrieb Andreas Färber:
>> Use "geekbuying,landingship" compatible string, plus those of GeekBox.
> 
> I do believe this would be better as geekbuying,geekbox-landingship . They 
> might reuse the landingship naming for future baseboards as well ;-)

Well, the question is: Is this MXM3 interface as generic as Qseven so
that it could be used as is for other modules (and baseboards from other
manufacturers could be used for the module)? Then my thought was
landingship as identifier for the baseboard and geekbox as identifier
for the contained module.

I agree that if this Landingship is specific to the GeekBox then
geekbox-landingship would be more appropriate. We could also do both.

Can you tell? Unfortunately I spot no real documentation of the MXM3
connector pins in the schematics we could compare, only an on-board
documentation of the three-row pins.

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)

[toc] | [prev] | [next] | [standalone]


#1328708 — [PATCH v2 10/10] ARM64: dts: rockchip: Add Landingship config

FromAndreas Färber <afaerber@suse.de>
Date2016-02-08 03:30 +0100
Subject[PATCH v2 10/10] ARM64: dts: rockchip: Add Landingship config
Message-ID<qZJKq-6We-3@gated-at.bofh.it>
In reply to#1328701
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 v2: New - showcases inclusion of GeekBox module config
 
 arch/arm64/boot/dts/rockchip/Makefile              |  1 +
 .../dts/rockchip/rk3368-geekbox-landingship.dts    | 56 ++++++++++++++++++++++
 2 files changed, 57 insertions(+)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3368-geekbox-landingship.dts

diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
index df37865e8ced..201bcd9863ce 100644
--- a/arch/arm64/boot/dts/rockchip/Makefile
+++ b/arch/arm64/boot/dts/rockchip/Makefile
@@ -1,5 +1,6 @@
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3368-evb-act8846.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3368-geekbox.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3368-geekbox-landingship.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3368-r88.dtb
 
 always		:= $(dtb-y)
diff --git a/arch/arm64/boot/dts/rockchip/rk3368-geekbox-landingship.dts b/arch/arm64/boot/dts/rockchip/rk3368-geekbox-landingship.dts
new file mode 100644
index 000000000000..e4a117597a0c
--- /dev/null
+++ b/arch/arm64/boot/dts/rockchip/rk3368-geekbox-landingship.dts
@@ -0,0 +1,56 @@
+/*
+ * Copyright (c) 2016 Andreas Färber
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPL or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ *  a) This file is free software; you can redistribute it and/or
+ *     modify it under the terms of the GNU General Public License as
+ *     published by the Free Software Foundation; either version 2 of the
+ *     License, or (at your option) any later version.
+ *
+ *     This file is distributed in the hope that it will be useful,
+ *     but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *     GNU General Public License for more details.
+ *
+ * Or, alternatively,
+ *
+ *  b) Permission is hereby granted, free of charge, to any person
+ *     obtaining a copy of this software and associated documentation
+ *     files (the "Software"), to deal in the Software without
+ *     restriction, including without limitation the rights to use,
+ *     copy, modify, merge, publish, distribute, sublicense, and/or
+ *     sell copies of the Software, and to permit persons to whom the
+ *     Software is furnished to do so, subject to the following
+ *     conditions:
+ *
+ *     The above copyright notice and this permission notice shall be
+ *     included in all copies or substantial portions of the Software.
+ *
+ *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+ *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ *     OTHER DEALINGS IN THE SOFTWARE.
+ */
+
+#include "rk3368-geekbox.dts"
+
+/ {
+	model = "GeekBox on Landingship";
+	compatible = "geekbuying,landingship", "geekbuying,geekbox", "rockchip,rk3368";
+};
+
+&i2c1 {
+	status = "okay";
+};
+
+&i2c2 {
+	status = "okay";
+};
-- 
2.6.2

[toc] | [prev] | [next] | [standalone]


#1328712 — [PATCH v2 07/10] ARM64: dts: rockchip: Add power key to GeekBox

FromAndreas Färber <afaerber@suse.de>
Date2016-02-08 03:30 +0100
Subject[PATCH v2 07/10] ARM64: dts: rockchip: Add power key to GeekBox
Message-ID<qZJKq-6We-21@gated-at.bofh.it>
In reply to#1328701
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 v2: New
 
 arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts b/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts
index e84383fd6f10..fe5aa785cfda 100644
--- a/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts
@@ -70,6 +70,22 @@
 		pinctrl-0 = <&ir_int>;
 	};
 
+	keys: gpio-keys {
+		compatible = "gpio-keys";
+		pinctrl-names = "default";
+		pinctrl-0 = <&pwr_key>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		button@0 {
+			reg = <0>;
+			gpio-key,wakeup = <1>;
+			gpios = <&gpio0 2 GPIO_ACTIVE_LOW>;
+			label = "GPIO Power";
+			linux,code = <116>;
+		};
+	};
+
 	leds: gpio-leds {
 		compatible = "gpio-leds";
 
@@ -265,6 +281,12 @@
 		};
 	};
 
+	keys {
+		pwr_key: pwr-key {
+			rockchip,pins = <0 2 RK_FUNC_GPIO &pcfg_pull_up>;
+		};
+	};
+
 	pmic {
 		pmic_sleep: pmic-sleep {
 			rockchip,pins = <0 0 RK_FUNC_2 &pcfg_pull_none>;
-- 
2.6.2

[toc] | [prev] | [next] | [standalone]


#1329271 — Re: [PATCH v2 07/10] ARM64: dts: rockchip: Add power key to GeekBox

FromJulien Chauveau <chauveau.julien@gmail.com>
Date2016-02-08 17:30 +0100
SubjectRe: [PATCH v2 07/10] ARM64: dts: rockchip: Add power key to GeekBox
Message-ID<qZWRk-7IX-17@gated-at.bofh.it>
In reply to#1328712
Hello Andreas,

> Le 8 févr. 2016 à 03:17, Andreas Färber <afaerber@suse.de> a écrit :
> 
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
> v2: New
> 
> arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts b/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts
> index e84383fd6f10..fe5aa785cfda 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts
> @@ -70,6 +70,22 @@
> 		pinctrl-0 = <&ir_int>;
> 	};
> 
> +	keys: gpio-keys {
> +		compatible = "gpio-keys";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pwr_key>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;

I think #address-cells and #size-cells are not necessary.

> +
> +		button@0 {
> +			reg = <0>;

reg can be removed too.

> +			gpio-key,wakeup = <1>;

You should use the new "wakeup-source » property.

> +			gpios = <&gpio0 2 GPIO_ACTIVE_LOW>;
> +			label = "GPIO Power";
> +			linux,code = <116>;

#include <dt-bindings/input/input.h>
and use KEY_POWER instead of 116

> +		};
> +	};
> +
> 	leds: gpio-leds {
> 		compatible = "gpio-leds";
> 
> @@ -265,6 +281,12 @@
> 		};
> 	};
> 
> +	keys {
> +		pwr_key: pwr-key {
> +			rockchip,pins = <0 2 RK_FUNC_GPIO &pcfg_pull_up>;

Is there a reason you want to enable the internal pull-up resistor on this pin?

The schematic shows there's already an external pull-up resistor so the internal one should not be needed.


> +		};
> +	};
> +
> 	pmic {
> 		pmic_sleep: pmic-sleep {
> 			rockchip,pins = <0 0 RK_FUNC_2 &pcfg_pull_none>;

[toc] | [prev] | [next] | [standalone]


#1328713 — [PATCH v2 06/10] ARM64: dts: rockchip: Add IR receiver to GeekBox

FromAndreas Färber <afaerber@suse.de>
Date2016-02-08 03:30 +0100
Subject[PATCH v2 06/10] ARM64: dts: rockchip: Add IR receiver to GeekBox
Message-ID<qZJKq-6We-19@gated-at.bofh.it>
In reply to#1328701
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 v2: New
 
 arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts b/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts
index e4523a74050f..e84383fd6f10 100644
--- a/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts
@@ -63,6 +63,13 @@
 		#clock-cells = <0>;
 	};
 
+	ir: ir-receiver {
+		compatible = "gpio-ir-receiver";
+		gpios = <&gpio3 30 GPIO_ACTIVE_LOW>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&ir_int>;
+	};
+
 	leds: gpio-leds {
 		compatible = "gpio-leds";
 
@@ -252,6 +259,12 @@
 };
 
 &pinctrl {
+	ir {
+		ir_int: ir-int {
+			rockchip,pins = <3 30 RK_FUNC_GPIO &pcfg_pull_up>;
+		};
+	};
+
 	pmic {
 		pmic_sleep: pmic-sleep {
 			rockchip,pins = <0 0 RK_FUNC_2 &pcfg_pull_none>;
-- 
2.6.2

[toc] | [prev] | [next] | [standalone]


#1329853 — Re: [PATCH v2 06/10] ARM64: dts: rockchip: Add IR receiver to GeekBox

FromAndreas Färber <afaerber@suse.de>
Date2016-02-09 04:10 +0100
SubjectRe: [PATCH v2 06/10] ARM64: dts: rockchip: Add IR receiver to GeekBox
Message-ID<r06QG-6k0-9@gated-at.bofh.it>
In reply to#1328713
Am 08.02.2016 um 03:17 schrieb Andreas Färber:
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
>  v2: New
>  
>  arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts b/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts
> index e4523a74050f..e84383fd6f10 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts
> @@ -63,6 +63,13 @@
>  		#clock-cells = <0>;
>  	};
>  
> +	ir: ir-receiver {
> +		compatible = "gpio-ir-receiver";
> +		gpios = <&gpio3 30 GPIO_ACTIVE_LOW>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&ir_int>;

		status = "disabled";

Should only be enabled in the new Landingship config. Will fix.

Andreas

P.S. See Heiko, two bugs in the new nodes already, glad I have them
separate. :)

> +	};
> +
>  	leds: gpio-leds {
>  		compatible = "gpio-leds";
>  
[snip]

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)

[toc] | [prev] | [next] | [standalone]


#1328715 — [PATCH v2 05/10] ARM64: dts: rockchip: Add eMMC to GeekBox

FromAndreas Färber <afaerber@suse.de>
Date2016-02-08 03:30 +0100
Subject[PATCH v2 05/10] ARM64: dts: rockchip: Add eMMC to GeekBox
Message-ID<qZJKq-6We-23@gated-at.bofh.it>
In reply to#1328701
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 v2: New
 
 arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts b/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts
index a8dcf3c2b0c1..e4523a74050f 100644
--- a/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts
@@ -89,6 +89,21 @@
 	};
 };
 
+&emmc {
+	status = "okay";
+	bus-width = <8>;
+	cap-mmc-highspeed;
+	clock-frequency = <150000000>;
+	disable-wp;
+	keep-power-in-suspend;
+	non-removable;
+	num-slots = <1>;
+	vmmc-supply = <&vcc_io>;
+	vqmmc-supply = <&vcc18_flash>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&emmc_clk>, <&emmc_cmd>, <&emmc_bus8>;
+};
+
 &gmac {
 	status = "okay";
 	phy-supply = <&vcc_lan>;
-- 
2.6.2

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web