Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1329271
| From | Julien Chauveau <chauveau.julien@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 07/10] ARM64: dts: rockchip: Add power key to GeekBox |
| Date | 2016-02-08 17:30 +0100 |
| Message-ID | <qZWRk-7IX-17@gated-at.bofh.it> (permalink) |
| References | <qZJAK-6SN-3@gated-at.bofh.it> <qZJKq-6We-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hello Andreas,
> Le 8 févr. 2016 à 03:17, Andreas Färber <afaerber@suse.de> a écrit :
>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
> v2: New
>
> arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts b/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts
> index e84383fd6f10..fe5aa785cfda 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts
> @@ -70,6 +70,22 @@
> pinctrl-0 = <&ir_int>;
> };
>
> + keys: gpio-keys {
> + compatible = "gpio-keys";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pwr_key>;
> + #address-cells = <1>;
> + #size-cells = <0>;
I think #address-cells and #size-cells are not necessary.
> +
> + button@0 {
> + reg = <0>;
reg can be removed too.
> + gpio-key,wakeup = <1>;
You should use the new "wakeup-source » property.
> + gpios = <&gpio0 2 GPIO_ACTIVE_LOW>;
> + label = "GPIO Power";
> + linux,code = <116>;
#include <dt-bindings/input/input.h>
and use KEY_POWER instead of 116
> + };
> + };
> +
> leds: gpio-leds {
> compatible = "gpio-leds";
>
> @@ -265,6 +281,12 @@
> };
> };
>
> + keys {
> + pwr_key: pwr-key {
> + rockchip,pins = <0 2 RK_FUNC_GPIO &pcfg_pull_up>;
Is there a reason you want to enable the internal pull-up resistor on this pin?
The schematic shows there's already an external pull-up resistor so the internal one should not be needed.
> + };
> + };
> +
> pmic {
> pmic_sleep: pmic-sleep {
> rockchip,pins = <0 0 RK_FUNC_2 &pcfg_pull_none>;
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 00/10] ARM64: rockchip: Initial GeekBox enablement Andreas Färber <afaerber@suse.de> - 2016-02-08 03:20 +0100
[PATCH v2 08/10] ARM64: dts: rockchip: Add tsadc for GeekBox Andreas Färber <afaerber@suse.de> - 2016-02-08 03:20 +0100
[PATCH v2 04/10] ARM64: dts: rockchip: Add GMAC to GeekBox Andreas Färber <afaerber@suse.de> - 2016-02-08 03:20 +0100
Re: [PATCH v2 04/10] ARM64: dts: rockchip: Add GMAC to GeekBox Heiko Stuebner <heiko@sntech.de> - 2016-02-08 11:30 +0100
Re: [PATCH v2 04/10] ARM64: dts: rockchip: Add GMAC to GeekBox Andreas Färber <afaerber@suse.de> - 2016-02-08 11:50 +0100
[PATCH v2 09/10] Documentation: devicetree: rockchip: Document Landingship Andreas Färber <afaerber@suse.de> - 2016-02-08 03:20 +0100
Re: [PATCH v2 09/10] Documentation: devicetree: rockchip: Document Landingship Heiko Stuebner <heiko@sntech.de> - 2016-02-08 11:30 +0100
Re: [PATCH v2 09/10] Documentation: devicetree: rockchip: Document Landingship Andreas Färber <afaerber@suse.de> - 2016-02-08 12:00 +0100
[PATCH v2 10/10] ARM64: dts: rockchip: Add Landingship config Andreas Färber <afaerber@suse.de> - 2016-02-08 03:30 +0100
[PATCH v2 07/10] ARM64: dts: rockchip: Add power key to GeekBox Andreas Färber <afaerber@suse.de> - 2016-02-08 03:30 +0100
Re: [PATCH v2 07/10] ARM64: dts: rockchip: Add power key to GeekBox Julien Chauveau <chauveau.julien@gmail.com> - 2016-02-08 17:30 +0100
[PATCH v2 06/10] ARM64: dts: rockchip: Add IR receiver to GeekBox Andreas Färber <afaerber@suse.de> - 2016-02-08 03:30 +0100
Re: [PATCH v2 06/10] ARM64: dts: rockchip: Add IR receiver to GeekBox Andreas Färber <afaerber@suse.de> - 2016-02-09 04:10 +0100
[PATCH v2 05/10] ARM64: dts: rockchip: Add eMMC to GeekBox Andreas Färber <afaerber@suse.de> - 2016-02-08 03:30 +0100
csiph-web