Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1326842 > unrolled thread

[patch] MAINTAINERS: trim the file triggers for ABI/API

Started by"Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
First post2016-02-04 15:10 +0100
Last post2016-02-04 22:00 +0100
Articles 5 — 4 participants

Back to article view | Back to linux.kernel

Contents

  [patch] MAINTAINERS: trim the file triggers for ABI/API "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com> - 2016-02-04 15:10 +0100
    Re: [patch] MAINTAINERS: trim the file triggers for ABI/API Shuah Khan <shuahkh@osg.samsung.com> - 2016-02-04 15:40 +0100
    Re: [patch] MAINTAINERS: trim the file triggers for ABI/API Josh Triplett <josh@joshtriplett.org> - 2016-02-04 16:40 +0100
      Re: [patch] MAINTAINERS: trim the file triggers for ABI/API "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com> - 2016-02-04 20:50 +0100
      Re: [patch] MAINTAINERS: trim the file triggers for ABI/API Joe Perches <joe@perches.com> - 2016-02-04 22:00 +0100

#1326842 — [patch] MAINTAINERS: trim the file triggers for ABI/API

From"Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
Date2016-02-04 15:10 +0100
Subject[patch] MAINTAINERS: trim the file triggers for ABI/API
Message-ID<qYsLE-1hC-7@gated-at.bofh.it>
Josh Tripplett's commit ea8f8fc8631d9f890580a94d57a18bfeb827fa2e
was well intentioned (I even Acked it), but in practice it has mostly
generated (a lot of) useless noise on linux-api as developers of
drivers and implementers of other uninteresting changes run
scripts/get-maintainers.pl and unthinkingly paste the results
into their email clients. And that commit didn't really
help catch the really important API changes (new system calls,
new options to existing system calls, new pseudofile entries,
and so on). So, trim the 'F:' triggers for the "ABI/API" entry
in MAINTAINERS right back to the minimum.

Signed-off-by: Michael Kerrisk <mtk.man-pages@gmail.com>
---
 MAINTAINERS | 2 --
 1 file changed, 2 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index f678c37..56f7a4f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -223,9 +223,7 @@ F:  drivers/scsi/aacraid/

 ABI/API
 L:     linux-api@vger.kernel.org
-F:     Documentation/ABI/
 F:     include/linux/syscalls.h
-F:     include/uapi/
 F:     kernel/sys_ni.c

 ABIT UGURU 1,2 HARDWARE MONITOR DRIVER
-- 
2.5.0

[toc] | [next] | [standalone]

#1326875

FromShuah Khan <shuahkh@osg.samsung.com>
Date2016-02-04 15:40 +0100
Message-ID<qYteH-3bN-27@gated-at.bofh.it>
In reply to#1326842
On 02/04/2016 07:05 AM, Michael Kerrisk (man-pages) wrote:
> Josh Tripplett's commit ea8f8fc8631d9f890580a94d57a18bfeb827fa2e
> was well intentioned (I even Acked it), but in practice it has mostly
> generated (a lot of) useless noise on linux-api as developers of
> drivers and implementers of other uninteresting changes run
> scripts/get-maintainers.pl and unthinkingly paste the results
> into their email clients. And that commit didn't really
> help catch the really important API changes (new system calls,
> new options to existing system calls, new pseudofile entries,
> and so on). So, trim the 'F:' triggers for the "ABI/API" entry
> in MAINTAINERS right back to the minimum.
> 
> Signed-off-by: Michael Kerrisk <mtk.man-pages@gmail.com>
> ---
>  MAINTAINERS | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f678c37..56f7a4f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -223,9 +223,7 @@ F:  drivers/scsi/aacraid/
> 
>  ABI/API
>  L:     linux-api@vger.kernel.org
> -F:     Documentation/ABI/
>  F:     include/linux/syscalls.h
> -F:     include/uapi/
>  F:     kernel/sys_ni.c
> 
>  ABIT UGURU 1,2 HARDWARE MONITOR DRIVER
> 

Acked-by: Shuah khan <shuahkh@osg.samsung.com>

thanks,
-- Shuah

-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978

[toc] | [prev] | [next] | [standalone]

#1326929

FromJosh Triplett <josh@joshtriplett.org>
Date2016-02-04 16:40 +0100
Message-ID<qYuaK-3NO-21@gated-at.bofh.it>
In reply to#1326842
On Thu, Feb 04, 2016 at 03:05:19PM +0100, Michael Kerrisk (man-pages) wrote:
> Josh Tripplett's commit ea8f8fc8631d9f890580a94d57a18bfeb827fa2e

s/Tripplett/Triplett/

> was well intentioned (I even Acked it), but in practice it has mostly
> generated (a lot of) useless noise on linux-api as developers of
> drivers and implementers of other uninteresting changes run
> scripts/get-maintainers.pl and unthinkingly paste the results
> into their email clients. And that commit didn't really
> help catch the really important API changes (new system calls,
> new options to existing system calls, new pseudofile entries,
> and so on). So, trim the 'F:' triggers for the "ABI/API" entry
> in MAINTAINERS right back to the minimum.

This change makes sense, but I don't think this commit message explains
the specific changes to the file triggers.  (Also, there's a convention
for referencing past commits.)  Might I suggest an alternate commit
message?

"""
Commit ea8f8fc8631 ("MAINTAINERS: add linux-api for review of API/ABI
changes") added file triggers for various paths that likely indicated
API/ABI changes.  However, catching all changes in Documentation/ABI/
and include/uapi/ produces a large volume of mail to linux-api, rather
than only API/ABI changes.  Drop those two entries, but leave
include/linux/syscalls.h and kernel/sys_ni.c to catch syscall-related
changes.
"""

> Signed-off-by: Michael Kerrisk <mtk.man-pages@gmail.com>
> ---
>  MAINTAINERS | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f678c37..56f7a4f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -223,9 +223,7 @@ F:  drivers/scsi/aacraid/
> 
>  ABI/API
>  L:     linux-api@vger.kernel.org
> -F:     Documentation/ABI/
>  F:     include/linux/syscalls.h
> -F:     include/uapi/
>  F:     kernel/sys_ni.c
> 
>  ABIT UGURU 1,2 HARDWARE MONITOR DRIVER
> -- 
> 2.5.0

[toc] | [prev] | [next] | [standalone]

#1327131

From"Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
Date2016-02-04 20:50 +0100
Message-ID<qYy4G-6oS-3@gated-at.bofh.it>
In reply to#1326929
Hi Josh,

On 4 February 2016 at 16:34, Josh Triplett <josh@joshtriplett.org> wrote:
> On Thu, Feb 04, 2016 at 03:05:19PM +0100, Michael Kerrisk (man-pages) wrote:
>> Josh Tripplett's commit ea8f8fc8631d9f890580a94d57a18bfeb827fa2e
>
> s/Tripplett/Triplett/
>
>> was well intentioned (I even Acked it), but in practice it has mostly
>> generated (a lot of) useless noise on linux-api as developers of
>> drivers and implementers of other uninteresting changes run
>> scripts/get-maintainers.pl and unthinkingly paste the results
>> into their email clients. And that commit didn't really
>> help catch the really important API changes (new system calls,
>> new options to existing system calls, new pseudofile entries,
>> and so on). So, trim the 'F:' triggers for the "ABI/API" entry
>> in MAINTAINERS right back to the minimum.
>
> This change makes sense, but I don't think this commit message explains
> the specific changes to the file triggers.  (Also, there's a convention
> for referencing past commits.)  Might I suggest an alternate commit
> message?
>
> """
> Commit ea8f8fc8631 ("MAINTAINERS: add linux-api for review of API/ABI
> changes") added file triggers for various paths that likely indicated
> API/ABI changes.  However, catching all changes in Documentation/ABI/
> and include/uapi/ produces a large volume of mail to linux-api, rather
> than only API/ABI changes.  Drop those two entries, but leave
> include/linux/syscalls.h and kernel/sys_ni.c to catch syscall-related
> changes.
> """

Thanks. Looks like Andrew picked your version of the commit message up.

Cheers,

Michael

>> Signed-off-by: Michael Kerrisk <mtk.man-pages@gmail.com>
>> ---
>>  MAINTAINERS | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index f678c37..56f7a4f 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -223,9 +223,7 @@ F:  drivers/scsi/aacraid/
>>
>>  ABI/API
>>  L:     linux-api@vger.kernel.org
>> -F:     Documentation/ABI/
>>  F:     include/linux/syscalls.h
>> -F:     include/uapi/
>>  F:     kernel/sys_ni.c
>>
>>  ABIT UGURU 1,2 HARDWARE MONITOR DRIVER
>> --
>> 2.5.0



-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

[toc] | [prev] | [next] | [standalone]

#1327187

FromJoe Perches <joe@perches.com>
Date2016-02-04 22:00 +0100
Message-ID<qYzar-74b-31@gated-at.bofh.it>
In reply to#1326929
On Thu, 2016-02-04 at 07:34 -0800, Josh Triplett wrote:
> On Thu, Feb 04, 2016 at 03:05:19PM +0100, Michael Kerrisk (man-pages) wrote:

> Might I suggest an alternate commit message?
> 
> """
> Commit ea8f8fc8631 ("MAINTAINERS: add linux-api for review of API/ABI
> changes") added file triggers for various paths that likely indicated
> API/ABI changes.  However, catching all changes in Documentation/ABI/
> and include/uapi/ produces a large volume of mail to linux-api, rather
> than only API/ABI changes.  Drop those two entries, but leave
> include/linux/syscalls.h and kernel/sys_ni.c to catch syscall-related
> changes.
> """
[]
> > diff --git a/MAINTAINERS b/MAINTAINERS
[]
> > @@ -223,9 +223,7 @@ F:  drivers/scsi/aacraid/
> > 
> >  ABI/API
> >  L:     linux-api@vger.kernel.org
> > -F:     Documentation/ABI/
> >  F:     include/linux/syscalls.h
> > -F:     include/uapi/
> >  F:     kernel/sys_ni.c

Maybe add a keyword entry like:

K:	(?i)syscall

to see all actual changes of syscalls too?

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web