Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1327131

Re: [patch] MAINTAINERS: trim the file triggers for ABI/API

Show all headers | View raw

Hi Josh,

On 4 February 2016 at 16:34, Josh Triplett <josh@joshtriplett.org> wrote:
> On Thu, Feb 04, 2016 at 03:05:19PM +0100, Michael Kerrisk (man-pages) wrote:
>> Josh Tripplett's commit ea8f8fc8631d9f890580a94d57a18bfeb827fa2e
>
> s/Tripplett/Triplett/
>
>> was well intentioned (I even Acked it), but in practice it has mostly
>> generated (a lot of) useless noise on linux-api as developers of
>> drivers and implementers of other uninteresting changes run
>> scripts/get-maintainers.pl and unthinkingly paste the results
>> into their email clients. And that commit didn't really
>> help catch the really important API changes (new system calls,
>> new options to existing system calls, new pseudofile entries,
>> and so on). So, trim the 'F:' triggers for the "ABI/API" entry
>> in MAINTAINERS right back to the minimum.
>
> This change makes sense, but I don't think this commit message explains
> the specific changes to the file triggers.  (Also, there's a convention
> for referencing past commits.)  Might I suggest an alternate commit
> message?
>
> """
> Commit ea8f8fc8631 ("MAINTAINERS: add linux-api for review of API/ABI
> changes") added file triggers for various paths that likely indicated
> API/ABI changes.  However, catching all changes in Documentation/ABI/
> and include/uapi/ produces a large volume of mail to linux-api, rather
> than only API/ABI changes.  Drop those two entries, but leave
> include/linux/syscalls.h and kernel/sys_ni.c to catch syscall-related
> changes.
> """

Thanks. Looks like Andrew picked your version of the commit message up.

Cheers,

Michael

>> Signed-off-by: Michael Kerrisk <mtk.man-pages@gmail.com>
>> ---
>>  MAINTAINERS | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index f678c37..56f7a4f 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -223,9 +223,7 @@ F:  drivers/scsi/aacraid/
>>
>>  ABI/API
>>  L:     linux-api@vger.kernel.org
>> -F:     Documentation/ABI/
>>  F:     include/linux/syscalls.h
>> -F:     include/uapi/
>>  F:     kernel/sys_ni.c
>>
>>  ABIT UGURU 1,2 HARDWARE MONITOR DRIVER
>> --
>> 2.5.0



-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[patch] MAINTAINERS: trim the file triggers for ABI/API "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com> - 2016-02-04 15:10 +0100
  Re: [patch] MAINTAINERS: trim the file triggers for ABI/API Shuah Khan <shuahkh@osg.samsung.com> - 2016-02-04 15:40 +0100
  Re: [patch] MAINTAINERS: trim the file triggers for ABI/API Josh Triplett <josh@joshtriplett.org> - 2016-02-04 16:40 +0100
    Re: [patch] MAINTAINERS: trim the file triggers for ABI/API "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com> - 2016-02-04 20:50 +0100
    Re: [patch] MAINTAINERS: trim the file triggers for ABI/API Joe Perches <joe@perches.com> - 2016-02-04 22:00 +0100

csiph-web