Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1326848 > unrolled thread
| Started by | Dmitry Monakhov <dmonakhov@openvz.org> |
|---|---|
| First post | 2016-02-04 15:10 +0100 |
| Last post | 2016-02-04 17:00 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] dax: dirty inode only if required Dmitry Monakhov <dmonakhov@openvz.org> - 2016-02-04 15:10 +0100
Re: [PATCH] dax: dirty inode only if required Jan Kara <jack@suse.cz> - 2016-02-04 15:40 +0100
Re: [PATCH] dax: dirty inode only if required Ross Zwisler <ross.zwisler@linux.intel.com> - 2016-02-04 17:00 +0100
| From | Dmitry Monakhov <dmonakhov@openvz.org> |
|---|---|
| Date | 2016-02-04 15:10 +0100 |
| Subject | [PATCH] dax: dirty inode only if required |
| Message-ID | <qYsLE-1hC-21@gated-at.bofh.it> |
Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org> --- fs/dax.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/dax.c b/fs/dax.c index e0e9358..fc2e314 100644 --- a/fs/dax.c +++ b/fs/dax.c @@ -358,7 +358,8 @@ static int dax_radix_entry(struct address_space *mapping, pgoff_t index, void *entry; WARN_ON_ONCE(pmd_entry && !dirty); - __mark_inode_dirty(mapping->host, I_DIRTY_PAGES); + if (dirty) + __mark_inode_dirty(mapping->host, I_DIRTY_PAGES); spin_lock_irq(&mapping->tree_lock); -- 1.8.3.1
[toc] | [next] | [standalone]
| From | Jan Kara <jack@suse.cz> |
|---|---|
| Date | 2016-02-04 15:40 +0100 |
| Message-ID | <qYteH-3bN-39@gated-at.bofh.it> |
| In reply to | #1326848 |
On Thu 04-02-16 17:02:02, Dmitry Monakhov wrote: > > Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org> Makes sense. You can add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > fs/dax.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/fs/dax.c b/fs/dax.c > index e0e9358..fc2e314 100644 > --- a/fs/dax.c > +++ b/fs/dax.c > @@ -358,7 +358,8 @@ static int dax_radix_entry(struct address_space *mapping, pgoff_t index, > void *entry; > > WARN_ON_ONCE(pmd_entry && !dirty); > - __mark_inode_dirty(mapping->host, I_DIRTY_PAGES); > + if (dirty) > + __mark_inode_dirty(mapping->host, I_DIRTY_PAGES); > > spin_lock_irq(&mapping->tree_lock); > > -- > 1.8.3.1 > -- Jan Kara <jack@suse.com> SUSE Labs, CR
[toc] | [prev] | [next] | [standalone]
| From | Ross Zwisler <ross.zwisler@linux.intel.com> |
|---|---|
| Date | 2016-02-04 17:00 +0100 |
| Message-ID | <qYuu6-3V9-25@gated-at.bofh.it> |
| In reply to | #1326878 |
On Thu, Feb 04, 2016 at 03:33:44PM +0100, Jan Kara wrote: > On Thu 04-02-16 17:02:02, Dmitry Monakhov wrote: > > > > Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org> > > Makes sense. You can add: > > Reviewed-by: Jan Kara <jack@suse.cz> Looks good to me as well. Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com> > Honza > > --- > > fs/dax.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/fs/dax.c b/fs/dax.c > > index e0e9358..fc2e314 100644 > > --- a/fs/dax.c > > +++ b/fs/dax.c > > @@ -358,7 +358,8 @@ static int dax_radix_entry(struct address_space *mapping, pgoff_t index, > > void *entry; > > > > WARN_ON_ONCE(pmd_entry && !dirty); > > - __mark_inode_dirty(mapping->host, I_DIRTY_PAGES); > > + if (dirty) > > + __mark_inode_dirty(mapping->host, I_DIRTY_PAGES); > > > > spin_lock_irq(&mapping->tree_lock); > > > > -- > > 1.8.3.1 > > > -- > Jan Kara <jack@suse.com> > SUSE Labs, CR
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web