Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1326878

Re: [PATCH] dax: dirty inode only if required

From Jan Kara <jack@suse.cz>
Newsgroups linux.kernel
Subject Re: [PATCH] dax: dirty inode only if required
Date 2016-02-04 15:40 +0100
Message-ID <qYteH-3bN-39@gated-at.bofh.it> (permalink)
References <qYsLE-1hC-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu 04-02-16 17:02:02, Dmitry Monakhov wrote:
> 
> Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>

Makes sense. You can add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza
> ---
>  fs/dax.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/dax.c b/fs/dax.c
> index e0e9358..fc2e314 100644
> --- a/fs/dax.c
> +++ b/fs/dax.c
> @@ -358,7 +358,8 @@ static int dax_radix_entry(struct address_space *mapping, pgoff_t index,
>  	void *entry;
>  
>  	WARN_ON_ONCE(pmd_entry && !dirty);
> -	__mark_inode_dirty(mapping->host, I_DIRTY_PAGES);
> +	if (dirty)
> +		__mark_inode_dirty(mapping->host, I_DIRTY_PAGES);
>  
>  	spin_lock_irq(&mapping->tree_lock);
>  
> -- 
> 1.8.3.1
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] dax: dirty inode only if required Dmitry Monakhov <dmonakhov@openvz.org> - 2016-02-04 15:10 +0100
  Re: [PATCH] dax: dirty inode only if required Jan Kara <jack@suse.cz> - 2016-02-04 15:40 +0100
    Re: [PATCH] dax: dirty inode only if required Ross Zwisler <ross.zwisler@linux.intel.com> - 2016-02-04 17:00 +0100

csiph-web