Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1327633 > unrolled thread
| Started by | Cyrille Pitchen <cyrille.pitchen@atmel.com> |
|---|---|
| First post | 2016-02-05 13:50 +0100 |
| Last post | 2016-02-06 08:50 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 0/2] crypto: atmel-sha - fix resource management Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2016-02-05 13:50 +0100
[PATCH 1/2] crypto: atmel-sha: fix atmel_sha_remove() Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2016-02-05 13:50 +0100
Re: [PATCH 0/2] crypto: atmel-sha - fix resource management Herbert Xu <herbert@gondor.apana.org.au> - 2016-02-06 08:50 +0100
| From | Cyrille Pitchen <cyrille.pitchen@atmel.com> |
|---|---|
| Date | 2016-02-05 13:50 +0100 |
| Subject | [PATCH 0/2] crypto: atmel-sha - fix resource management |
| Message-ID | <qYNZM-hE-5@gated-at.bofh.it> |
Hi all, these two small patches fix resource release and clock management in atomic context. Best regards, Cyrille Cyrille Pitchen (2): crypto: atmel-sha: fix atmel_sha_remove() crypto: atmel-sha - remove calls of clk_prepare() from atomic contexts drivers/crypto/atmel-sha.c | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) -- 1.8.2.2
[toc] | [next] | [standalone]
| From | Cyrille Pitchen <cyrille.pitchen@atmel.com> |
|---|---|
| Date | 2016-02-05 13:50 +0100 |
| Subject | [PATCH 1/2] crypto: atmel-sha: fix atmel_sha_remove() |
| Message-ID | <qYNZM-hE-11@gated-at.bofh.it> |
| In reply to | #1327633 |
Since atmel_sha_probe() uses devm_xxx functions to allocate resources,
atmel_sha_remove() should no longer explicitly release them.
Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
Fixes: b0e8b3417a62 ("crypto: atmel - use devm_xxx() managed function")
---
drivers/crypto/atmel-sha.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/crypto/atmel-sha.c b/drivers/crypto/atmel-sha.c
index 63b09e01075c..b827c99b17c1 100644
--- a/drivers/crypto/atmel-sha.c
+++ b/drivers/crypto/atmel-sha.c
@@ -1611,13 +1611,6 @@ static int atmel_sha_remove(struct platform_device *pdev)
if (sha_dd->caps.has_dma)
atmel_sha_dma_cleanup(sha_dd);
- iounmap(sha_dd->io_base);
-
- clk_put(sha_dd->iclk);
-
- if (sha_dd->irq >= 0)
- free_irq(sha_dd->irq, sha_dd);
-
return 0;
}
--
1.8.2.2
[toc] | [prev] | [next] | [standalone]
| From | Herbert Xu <herbert@gondor.apana.org.au> |
|---|---|
| Date | 2016-02-06 08:50 +0100 |
| Message-ID | <qZ5N0-46X-21@gated-at.bofh.it> |
| In reply to | #1327633 |
On Fri, Feb 05, 2016 at 01:45:11PM +0100, Cyrille Pitchen wrote: > Hi all, > > these two small patches fix resource release and clock management in > atomic context. Applied to crypto. -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web