Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1327634

[PATCH 1/2] crypto: atmel-sha: fix atmel_sha_remove()

Show all headers | View raw

Since atmel_sha_probe() uses devm_xxx functions to allocate resources,
atmel_sha_remove() should no longer explicitly release them.

Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
Fixes: b0e8b3417a62 ("crypto: atmel - use devm_xxx() managed function")
---
 drivers/crypto/atmel-sha.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/crypto/atmel-sha.c b/drivers/crypto/atmel-sha.c
index 63b09e01075c..b827c99b17c1 100644
--- a/drivers/crypto/atmel-sha.c
+++ b/drivers/crypto/atmel-sha.c
@@ -1611,13 +1611,6 @@ static int atmel_sha_remove(struct platform_device *pdev)
 	if (sha_dd->caps.has_dma)
 		atmel_sha_dma_cleanup(sha_dd);
 
-	iounmap(sha_dd->io_base);
-
-	clk_put(sha_dd->iclk);
-
-	if (sha_dd->irq >= 0)
-		free_irq(sha_dd->irq, sha_dd);
-
 	return 0;
 }
 
-- 
1.8.2.2

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] crypto: atmel-sha - fix resource management Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2016-02-05 13:50 +0100
  [PATCH 1/2] crypto: atmel-sha: fix atmel_sha_remove() Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2016-02-05 13:50 +0100
  Re: [PATCH 0/2] crypto: atmel-sha - fix resource management Herbert Xu <herbert@gondor.apana.org.au> - 2016-02-06 08:50 +0100

csiph-web