Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1323180 > unrolled thread

Re: [PATCH 3/5] btrfs: Use radix_tree_iter_retry()

Started byDavid Sterba <dsterba@suse.cz>
First post2016-02-01 15:40 +0100
Last post2016-02-01 15:40 +0100
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 3/5] btrfs: Use radix_tree_iter_retry() David Sterba <dsterba@suse.cz> - 2016-02-01 15:40 +0100

#1323180 — Re: [PATCH 3/5] btrfs: Use radix_tree_iter_retry()

FromDavid Sterba <dsterba@suse.cz>
Date2016-02-01 15:40 +0100
SubjectRe: [PATCH 3/5] btrfs: Use radix_tree_iter_retry()
Message-ID<qXnO7-4aB-133@gated-at.bofh.it>
On Wed, Jan 27, 2016 at 04:17:50PM -0500, Matthew Wilcox wrote:
> From: Matthew Wilcox <willy@linux.intel.com>
> 
> Even though this is a 'can't happen' situation, use the new
> radix_tree_iter_retry() pattern to eliminate a goto.

Andrew's tree contains a fixup for a build failure

> @@ -147,7 +146,7 @@ restart:
>  		/* Shouldn't happen but that kind of thinking creates CVE's */
>  		if (radix_tree_exception(eb)) {
>  			if (radix_tree_deref_retry(eb))
> -				goto restart;
> +				slot = radix_tree_iter_retry(iter);

				slot = radix_tree_iter_retry(&iter);

http://ozlabs.org/~akpm/mmots/broken-out/btrfs-use-radix_tree_iter_retry-fix.patch

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web