Re: [PATCH 3/5] btrfs: Use radix_tree_iter_retry()

From	David Sterba <dsterba@suse.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/5] btrfs: Use radix_tree_iter_retry()
Date	2016-02-01 15:40 +0100
Message-ID	<qXnO7-4aB-133@gated-at.bofh.it> (permalink)
References	<qVFFo-1hk-29@gated-at.bofh.it> <qVFFq-1hk-61@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jan 27, 2016 at 04:17:50PM -0500, Matthew Wilcox wrote:
> From: Matthew Wilcox <willy@linux.intel.com>
> 
> Even though this is a 'can't happen' situation, use the new
> radix_tree_iter_retry() pattern to eliminate a goto.

Andrew's tree contains a fixup for a build failure

> @@ -147,7 +146,7 @@ restart:
>  		/* Shouldn't happen but that kind of thinking creates CVE's */
>  		if (radix_tree_exception(eb)) {
>  			if (radix_tree_deref_retry(eb))
> -				goto restart;
> +				slot = radix_tree_iter_retry(iter);

				slot = radix_tree_iter_retry(&iter);

http://ozlabs.org/~akpm/mmots/broken-out/btrfs-use-radix_tree_iter_retry-fix.patch

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 3/5] btrfs: Use radix_tree_iter_retry() David Sterba <dsterba@suse.cz> - 2016-02-01 15:40 +0100

csiph-web