Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1322967 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2016-02-01 11:30 +0100 |
| Last post | 2016-02-01 13:20 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v4 4/9] pinctrl: Add STM32 MCUs support Arnd Bergmann <arnd@arndb.de> - 2016-02-01 11:30 +0100
Re: [PATCH v4 4/9] pinctrl: Add STM32 MCUs support Maxime Coquelin <mcoquelin.stm32@gmail.com> - 2016-02-01 11:40 +0100
Re: [PATCH v4 4/9] pinctrl: Add STM32 MCUs support Maxime Coquelin <maxime.coquelin@st.com> - 2016-02-01 13:20 +0100
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-02-01 11:30 +0100 |
| Subject | Re: [PATCH v4 4/9] pinctrl: Add STM32 MCUs support |
| Message-ID | <qXjU6-19m-9@gated-at.bofh.it> |
On Wednesday 27 January 2016 14:16:32 Linus Walleij wrote: > On Thu, Jan 14, 2016 at 1:16 PM, Maxime Coquelin > <mcoquelin.stm32@gmail.com> wrote: > > > This patch adds pinctrl and GPIO support to STMicroelectronic's STM32 > > family of MCUs. > > > > While it only supports STM32F429 for now, it has been designed to enable > > support of other MCUs of the family (e.g. STM32F746). > > > > Acked-by: Patrice Chotard <patrice.chotard@st.com> > > Signed-off-by: Maxime Coquelin <mcoquelin.stm32@gmail.com> > > This patch applied for kernel v4.6. > This breaks the kernel build, please revert: drivers/pinctrl/stm32/pinctrl-stm32.c:26:47: fatal error: dt-bindings/pinctrl/pinctrl-stm32.h: No such file or directory Arnd
[toc] | [next] | [standalone]
| From | Maxime Coquelin <mcoquelin.stm32@gmail.com> |
|---|---|
| Date | 2016-02-01 11:40 +0100 |
| Message-ID | <qXk3M-1dK-19@gated-at.bofh.it> |
| In reply to | #1322967 |
2016-02-01 11:21 GMT+01:00 Arnd Bergmann <arnd@arndb.de>: > On Wednesday 27 January 2016 14:16:32 Linus Walleij wrote: >> On Thu, Jan 14, 2016 at 1:16 PM, Maxime Coquelin >> <mcoquelin.stm32@gmail.com> wrote: >> >> > This patch adds pinctrl and GPIO support to STMicroelectronic's STM32 >> > family of MCUs. >> > >> > While it only supports STM32F429 for now, it has been designed to enable >> > support of other MCUs of the family (e.g. STM32F746). >> > >> > Acked-by: Patrice Chotard <patrice.chotard@st.com> >> > Signed-off-by: Maxime Coquelin <mcoquelin.stm32@gmail.com> >> >> This patch applied for kernel v4.6. >> > > This breaks the kernel build, please revert: > > drivers/pinctrl/stm32/pinctrl-stm32.c:26:47: fatal error: dt-bindings/pinctrl/pinctrl-stm32.h: No such file or directory Right, I missed to notify this dependency to Linus, sorry about that. This dependency is no more needed, so I could just move the macros to the driver side. Note that I also noticed a breakage at build time due to field renaming in gpio_chip structure (dev -> parent). I propose to rebase the series and move the defines into the driver. Is it ok for you? Regards, Maxime
[toc] | [prev] | [next] | [standalone]
| From | Maxime Coquelin <maxime.coquelin@st.com> |
|---|---|
| Date | 2016-02-01 13:20 +0100 |
| Message-ID | <qXlCx-2xe-1@gated-at.bofh.it> |
| In reply to | #1322980 |
On 02/01/2016 11:39 AM, Maxime Coquelin wrote: > 2016-02-01 11:21 GMT+01:00 Arnd Bergmann <arnd@arndb.de>: >> On Wednesday 27 January 2016 14:16:32 Linus Walleij wrote: >>> On Thu, Jan 14, 2016 at 1:16 PM, Maxime Coquelin >>> <mcoquelin.stm32@gmail.com> wrote: >>> >>>> This patch adds pinctrl and GPIO support to STMicroelectronic's STM32 >>>> family of MCUs. >>>> >>>> While it only supports STM32F429 for now, it has been designed to enable >>>> support of other MCUs of the family (e.g. STM32F746). >>>> >>>> Acked-by: Patrice Chotard <patrice.chotard@st.com> >>>> Signed-off-by: Maxime Coquelin <mcoquelin.stm32@gmail.com> >>> This patch applied for kernel v4.6. >>> >> This breaks the kernel build, please revert: >> >> drivers/pinctrl/stm32/pinctrl-stm32.c:26:47: fatal error: dt-bindings/pinctrl/pinctrl-stm32.h: No such file or directory > Right, I missed to notify this dependency to Linus, sorry about that. > This dependency is no more needed, so I could just move the macros to > the driver side. > > Note that I also noticed a breakage at build time due to field > renaming in gpio_chip structure (dev -> parent). > > I propose to rebase the series and move the defines into the driver. > Is it ok for you? > I have rebased the series, taking care to fix the mentioned problems. Linus, do you confirm you will revert STM32 pinctrl patches from your tree? Thanks, Maxime
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web