Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1322980

Re: [PATCH v4 4/9] pinctrl: Add STM32 MCUs support

Show all headers | View raw

2016-02-01 11:21 GMT+01:00 Arnd Bergmann <arnd@arndb.de>:
> On Wednesday 27 January 2016 14:16:32 Linus Walleij wrote:
>> On Thu, Jan 14, 2016 at 1:16 PM, Maxime Coquelin
>> <mcoquelin.stm32@gmail.com> wrote:
>>
>> > This patch adds pinctrl and GPIO support to STMicroelectronic's STM32
>> > family of MCUs.
>> >
>> > While it only supports STM32F429 for now, it has been designed to enable
>> > support of other MCUs of the family (e.g. STM32F746).
>> >
>> > Acked-by: Patrice Chotard <patrice.chotard@st.com>
>> > Signed-off-by: Maxime Coquelin <mcoquelin.stm32@gmail.com>
>>
>> This patch applied for kernel v4.6.
>>
>
> This breaks the kernel build, please revert:
>
> drivers/pinctrl/stm32/pinctrl-stm32.c:26:47: fatal error: dt-bindings/pinctrl/pinctrl-stm32.h: No such file or directory

Right, I missed to notify this dependency to Linus, sorry about that.
This dependency is no more needed, so I could just move the macros to
the driver side.

Note that I also noticed a breakage at build time due to field
renaming in gpio_chip structure (dev -> parent).

I propose to rebase the series and move the defines into the driver.
Is it ok for you?

Regards,
Maxime

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 4/9] pinctrl: Add STM32 MCUs support Arnd Bergmann <arnd@arndb.de> - 2016-02-01 11:30 +0100
  Re: [PATCH v4 4/9] pinctrl: Add STM32 MCUs support Maxime Coquelin <mcoquelin.stm32@gmail.com> - 2016-02-01 11:40 +0100
    Re: [PATCH v4 4/9] pinctrl: Add STM32 MCUs support Maxime Coquelin <maxime.coquelin@st.com> - 2016-02-01 13:20 +0100

csiph-web