Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1324690 > unrolled thread

Re: [RFC 00/26] perf tools: Introduce hists specific format entries

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [RFC 00/26] perf tools: Introduce hists specific format entries Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-02-02 23:30 +0100
    Re: [RFC 00/26] perf tools: Introduce hists specific format entries Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-02-02 23:30 +0100
    Re: [RFC 00/26] perf tools: Introduce hists specific format entries Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-02-02 23:50 +0100
      Re: [RFC 00/26] perf tools: Introduce hists specific format entries Jiri Olsa <jolsa@redhat.com> - 2016-02-03 09:00 +0100
        Re: [RFC 00/26] perf tools: Introduce hists specific format entries Jiri Olsa <jolsa@redhat.com> - 2016-02-03 12:10 +0100

#1324690 — Re: [RFC 00/26] perf tools: Introduce hists specific format entries

Em Mon, Jan 25, 2016 at 03:37:43PM +0100, Jiri Olsa escreveu:
> On Mon, Jan 25, 2016 at 11:24:24PM +0900, Namhyung Kim wrote:
> > Hi Jiri,
> > 
> > On Mon, Jan 25, 2016 at 08:15:52AM +0100, Jiri Olsa wrote:
> > > On Mon, Jan 18, 2016 at 10:23:58AM +0100, Jiri Olsa wrote:
> > > > hi,
> > > > currently we have global format sort and output
> > > > lists. This rfc patchset introduces hists object
> > > > based format entries to allow the hist object to
> > > > carry specific format entries.
> > > > 
> > > > This will allow to have distinguished hist objects
> > > > displaying different stuff in output.
> > 
> > The concepth is OK.  But I don't want to embed hists into the
> > hist_entry for hierarchy mode.  As you said it'd be better to factor
> > out common bits and embed it both from hists and hist entry.  In the
> > minimal, two rbroot (for in and out) and a format list would be
> > required IMHO.
> 
> right.. however this patchset just adds the support to have
> format lists (sort and output) defined for the hists object
> 
> I plan the 'cutting out common hists' part to come after this
> one and after we merge your hierachy view patchset

Ok, so I rebased it on top of my perf/core branch, adjusting some stuff
wrt recent patchkits from Namhyung (hist_entry__callchain_fprintf() is
no more, etc), and renaming that perf_hpp_list->{list,sort_list} to
->{fields,sorts} as Namhyung suggested and you agreed, it builds...

But perf top isn't showing the overhead column... there were some
changes to perf report in this patchkit to move some initializations...
will check there...

- Arnaldo

[toc] | [next] | [standalone]

#1324691

Em Tue, Feb 02, 2016 at 07:22:47PM -0300, Arnaldo Carvalho de Melo escreveu:
> Ok, so I rebased it on top of my perf/core branch, adjusting some stuff
> wrt recent patchkits from Namhyung (hist_entry__callchain_fprintf() is
> no more, etc), and renaming that perf_hpp_list->{list,sort_list} to
> ->{fields,sorts} as Namhyung suggested and you agreed, it builds...
> 
> But perf top isn't showing the overhead column... there were some
> changes to perf report in this patchkit to move some initializations...
> will check there...

Double checking...

[acme@jouet linux]$ git bisect bad
cd85325039555bbf37d08d399ae2b1c91c70a565 is the first bad commit
commit cd85325039555bbf37d08d399ae2b1c91c70a565
Author: Jiri Olsa <jolsa@kernel.org>
Date:   Mon Jan 18 10:24:07 2016 +0100

    perf hists: Allocate output sort field
    
    Currently we use static output fields, because we have single global
    list of all sort/output fields.
    
    We will add hists specific sort and output lists in following patches,
    so we need all format entries to be dynamically allocated. Adding
    support to allocate output sort field.
    
    Signed-off-by: Jiri Olsa <jolsa@kernel.org>
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Link: http://lkml.kernel.org/r/1453109064-1026-10-git-send-email-jolsa@kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

:040000 040000 f119a49ec0c9954f3117e151719c3c322c1651e4 4bb14abe5005fe29c45eecd9f6fab30fabc0fd99 M	tools
[acme@jouet linux]$

[toc] | [prev] | [next] | [standalone]

#1324701

Em Tue, Feb 02, 2016 at 07:22:47PM -0300, Arnaldo Carvalho de Melo escreveu:
> Ok, so I rebased it on top of my perf/core branch, adjusting some stuff
> wrt recent patchkits from Namhyung (hist_entry__callchain_fprintf() is
> no more, etc), and renaming that perf_hpp_list->{list,sort_list} to
> ->{fields,sorts} as Namhyung suggested and you agreed, it builds...
> 
> But perf top isn't showing the overhead column... there were some
> changes to perf report in this patchkit to move some initializations...
> will check there...

Fixed, doing the same change you made for 'perf report', moving the
setup_sorting call to after the setup_browser one, inserted a new patch
with that just before the patch where the problem was bisected, please
check.

To recap:

git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tmp.perf/hists/hpp_list

https://git.kernel.org/cgit/linux/kernel/git/acme/linux.git/commit/?h=tmp.perf/hists/hpp_list&id=7d105448f8922679956728a7f5106218378c450e

- Arnaldo

[toc] | [prev] | [next] | [standalone]

#1325007

On Tue, Feb 02, 2016 at 07:42:16PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Feb 02, 2016 at 07:22:47PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Ok, so I rebased it on top of my perf/core branch, adjusting some stuff
> > wrt recent patchkits from Namhyung (hist_entry__callchain_fprintf() is
> > no more, etc), and renaming that perf_hpp_list->{list,sort_list} to
> > ->{fields,sorts} as Namhyung suggested and you agreed, it builds...
> > 
> > But perf top isn't showing the overhead column... there were some
> > changes to perf report in this patchkit to move some initializations...
> > will check there...
> 
> Fixed, doing the same change you made for 'perf report', moving the
> setup_sorting call to after the setup_browser one, inserted a new patch
> with that just before the patch where the problem was bisected, please
> check.
> 
> To recap:
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tmp.perf/hists/hpp_list
> 
> https://git.kernel.org/cgit/linux/kernel/git/acme/linux.git/commit/?h=tmp.perf/hists/hpp_list&id=7d105448f8922679956728a7f5106218378c450e

I'll check on that, thanks a lot

jirka

[toc] | [prev] | [next] | [standalone]

#1325210

On Wed, Feb 03, 2016 at 08:58:53AM +0100, Jiri Olsa wrote:
> On Tue, Feb 02, 2016 at 07:42:16PM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Tue, Feb 02, 2016 at 07:22:47PM -0300, Arnaldo Carvalho de Melo escreveu:
> > > Ok, so I rebased it on top of my perf/core branch, adjusting some stuff
> > > wrt recent patchkits from Namhyung (hist_entry__callchain_fprintf() is
> > > no more, etc), and renaming that perf_hpp_list->{list,sort_list} to
> > > ->{fields,sorts} as Namhyung suggested and you agreed, it builds...
> > > 
> > > But perf top isn't showing the overhead column... there were some
> > > changes to perf report in this patchkit to move some initializations...
> > > will check there...
> > 
> > Fixed, doing the same change you made for 'perf report', moving the
> > setup_sorting call to after the setup_browser one, inserted a new patch
> > with that just before the patch where the problem was bisected, please
> > check.
> > 
> > To recap:
> > 
> > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tmp.perf/hists/hpp_list
> > 
> > https://git.kernel.org/cgit/linux/kernel/git/acme/linux.git/commit/?h=tmp.perf/hists/hpp_list&id=7d105448f8922679956728a7f5106218378c450e
> 
> I'll check on that, thanks a lot

it looks ok to me

thanks,
jirka

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web