Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1324701

Re: [RFC 00/26] perf tools: Introduce hists specific format entries

From Arnaldo Carvalho de Melo <acme@kernel.org>
Newsgroups linux.kernel
Subject Re: [RFC 00/26] perf tools: Introduce hists specific format entries
Date 2016-02-02 23:50 +0100
Message-ID <qXRVL-1tU-7@gated-at.bofh.it> (permalink)
References <qSeil-73y-3@gated-at.bofh.it> <qUJBo-rn-7@gated-at.bofh.it> <qUQjw-5hx-29@gated-at.bofh.it> <qUQtc-5oH-17@gated-at.bofh.it> <qXRCq-1mL-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Em Tue, Feb 02, 2016 at 07:22:47PM -0300, Arnaldo Carvalho de Melo escreveu:
> Ok, so I rebased it on top of my perf/core branch, adjusting some stuff
> wrt recent patchkits from Namhyung (hist_entry__callchain_fprintf() is
> no more, etc), and renaming that perf_hpp_list->{list,sort_list} to
> ->{fields,sorts} as Namhyung suggested and you agreed, it builds...
> 
> But perf top isn't showing the overhead column... there were some
> changes to perf report in this patchkit to move some initializations...
> will check there...

Fixed, doing the same change you made for 'perf report', moving the
setup_sorting call to after the setup_browser one, inserted a new patch
with that just before the patch where the problem was bisected, please
check.

To recap:

git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tmp.perf/hists/hpp_list

https://git.kernel.org/cgit/linux/kernel/git/acme/linux.git/commit/?h=tmp.perf/hists/hpp_list&id=7d105448f8922679956728a7f5106218378c450e

- Arnaldo

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [RFC 00/26] perf tools: Introduce hists specific format entries Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-02-02 23:30 +0100
  Re: [RFC 00/26] perf tools: Introduce hists specific format entries Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-02-02 23:30 +0100
  Re: [RFC 00/26] perf tools: Introduce hists specific format entries Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-02-02 23:50 +0100
    Re: [RFC 00/26] perf tools: Introduce hists specific format entries Jiri Olsa <jolsa@redhat.com> - 2016-02-03 09:00 +0100
      Re: [RFC 00/26] perf tools: Introduce hists specific format entries Jiri Olsa <jolsa@redhat.com> - 2016-02-03 12:10 +0100

csiph-web