Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1321554 > unrolled thread

[PATCH] irqchip: mxs: add missing set_handle_irq()

Started byOleksij Rempel <linux@rempel-privat.de>
First post2016-01-29 09:40 +0100
Last post2016-01-29 10:00 +0100
Articles 8 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] irqchip: mxs: add missing set_handle_irq() Oleksij Rempel <linux@rempel-privat.de> - 2016-01-29 09:40 +0100
    Re: [PATCH] irqchip: mxs: add missing set_handle_irq() Thomas Gleixner <tglx@linutronix.de> - 2016-01-29 09:40 +0100
      Re: [PATCH] irqchip: mxs: add missing set_handle_irq() Oleksij Rempel <linux@rempel-privat.de> - 2016-01-29 10:00 +0100
        Re: [PATCH] irqchip: mxs: add missing set_handle_irq() Thomas Gleixner <tglx@linutronix.de> - 2016-01-29 10:20 +0100
          [PATCH v2] irqchip: mxs: add missing set_handle_irq() Oleksij Rempel <linux@rempel-privat.de> - 2016-01-29 11:00 +0100
            [tip:irq/urgent] irqchip/mxs: Add missing set_handle_irq() tip-bot for Oleksij Rempel <tipbot@zytor.com> - 2016-01-29 12:20 +0100
      Re: [PATCH] irqchip: mxs: add missing set_handle_irq() Thomas Gleixner <tglx@linutronix.de> - 2016-01-29 10:00 +0100
      Re: [PATCH] irqchip: mxs: add missing set_handle_irq() Oleksij Rempel <linux@rempel-privat.de> - 2016-01-29 10:00 +0100

#1321554 — [PATCH] irqchip: mxs: add missing set_handle_irq()

FromOleksij Rempel <linux@rempel-privat.de>
Date2016-01-29 09:40 +0100
Subject[PATCH] irqchip: mxs: add missing set_handle_irq()
Message-ID<qWcKZ-5o-1@gated-at.bofh.it>
this will fix IRQ related issues on Alphascale ASM9260

Signed-off-by: Oleksij Rempel <linux@rempel-privat.de>
---
 drivers/irqchip/irq-mxs.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/irqchip/irq-mxs.c b/drivers/irqchip/irq-mxs.c
index c22e2d4..efe5084 100644
--- a/drivers/irqchip/irq-mxs.c
+++ b/drivers/irqchip/irq-mxs.c
@@ -241,6 +241,7 @@ static int __init asm9260_of_init(struct device_node *np,
 		writel(0, icoll_priv.intr + i);
 
 	icoll_add_domain(np, ASM9260_NUM_IRQS);
+	set_handle_irq(icoll_handle_irq);
 
 	return 0;
 }
-- 
2.5.0

[toc] | [next] | [standalone]

#1321557

FromThomas Gleixner <tglx@linutronix.de>
Date2016-01-29 09:40 +0100
Message-ID<qWcL0-5o-17@gated-at.bofh.it>
In reply to#1321554
On Fri, 29 Jan 2016, Oleksij Rempel wrote:

> this will fix IRQ related issues on Alphascale ASM9260

This really does not qualify as a changelog.

1) What's the problem and what consequences does it have

2) What's the fix.

Thanks,

	tglx

[toc] | [prev] | [next] | [standalone]

#1321586

FromOleksij Rempel <linux@rempel-privat.de>
Date2016-01-29 10:00 +0100
Message-ID<qWd4m-cs-15@gated-at.bofh.it>
In reply to#1321557

[Multipart message — attachments visible in raw view] — view raw

Am 29.01.2016 um 09:54 schrieb Thomas Gleixner:
> On Fri, 29 Jan 2016, Oleksij Rempel wrote:
>> Am 29.01.2016 um 09:33 schrieb Thomas Gleixner:
>>> On Fri, 29 Jan 2016, Oleksij Rempel wrote:
>>>
>>>> this will fix IRQ related issues on Alphascale ASM9260
>>>
>>> This really does not qualify as a changelog.
>>>
>>> 1) What's the problem and what consequences does it have
>>>
>>> 2) What's the fix.
>>>
>>> Thanks,
>>>
>>> 	tglx
>>>
>>
>> The driver provide this function:
>> asmlinkage void __exception_irq_entry icoll_handle_irq(struct pt_regs *regs)
>> {
>>         u32 irqnr;
>>
>>         irqnr = __raw_readl(icoll_priv.stat);
>>         __raw_writel(irqnr, icoll_priv.vector);
>>         handle_domain_irq(icoll_domain, irqnr, regs);
>> }
>>
>> i assume at some late review point instead of move it to asm9260_of_init
>> i removed it completely. As result, the driver was compilable but not
>> working.
>> Should i put this explanation to changelog?
> 
> So the problem is:
> 
> The rework of the driver missed to move the call to set_handle_irq() into
> asm9260_of_init(). As a consequence no interrupt entry point is installed and
> no interrupts are delivered (or whatever the outcome is, crash, explode ...)
> 
> Solution is:
> 
> Install the interrupt entry handler.
> 
> Right?

Right.

Should i resend a patch with new comment?

> And that wants a tag:
> 
> Fixes: nnnnnnnnnnnn ("irqchip/......")
> 
> So we can mark it for stable.
> 
> Thanks,
> 
> 	tglx
> 


-- 
Regards,
Oleksij

[toc] | [prev] | [next] | [standalone]

#1321596

FromThomas Gleixner <tglx@linutronix.de>
Date2016-01-29 10:20 +0100
Message-ID<qWdnH-zP-1@gated-at.bofh.it>
In reply to#1321586
On Fri, 29 Jan 2016, Oleksij Rempel wrote:
> Should i resend a patch with new comment?

Yes, please.

[toc] | [prev] | [next] | [standalone]

#1321620 — [PATCH v2] irqchip: mxs: add missing set_handle_irq()

FromOleksij Rempel <linux@rempel-privat.de>
Date2016-01-29 11:00 +0100
Subject[PATCH v2] irqchip: mxs: add missing set_handle_irq()
Message-ID<qWe0q-OA-11@gated-at.bofh.it>
In reply to#1321596
The rework of the driver missed to move the call to set_handle_irq() into
asm9260_of_init(). As a consequence no interrupt entry point is installed and
no interrupts are delivered

Solution is:
Install the interrupt entry handler.

Fixes: 7e4ac676ee ("irqchip/mxs: Add Alphascale ASM9260 support")

Signed-off-by: Oleksij Rempel <linux@rempel-privat.de>
---
 drivers/irqchip/irq-mxs.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/irqchip/irq-mxs.c b/drivers/irqchip/irq-mxs.c
index c22e2d4..efe5084 100644
--- a/drivers/irqchip/irq-mxs.c
+++ b/drivers/irqchip/irq-mxs.c
@@ -241,6 +241,7 @@ static int __init asm9260_of_init(struct device_node *np,
 		writel(0, icoll_priv.intr + i);
 
 	icoll_add_domain(np, ASM9260_NUM_IRQS);
+	set_handle_irq(icoll_handle_irq);
 
 	return 0;
 }
-- 
2.5.0

[toc] | [prev] | [next] | [standalone]

#1321661 — [tip:irq/urgent] irqchip/mxs: Add missing set_handle_irq()

Fromtip-bot for Oleksij Rempel <tipbot@zytor.com>
Date2016-01-29 12:20 +0100
Subject[tip:irq/urgent] irqchip/mxs: Add missing set_handle_irq()
Message-ID<qWffQ-240-17@gated-at.bofh.it>
In reply to#1321620
Commit-ID:  c5b635203032462603c503ecce91a7021c1ad44a
Gitweb:     http://git.kernel.org/tip/c5b635203032462603c503ecce91a7021c1ad44a
Author:     Oleksij Rempel <linux@rempel-privat.de>
AuthorDate: Fri, 29 Jan 2016 10:57:53 +0100
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Fri, 29 Jan 2016 12:15:50 +0100

irqchip/mxs: Add missing set_handle_irq()

The rework of the driver missed to move the call to set_handle_irq() into
asm9260_of_init(). As a consequence no interrupt entry point is installed and
no interrupts are delivered

Solution is simple: Install the interrupt entry handler.

Fixes: 7e4ac676ee ("irqchip/mxs: Add Alphascale ASM9260 support")
Signed-off-by: Oleksij Rempel <linux@rempel-privat.de>
Cc: kernel@pengutronix.de
Cc: jason@lakedaemon.net
Cc: marc.zyngier@arm.com
Cc: stable@vger.kernel.org
Link: http://lkml.kernel.org/r/1454061473-24957-1-git-send-email-linux@rempel-privat.de
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 drivers/irqchip/irq-mxs.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/irqchip/irq-mxs.c b/drivers/irqchip/irq-mxs.c
index c22e2d4..efe5084 100644
--- a/drivers/irqchip/irq-mxs.c
+++ b/drivers/irqchip/irq-mxs.c
@@ -241,6 +241,7 @@ static int __init asm9260_of_init(struct device_node *np,
 		writel(0, icoll_priv.intr + i);
 
 	icoll_add_domain(np, ASM9260_NUM_IRQS);
+	set_handle_irq(icoll_handle_irq);
 
 	return 0;
 }

[toc] | [prev] | [next] | [standalone]

#1321589

FromThomas Gleixner <tglx@linutronix.de>
Date2016-01-29 10:00 +0100
Message-ID<qWd4m-cs-19@gated-at.bofh.it>
In reply to#1321557
On Fri, 29 Jan 2016, Oleksij Rempel wrote:
> Am 29.01.2016 um 09:33 schrieb Thomas Gleixner:
> > On Fri, 29 Jan 2016, Oleksij Rempel wrote:
> > 
> >> this will fix IRQ related issues on Alphascale ASM9260
> > 
> > This really does not qualify as a changelog.
> > 
> > 1) What's the problem and what consequences does it have
> > 
> > 2) What's the fix.
> > 
> > Thanks,
> > 
> > 	tglx
> > 
> 
> The driver provide this function:
> asmlinkage void __exception_irq_entry icoll_handle_irq(struct pt_regs *regs)
> {
>         u32 irqnr;
> 
>         irqnr = __raw_readl(icoll_priv.stat);
>         __raw_writel(irqnr, icoll_priv.vector);
>         handle_domain_irq(icoll_domain, irqnr, regs);
> }
> 
> i assume at some late review point instead of move it to asm9260_of_init
> i removed it completely. As result, the driver was compilable but not
> working.
> Should i put this explanation to changelog?

So the problem is:

The rework of the driver missed to move the call to set_handle_irq() into
asm9260_of_init(). As a consequence no interrupt entry point is installed and
no interrupts are delivered (or whatever the outcome is, crash, explode ...)

Solution is:

Install the interrupt entry handler.

Right?

And that wants a tag:

Fixes: nnnnnnnnnnnn ("irqchip/......")

So we can mark it for stable.

Thanks,

	tglx

[toc] | [prev] | [next] | [standalone]

#1321591

FromOleksij Rempel <linux@rempel-privat.de>
Date2016-01-29 10:00 +0100
Message-ID<qWd4m-cs-17@gated-at.bofh.it>
In reply to#1321557

[Multipart message — attachments visible in raw view] — view raw

Am 29.01.2016 um 09:33 schrieb Thomas Gleixner:
> On Fri, 29 Jan 2016, Oleksij Rempel wrote:
> 
>> this will fix IRQ related issues on Alphascale ASM9260
> 
> This really does not qualify as a changelog.
> 
> 1) What's the problem and what consequences does it have
> 
> 2) What's the fix.
> 
> Thanks,
> 
> 	tglx
> 

The driver provide this function:
asmlinkage void __exception_irq_entry icoll_handle_irq(struct pt_regs *regs)
{
        u32 irqnr;

        irqnr = __raw_readl(icoll_priv.stat);
        __raw_writel(irqnr, icoll_priv.vector);
        handle_domain_irq(icoll_domain, irqnr, regs);
}

i assume at some late review point instead of move it to asm9260_of_init
i removed it completely. As result, the driver was compilable but not
working.

Should i put this explanation to changelog?
-- 
Regards,
Oleksij

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web