Re: [PATCH] irqchip: mxs: add missing set_handle_irq()

From	Oleksij Rempel <linux@rempel-privat.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] irqchip: mxs: add missing set_handle_irq()
Date	2016-01-29 10:00 +0100
Message-ID	<qWd4m-cs-17@gated-at.bofh.it> (permalink)
References	<qWcKZ-5o-1@gated-at.bofh.it> <qWcL0-5o-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Am 29.01.2016 um 09:33 schrieb Thomas Gleixner:
> On Fri, 29 Jan 2016, Oleksij Rempel wrote:
> 
>> this will fix IRQ related issues on Alphascale ASM9260
> 
> This really does not qualify as a changelog.
> 
> 1) What's the problem and what consequences does it have
> 
> 2) What's the fix.
> 
> Thanks,
> 
> 	tglx
> 

The driver provide this function:
asmlinkage void __exception_irq_entry icoll_handle_irq(struct pt_regs *regs)
{
        u32 irqnr;

        irqnr = __raw_readl(icoll_priv.stat);
        __raw_writel(irqnr, icoll_priv.vector);
        handle_domain_irq(icoll_domain, irqnr, regs);
}

i assume at some late review point instead of move it to asm9260_of_init
i removed it completely. As result, the driver was compilable but not
working.

Should i put this explanation to changelog?
-- 
Regards,
Oleksij

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] irqchip: mxs: add missing set_handle_irq() Oleksij Rempel <linux@rempel-privat.de> - 2016-01-29 09:40 +0100
  Re: [PATCH] irqchip: mxs: add missing set_handle_irq() Thomas Gleixner <tglx@linutronix.de> - 2016-01-29 09:40 +0100
    Re: [PATCH] irqchip: mxs: add missing set_handle_irq() Oleksij Rempel <linux@rempel-privat.de> - 2016-01-29 10:00 +0100
      Re: [PATCH] irqchip: mxs: add missing set_handle_irq() Thomas Gleixner <tglx@linutronix.de> - 2016-01-29 10:20 +0100
        [PATCH v2] irqchip: mxs: add missing set_handle_irq() Oleksij Rempel <linux@rempel-privat.de> - 2016-01-29 11:00 +0100
          [tip:irq/urgent] irqchip/mxs: Add missing set_handle_irq() tip-bot for Oleksij Rempel <tipbot@zytor.com> - 2016-01-29 12:20 +0100
    Re: [PATCH] irqchip: mxs: add missing set_handle_irq() Thomas Gleixner <tglx@linutronix.de> - 2016-01-29 10:00 +0100
    Re: [PATCH] irqchip: mxs: add missing set_handle_irq() Oleksij Rempel <linux@rempel-privat.de> - 2016-01-29 10:00 +0100

csiph-web