Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1321144 > unrolled thread

Re: [PATCH] ASoC: pcm3168a: Call clk_set_rate in pcm3168a_set_dai_sysclk

Started byMark Brown <broonie@kernel.org>
First post2016-01-29 00:20 +0100
Last post2016-01-29 00:20 +0100
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] ASoC: pcm3168a: Call clk_set_rate in  pcm3168a_set_dai_sysclk Mark Brown <broonie@kernel.org> - 2016-01-29 00:20 +0100

#1321144 — Re: [PATCH] ASoC: pcm3168a: Call clk_set_rate in pcm3168a_set_dai_sysclk

FromMark Brown <broonie@kernel.org>
Date2016-01-29 00:20 +0100
SubjectRe: [PATCH] ASoC: pcm3168a: Call clk_set_rate in pcm3168a_set_dai_sysclk
Message-ID<qW414-2cO-35@gated-at.bofh.it>

[Multipart message — attachments visible in raw view] — view raw

On Thu, Jan 28, 2016 at 04:54:20PM +0000, Damien Horsley wrote:

> +	ret = clk_set_rate(pcm3168a->scki, freq);
> +	if (ret)
> +		return ret;
> +
>  	pcm3168a->sysclk = freq;

Since the clock appears to be mandatory in this driver (good!) why are
we even storing sysclk?  Just remove it, the driver never actually used
it anyway.

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web