Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1321144

Re: [PATCH] ASoC: pcm3168a: Call clk_set_rate in pcm3168a_set_dai_sysclk

From Mark Brown <broonie@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH] ASoC: pcm3168a: Call clk_set_rate in pcm3168a_set_dai_sysclk
Date 2016-01-29 00:20 +0100
Message-ID <qW414-2cO-35@gated-at.bofh.it> (permalink)
References <qW414-2cO-37@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Thu, Jan 28, 2016 at 04:54:20PM +0000, Damien Horsley wrote:

> +	ret = clk_set_rate(pcm3168a->scki, freq);
> +	if (ret)
> +		return ret;
> +
>  	pcm3168a->sysclk = freq;

Since the clock appears to be mandatory in this driver (good!) why are
we even storing sysclk?  Just remove it, the driver never actually used
it anyway.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH] ASoC: pcm3168a: Call clk_set_rate in  pcm3168a_set_dai_sysclk Mark Brown <broonie@kernel.org> - 2016-01-29 00:20 +0100

csiph-web