Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1318970 > unrolled thread
| Started by | Linus Walleij <linus.walleij@linaro.org> |
|---|---|
| First post | 2016-01-27 15:00 +0100 |
| Last post | 2016-01-27 20:10 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 2/2] gpio: davinci: use irq_data_get_chip_type Linus Walleij <linus.walleij@linaro.org> - 2016-01-27 15:00 +0100
Re: [PATCH 2/2] gpio: davinci: use irq_data_get_chip_type Grygorii Strashko <grygorii.strashko@ti.com> - 2016-01-27 17:40 +0100
Re: [PATCH 2/2] gpio: davinci: use irq_data_get_chip_type santosh shilimkar <santosh.shilimkar@oracle.com> - 2016-01-27 20:10 +0100
| From | Linus Walleij <linus.walleij@linaro.org> |
|---|---|
| Date | 2016-01-27 15:00 +0100 |
| Subject | Re: [PATCH 2/2] gpio: davinci: use irq_data_get_chip_type |
| Message-ID | <qVyNB-4jj-9@gated-at.bofh.it> |
On Wed, Dec 30, 2015 at 3:16 PM, Geliang Tang <geliangtang@163.com> wrote:
> Use irq_data_get_chip_type() instead of container_of().
>
> Signed-off-by: Geliang Tang <geliangtang@163.com>
> ---
> drivers/gpio/gpio-davinci.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
> index 65ebaef..aaa1a249 100644
> --- a/drivers/gpio/gpio-davinci.c
> +++ b/drivers/gpio/gpio-davinci.c
> @@ -435,8 +435,7 @@ static struct irq_chip *davinci_gpio_get_irq_chip(unsigned int irq)
> {
> static struct irq_chip_type gpio_unbanked;
>
> - gpio_unbanked = *container_of(irq_get_chip(irq),
> - struct irq_chip_type, chip);
> + gpio_unbanked = *irq_data_get_chip_type(irq_get_irq_data(irq));
>
> return &gpio_unbanked.chip;
> };
Grygorii/Santosh, can you ACK/comment on this patch?
Yours,
Linus Walleij
[toc] | [next] | [standalone]
| From | Grygorii Strashko <grygorii.strashko@ti.com> |
|---|---|
| Date | 2016-01-27 17:40 +0100 |
| Message-ID | <qVBiq-6lh-1@gated-at.bofh.it> |
| In reply to | #1318970 |
On 01/27/2016 03:56 PM, Linus Walleij wrote:
> On Wed, Dec 30, 2015 at 3:16 PM, Geliang Tang <geliangtang@163.com> wrote:
>
>> Use irq_data_get_chip_type() instead of container_of().
>>
>> Signed-off-by: Geliang Tang <geliangtang@163.com>
>> ---
>> drivers/gpio/gpio-davinci.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
>> index 65ebaef..aaa1a249 100644
>> --- a/drivers/gpio/gpio-davinci.c
>> +++ b/drivers/gpio/gpio-davinci.c
>> @@ -435,8 +435,7 @@ static struct irq_chip *davinci_gpio_get_irq_chip(unsigned int irq)
>> {
>> static struct irq_chip_type gpio_unbanked;
>>
>> - gpio_unbanked = *container_of(irq_get_chip(irq),
>> - struct irq_chip_type, chip);
>> + gpio_unbanked = *irq_data_get_chip_type(irq_get_irq_data(irq));
>>
>> return &gpio_unbanked.chip;
>> };
>
> Grygorii/Santosh, can you ACK/comment on this patch?
>
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
--
regards,
-grygorii
[toc] | [prev] | [next] | [standalone]
| From | santosh shilimkar <santosh.shilimkar@oracle.com> |
|---|---|
| Date | 2016-01-27 20:10 +0100 |
| Message-ID | <qVDDA-8gU-11@gated-at.bofh.it> |
| In reply to | #1319142 |
On 1/27/2016 8:35 AM, Grygorii Strashko wrote:
> On 01/27/2016 03:56 PM, Linus Walleij wrote:
>> On Wed, Dec 30, 2015 at 3:16 PM, Geliang Tang <geliangtang@163.com>
>> wrote:
>>
>>> Use irq_data_get_chip_type() instead of container_of().
>>>
>>> Signed-off-by: Geliang Tang <geliangtang@163.com>
>>> ---
>>> drivers/gpio/gpio-davinci.c | 3 +--
>>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
>>> index 65ebaef..aaa1a249 100644
>>> --- a/drivers/gpio/gpio-davinci.c
>>> +++ b/drivers/gpio/gpio-davinci.c
>>> @@ -435,8 +435,7 @@ static struct irq_chip
>>> *davinci_gpio_get_irq_chip(unsigned int irq)
>>> {
>>> static struct irq_chip_type gpio_unbanked;
>>>
>>> - gpio_unbanked = *container_of(irq_get_chip(irq),
>>> - struct irq_chip_type, chip);
>>> + gpio_unbanked = *irq_data_get_chip_type(irq_get_irq_data(irq));
>>>
>>> return &gpio_unbanked.chip;
>>> };
>>
>> Grygorii/Santosh, can you ACK/comment on this patch?
>>
>
> Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
>
Acked-by: Santosh Shilimkar <ssantosh@kernel.org>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web