Re: [PATCH 2/2] gpio: davinci: use irq_data_get_chip_type

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] gpio: davinci: use irq_data_get_chip_type
Date	2016-01-27 15:00 +0100
Message-ID	<qVyNB-4jj-9@gated-at.bofh.it> (permalink)
References	<qLpLz-7Id-5@gated-at.bofh.it> <qLpLA-7Id-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Dec 30, 2015 at 3:16 PM, Geliang Tang <geliangtang@163.com> wrote:

> Use irq_data_get_chip_type() instead of container_of().
>
> Signed-off-by: Geliang Tang <geliangtang@163.com>
> ---
>  drivers/gpio/gpio-davinci.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
> index 65ebaef..aaa1a249 100644
> --- a/drivers/gpio/gpio-davinci.c
> +++ b/drivers/gpio/gpio-davinci.c
> @@ -435,8 +435,7 @@ static struct irq_chip *davinci_gpio_get_irq_chip(unsigned int irq)
>  {
>         static struct irq_chip_type gpio_unbanked;
>
> -       gpio_unbanked = *container_of(irq_get_chip(irq),
> -                                     struct irq_chip_type, chip);
> +       gpio_unbanked = *irq_data_get_chip_type(irq_get_irq_data(irq));
>
>         return &gpio_unbanked.chip;
>  };

Grygorii/Santosh, can you ACK/comment on this patch?

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/2] gpio: davinci: use irq_data_get_chip_type Linus Walleij <linus.walleij@linaro.org> - 2016-01-27 15:00 +0100
  Re: [PATCH 2/2] gpio: davinci: use irq_data_get_chip_type Grygorii Strashko <grygorii.strashko@ti.com> - 2016-01-27 17:40 +0100
    Re: [PATCH 2/2] gpio: davinci: use irq_data_get_chip_type santosh shilimkar <santosh.shilimkar@oracle.com> - 2016-01-27 20:10 +0100

csiph-web