Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1318044 > unrolled thread

[PATCH] regulator: core: Clear constraints pointer after free on error path

Back to article view | Back to linux.kernel

Contents

  [PATCH] regulator: core: Clear constraints pointer after free on error path Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2016-01-26 16:20 +0100
    Re: [PATCH] regulator: core: Clear constraints pointer after free on  error path Mark Brown <broonie@kernel.org> - 2016-01-26 16:40 +0100
      Re: [PATCH] regulator: core: Clear constraints pointer after free on  error path Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2016-01-26 17:00 +0100

#1318044 — [PATCH] regulator: core: Clear constraints pointer after free on error path

As we now free the constraints in regulator_dev_release we will still
call free on the constraints pointer even if we went down an error path
in regulator_register, as such we need to clear to the pointer to ensure
the kfree in regulator_dev_release is a no-op.

Fixes: 29f5f4860a8e ("regulator: core: Move more deallocation into class unregister")
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
---
 drivers/regulator/core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index 744c988..a7936ab 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -3980,6 +3980,7 @@ unset_supplies:
 scrub:
 	regulator_ena_gpio_free(rdev);
 	kfree(rdev->constraints);
+	rdev->constraints = NULL;
 wash:
 	device_unregister(&rdev->dev);
 	/* device core frees rdev */
-- 
2.1.4

[toc] | [next] | [standalone]

#1318060 — Re: [PATCH] regulator: core: Clear constraints pointer after free on error path

[Multipart message — attachments visible in raw view] — view raw

On Tue, Jan 26, 2016 at 03:14:16PM +0000, Charles Keepax wrote:

> As we now free the constraints in regulator_dev_release we will still
> call free on the constraints pointer even if we went down an error path
> in regulator_register, as such we need to clear to the pointer to ensure
> the kfree in regulator_dev_release is a no-op.

No, this is just making things worse - if we're doing the free in the
release we should be doing the free in the release not sometimes maybey
in the release.

[toc] | [prev] | [next] | [standalone]

#1318093 — Re: [PATCH] regulator: core: Clear constraints pointer after free on error path

On Tue, Jan 26, 2016 at 03:34:54PM +0000, Mark Brown wrote:
> On Tue, Jan 26, 2016 at 03:14:16PM +0000, Charles Keepax wrote:
> 
> > As we now free the constraints in regulator_dev_release we will still
> > call free on the constraints pointer even if we went down an error path
> > in regulator_register, as such we need to clear to the pointer to ensure
> > the kfree in regulator_dev_release is a no-op.
> 
> No, this is just making things worse - if we're doing the free in the
> release we should be doing the free in the release not sometimes maybey
> in the release.

Fair enough I will respin to remove the other free's.

Thanks,
Charles

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web