Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1318060
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] regulator: core: Clear constraints pointer after free on error path |
| Date | 2016-01-26 16:40 +0100 |
| Message-ID | <qVdSO-644-9@gated-at.bofh.it> (permalink) |
| References | <qVdzt-5Vw-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Tue, Jan 26, 2016 at 03:14:16PM +0000, Charles Keepax wrote: > As we now free the constraints in regulator_dev_release we will still > call free on the constraints pointer even if we went down an error path > in regulator_register, as such we need to clear to the pointer to ensure > the kfree in regulator_dev_release is a no-op. No, this is just making things worse - if we're doing the free in the release we should be doing the free in the release not sometimes maybey in the release.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] regulator: core: Clear constraints pointer after free on error path Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2016-01-26 16:20 +0100
Re: [PATCH] regulator: core: Clear constraints pointer after free on error path Mark Brown <broonie@kernel.org> - 2016-01-26 16:40 +0100
Re: [PATCH] regulator: core: Clear constraints pointer after free on error path Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2016-01-26 17:00 +0100
csiph-web